add oneDNN graph fuser context API and unittest #82491

wenzhe-nrv · 2022-07-29T19:02:09Z

Description

Add oneDNN graph context manager API to be consistent with other fusers.

NNC and nvFuser have two ways to use: 1) a function to enable/disable and 2) a context manager. And the later way is used extensively in libraries like Dynamo. Currently oneDNN Graph fuser only has the former way. To promote the usage of oneDNN graph fuser, this PR creates the context manager for oneDNN graph fuser.

This PR should not affect any performance.

Testing

A unit-test test_context_manager is added under test/test_jit_llga_fuser.py

facebook-github-bot · 2022-07-29T19:02:15Z

🔗 Helpful links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/82491
✖️ Python docs build was skipped
✖️ C++ docs build was skipped
❓Need help or want to give feedback on the CI? Visit our office hours

✅ 1 Base Failures

As of commit c6f5d6ec31 (more details on the Dr. CI page):

Expand to see more

✅ None of the CI failures appear to be your fault 💚

1/1 broken upstream at merge base a3c60a4 on Sep 01 from 3:39pm to 4:52pm

🚧 1 fixed upstream failure:

These were probably caused by upstream breakages that were already fixed.

Please rebase on the viable/strict branch (expand for instructions)

If your commit is older than viable/strict, run these commands:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD

Lint / lintrunner on Sep 01 from 3:39pm to 4:52pm (a3c60a4 - 375d6cd)

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

wenzhe-nrv · 2022-07-29T19:03:21Z

cc: @chunyuan-w @jgong5

wenzhe-nrv · 2022-08-17T18:21:38Z

@pytorchbot rebase

pytorchmergebot · 2022-08-17T18:34:41Z

@pytorchbot successfully started a rebase job. Check the current status here

pytorchmergebot · 2022-08-17T18:34:45Z

Successfully rebased onednn_fuser_api onto refs/remotes/origin/master, please pull locally before adding more changes (for example, via git checkout onednn_fuser_api && git pull --rebase)

malfet

LGTM, but what would be the test time increase after this one is enabled?

wenzhe-nrv · 2022-08-30T00:45:40Z

@malfet thank you.

The added test test_context_manager ran in 0.065s based on the log.

Ran 1 test in 0.065s

wenzhe-nrv · 2022-09-01T16:43:39Z

@malfet I want to check with you if the above test time is ok and we could merge. Thanks.

malfet · 2022-09-01T16:45:13Z

@pytorchbot merge -g

Yeah, this test time is fine

pytorchmergebot · 2022-09-01T16:46:37Z

@pytorchbot successfully started a merge job. Check the current status here.
The merge job was triggered with the green (-g) flag. This means that your change will be merged once all checks on your PR have passed (ETA: 0-4 Hours). If this is not the intended behavior, feel free to use some of the other merge options in the wiki.
Please reach out to the PyTorch DevX Team with feedback or questions!

pytorchmergebot · 2022-09-01T16:46:38Z

Merge failed

Reason: This PR is too stale; the last push date was more than 3 days ago. Please rebase and try again.

Details for Dev Infra team

Raised by workflow job

wenzhe-nrv · 2022-09-01T17:05:09Z

@pytorchbot rebase

pytorchmergebot · 2022-09-01T17:06:52Z

@pytorchbot successfully started a rebase job. Check the current status here

pytorchmergebot · 2022-09-01T17:06:56Z

Successfully rebased onednn_fuser_api onto refs/remotes/origin/master, please pull locally before adding more changes (for example, via git checkout onednn_fuser_api && git pull --rebase)

wenzhe-nrv · 2022-09-01T22:48:33Z

@pytorchbot rebase

pytorchmergebot · 2022-09-01T22:50:22Z

@pytorchbot successfully started a rebase job. Check the current status here

pytorchmergebot · 2022-09-01T22:50:28Z

Successfully rebased onednn_fuser_api onto refs/remotes/origin/master, please pull locally before adding more changes (for example, via git checkout onednn_fuser_api && git pull --rebase)

wenzhe-nrv · 2022-09-12T16:37:56Z

@pytorchbot rebase

pytorchmergebot · 2022-09-12T16:40:10Z

@pytorchbot successfully started a rebase job. Check the current status here

pytorchmergebot · 2022-09-12T16:40:17Z

Successfully rebased onednn_fuser_api onto refs/remotes/origin/master, please pull locally before adding more changes (for example, via git checkout onednn_fuser_api && git pull --rebase)

pytorch-bot · 2022-09-12T16:40:22Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/82491

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures, 1 Pending

As of commit 11ef1e3:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

wenzhe-nrv · 2022-09-12T20:06:48Z

@pytorchbot merge -g

pytorchmergebot · 2022-09-12T20:08:57Z

@pytorchbot successfully started a merge job. Check the current status here.
The merge job was triggered with the green (-g) flag. This means that your change will be merged once all checks on your PR have passed (ETA: 0-4 Hours). If this is not the intended behavior, feel free to use some of the other merge options in the wiki.
Please reach out to the PyTorch DevX Team with feedback or questions!

github-actions · 2022-09-12T20:09:40Z

Hey @wenzhe-nrv.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

### Description Add oneDNN graph context manager API to be consistent with other fusers. NNC and nvFuser have two ways to use: 1) a function to enable/disable and 2) a context manager. And the later way is used extensively in libraries like Dynamo. Currently oneDNN Graph fuser only has the former way. To promote the usage of oneDNN graph fuser, this PR creates the context manager for oneDNN graph fuser. This PR should not affect any performance. ### Testing A unit-test `test_context_manager` is added under `test/test_jit_llga_fuser.py` Pull Request resolved: #82491 Approved by: https://github.com/malfet

facebook-github-bot added the cla signed label Jul 29, 2022

facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Jul 29, 2022

pytorchbot added the open source label Jul 29, 2022

wenzhe-nrv force-pushed the onednn_fuser_api branch from 4e5062c to 08fe1b2 Compare August 1, 2022 17:58

albanD requested review from eellison and suo August 3, 2022 14:35

albanD added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Aug 3, 2022

yanbing-j added the intel This tag is for PR from Intel label Aug 16, 2022

pytorchmergebot force-pushed the onednn_fuser_api branch from f7c05ac to 38a8b8f Compare August 17, 2022 18:34

yanbing-j added the intel priority matters to intel architecture from performance wise label Aug 18, 2022

malfet approved these changes Aug 27, 2022

View reviewed changes

pytorchmergebot force-pushed the onednn_fuser_api branch from 38a8b8f to b6aa6bc Compare September 1, 2022 17:07

pytorchmergebot force-pushed the onednn_fuser_api branch from b6aa6bc to c6f5d6e Compare September 1, 2022 22:50

wenzhe-nrv added 3 commits September 12, 2022 16:40

add oneDNN graph fuser context API and unittest

76afc08

fix comment format

cec6a99

add default _C llga api

11ef1e3

pytorchmergebot force-pushed the onednn_fuser_api branch from c6f5d6e to 11ef1e3 Compare September 12, 2022 16:40

pytorchmergebot added the Merged label Sep 12, 2022

pytorchmergebot closed this in a2cccb2 Sep 12, 2022

wenzhe-nrv deleted the onednn_fuser_api branch September 12, 2022 20:11

wenzhe-nrv mentioned this pull request Sep 15, 2022

add oneDNN graph backend for CPU pytorch/torchdynamo#1240

Merged

fzhao3 mentioned this pull request Jan 13, 2023

[RFC] Add JIT graph fuser for oneDNN Graph API #49444

Open

add oneDNN graph fuser context API and unittest #82491

add oneDNN graph fuser context API and unittest #82491

Uh oh!

Conversation

wenzhe-nrv commented Jul 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Testing

Uh oh!

facebook-github-bot commented Jul 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful links

✅ 1 Base Failures

🚧 1 fixed upstream failure:

Uh oh!

wenzhe-nrv commented Jul 29, 2022

Uh oh!

wenzhe-nrv commented Aug 17, 2022

Uh oh!

pytorchmergebot commented Aug 17, 2022

Uh oh!

pytorchmergebot commented Aug 17, 2022

Uh oh!

malfet left a comment

Choose a reason for hiding this comment

Uh oh!

wenzhe-nrv commented Aug 30, 2022

Uh oh!

wenzhe-nrv commented Sep 1, 2022

Uh oh!

malfet commented Sep 1, 2022

Uh oh!

pytorchmergebot commented Sep 1, 2022

Uh oh!

pytorchmergebot commented Sep 1, 2022

Merge failed

Uh oh!

wenzhe-nrv commented Sep 1, 2022

Uh oh!

pytorchmergebot commented Sep 1, 2022

Uh oh!

pytorchmergebot commented Sep 1, 2022

Uh oh!

wenzhe-nrv commented Sep 1, 2022

Uh oh!

pytorchmergebot commented Sep 1, 2022

Uh oh!

pytorchmergebot commented Sep 1, 2022

Uh oh!

wenzhe-nrv commented Sep 12, 2022

Uh oh!

pytorchmergebot commented Sep 12, 2022

Uh oh!

pytorchmergebot commented Sep 12, 2022

Uh oh!

pytorch-bot bot commented Sep 12, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/82491

✅ No Failures, 1 Pending

Uh oh!

wenzhe-nrv commented Sep 12, 2022

Uh oh!

pytorchmergebot commented Sep 12, 2022

Uh oh!

github-actions bot commented Sep 12, 2022

Uh oh!

Uh oh!

wenzhe-nrv commented Jul 29, 2022 •

edited

Loading

facebook-github-bot commented Jul 29, 2022 •

edited

Loading

pytorch-bot bot commented Sep 12, 2022 •

edited

Loading