-
Notifications
You must be signed in to change notification settings - Fork 25.2k
[mergebot] Add Land Check Troubleshooting Message #82580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results here
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 FailuresAs of commit c440310: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
@@ -1238,6 +1238,10 @@ def handle_exception(e: Exception, msg: str = "Merge failed") -> None: | |||
run_url = os.getenv("GH_RUN_URL") | |||
if run_url is not None: | |||
msg += f"\nRaised by {run_url}" | |||
if land_checks: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should be more descriptive with what merge -g does (and how it's different) and same with merge -f. Maybe we can update our wiki to describe these in more detail and then just link to that wiki here as well.
@pytorchbot merge -g |
@pytorchbot successfully started a merge job. Check the current status here |
Merge failed due to Refusing to merge as mandatory check(s) pull failed for rule OSS CI |
@pytorchbot merge -f "[OTHER] Lint should be enough" |
@pytorchbot successfully started a merge job. Check the current status here |
Hey @zengk95. |
Summary: ### Description Land checks are new and people can get confused on how to use it. In this, we make it a bit clearer to the user that they can use pytorchbot merge -g or -f to merge it in if they believe that there's infra issues with the land check. ### Issue N/a ### Testing N/a. Lint should be enough. Pull Request resolved: #82580 Approved by: https://github.com/huydhn Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/c041b2f158b437850a516095b8fbb11a805f96a9 Reviewed By: kit1980 Differential Revision: D38359311 Pulled By: zengk95 fbshipit-source-id: c53559fc5b168c592e74061347b05991dfc53d8d
Description
Land checks are new and people can get confused on how to use it. In this, we make it a bit clearer to the user that they can use pytorchbot merge -g or -f to merge it in if they believe that there's infra issues with the land check.
Issue
N/a
Testing
N/a. Lint should be enough.