Skip to content

[ONNX] Remove unused patching methods #83006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

[ONNX] Remove unused patching methods #83006

wants to merge 4 commits into from

Conversation

justinchuby
Copy link
Collaborator

@justinchuby justinchuby commented Aug 8, 2022 •
edited
Loading

Stack from ghstack (oldest at bottom):

Description

Remove unused patching methods:

  • torch._C.Graph.constant
  • unpatch torch._C.Node.__getitem__ and move the helper function to symbolic_helper

Add typing annotations

Issue

#76254

Testing

Unit tested

@justinchuby
[ONNX] Remove unused patching methods
7505e28 
### Description
<!-- What did you change and why was it needed? -->

Remove unused patching methods:

- `torch._C.Graph.constant`
- unpatch `torch._C.Node.__getitem__` and move the helper function to `symbolic_helper`

Add typing annotations

### Issue
<!-- Link to Issue ticket or RFP -->

#76254

### Testing
<!-- How did you test your change? -->

Unit tested

[ghstack-poisoned]
This was referenced Aug 8, 2022
Closed
Closed
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 8, 2022 •
edited
Loading

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit b305518 (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@justinchuby justinchuby added the module: onnx Related to torch.onnx label Aug 8, 2022
@justinchuby justinchuby mentioned this pull request Aug 8, 2022
Closed
@justinchuby justinchuby mentioned this pull request Aug 8, 2022
Closed
justinchuby added a commit to justinchuby/pytorch that referenced this pull request Aug 8, 2022
@justinchuby
[ONNX] Remove unused patching methods
9554579 
### Description
<!-- What did you change and why was it needed? -->

Remove unused patching methods:

- `torch._C.Graph.constant`
- unpatch `torch._C.Node.__getitem__` and move the helper function to `symbolic_helper`

Add typing annotations

### Issue
<!-- Link to Issue ticket or RFP -->

pytorch#76254

### Testing
<!-- How did you test your change? -->

Unit tested

ghstack-source-id: 2ae9f13
Pull Request resolved: pytorch#83006
@justinchuby
Update on "[ONNX] Remove unused patching methods"
8e1a446 
### Description
<!-- What did you change and why was it needed? -->

Remove unused patching methods:

- `torch._C.Graph.constant`
- unpatch `torch._C.Node.__getitem__` and move the helper function to `symbolic_helper`

Add typing annotations

### Issue
<!-- Link to Issue ticket or RFP -->

#76254

### Testing
<!-- How did you test your change? -->

Unit tested

[ghstack-poisoned]
justinchuby added a commit to justinchuby/pytorch that referenced this pull request Aug 8, 2022
@justinchuby
[ONNX] Remove unused patching methods
3afa4d3 
<!-- What did you change and why was it needed? -->

Remove unused patching methods:

- `torch._C.Graph.constant`
- unpatch `torch._C.Node.__getitem__` and move the helper function to `symbolic_helper`

Add typing annotations

<!-- Link to Issue ticket or RFP -->

<!-- How did you test your change? -->

Unit tested

ghstack-source-id: d9f2089
Pull Request resolved: pytorch#83006
@justinchuby
Update on "[ONNX] Remove unused patching methods"
fdf9701 
### Description
<!-- What did you change and why was it needed? -->

Remove unused patching methods:

- `torch._C.Graph.constant`
- unpatch `torch._C.Node.__getitem__` and move the helper function to `symbolic_helper`

Add typing annotations

### Issue
<!-- Link to Issue ticket or RFP -->

#76254

### Testing
<!-- How did you test your change? -->

Unit tested

[ghstack-poisoned]
@justinchuby
Update on "[ONNX] Remove unused patching methods"
b305518 
### Description
<!-- What did you change and why was it needed? -->

Remove unused patching methods:

- `torch._C.Graph.constant`
- unpatch `torch._C.Node.__getitem__` and move the helper function to `symbolic_helper`

Add typing annotations

### Issue
<!-- Link to Issue ticket or RFP -->

#76254

### Testing
<!-- How did you test your change? -->

Unit tested

[ghstack-poisoned]
justinchuby added a commit to justinchuby/pytorch that referenced this pull request Aug 9, 2022
@justinchuby
[ONNX] Remove unused patching methods
3c20a49 
<!-- What did you change and why was it needed? -->

Remove unused patching methods:

- `torch._C.Graph.constant`
- unpatch `torch._C.Node.__getitem__` and move the helper function to `symbolic_helper`

Add typing annotations

<!-- Link to Issue ticket or RFP -->

<!-- How did you test your change? -->

Unit tested

ghstack-source-id: 795d48e
Pull Request resolved: pytorch#83006
BowenBao
BowenBao reviewed Aug 9, 2022
View reviewed changes
BowenBao
BowenBao reviewed Aug 9, 2022
View reviewed changes
torch/onnx/utils.py
symbolic_caffe2.register_quantized_ops("caffe2", opset_version)

if ns == "aten":
if namespace == "aten":
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Some of these are not related to "Remove unused patching methods"...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will break them out

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I will keep them in if you are ok with it, since this function is touched by the removal (https://github.com/pytorch/pytorch/pull/83006/files/b305518f3ed8d57b78dcfcaeb861c6c53c2a5df2#diff-849a5778e2dcf7f36587967273cee0bf20642e35bf4c79405111ea3417c3fb3cR1748-R1751 etc) and a mild clean up doesn't seem too noisy?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mark as resolved for this one. I will break changes like this out in the future. Thanks!

@justinchuby
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here

@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2022

Hey @justinchuby.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@justinchuby justinchuby added release notes: onnx torch.onnx related changes that should show up in the release notes topic: deprecation topic category labels Aug 9, 2022
facebook-github-bot pushed a commit that referenced this pull request Aug 10, 2022
@justinchuby @facebook-github-bot
[ONNX] Remove unused patching methods (#83006) (#83006)
b54d520 
Summary:
### Description
<!-- What did you change and why was it needed? -->

Remove unused patching methods:

- `torch._C.Graph.constant`
- unpatch `torch._C.Node.__getitem__` and move the helper function to `symbolic_helper`

Add typing annotations

### Issue
<!-- Link to Issue ticket or RFP -->

#76254

### Testing
<!-- How did you test your change? -->

Unit tested

Pull Request resolved: #83006
Approved by: https://github.com/BowenBao

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/f5701a1f9afc1775bbf259b5fc8b502b17a56288

Reviewed By: seemethere

Differential Revision: D38585554

fbshipit-source-id: 810a6f4e8eb83f50f10ed9c48bf0ddd0d3fefec0
@facebook-github-bot facebook-github-bot deleted the gh/justinchuby/2/head branch August 13, 2022 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BowenBao BowenBao BowenBao approved these changes

@shubhambhokare1 shubhambhokare1 Awaiting requested review from shubhambhokare1

Assignees
No one assigned
Labels
cla signed Merged module: onnx Related to torch.onnx open source release notes: onnx torch.onnx related changes that should show up in the release notes topic: deprecation topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@justinchuby @facebook-github-bot @pytorchmergebot @BowenBao @pytorchbot