Skip to content

Correct DDP example #83034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Correct DDP example #83034

wants to merge 1 commit into from

Conversation

wangkuiyi
Copy link
Contributor

@wangkuiyi wangkuiyi commented Aug 8, 2022 •
edited by mrshenli
Loading

remove undefined pg from DDP example code

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 8, 2022 •
edited
Loading

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit 2ee0284 (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@facebook-github-bot facebook-github-bot added the oncall: distributed Add this issue/PR to distributed oncall triage queue label Aug 8, 2022
mrshenli
mrshenli approved these changes Aug 8, 2022
View reviewed changes
Copy link
Contributor

@mrshenli mrshenli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@wangkuiyi
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here

@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2022

Hey @wangkuiyi.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@wangkuiyi wangkuiyi added release notes: distributed (ddp) release notes category topic: docs topic category labels Aug 9, 2022
facebook-github-bot pushed a commit that referenced this pull request Aug 10, 2022
@wangkuiyi @facebook-github-bot
Correct DDP example (#83034) (#83034)
085db18 
Summary:
remove undefined `pg` from DDP example code

Pull Request resolved: #83034
Approved by: https://github.com/mrshenli

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/08d54b5cd5090cd3ac86e377b798fc231514dce9

Reviewed By: seemethere

Differential Revision: D38585534

Pulled By: wangkuiyi

fbshipit-source-id: 20d67dffcfdba74b374098f113c405df9f00455b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrshenli mrshenli mrshenli approved these changes

@zhaojuanmao zhaojuanmao Awaiting requested review from zhaojuanmao

@pritamdamania87 pritamdamania87 Awaiting requested review from pritamdamania87

@rohan-varma rohan-varma Awaiting requested review from rohan-varma

@mingzhe09088 mingzhe09088 Awaiting requested review from mingzhe09088

@H-Huang H-Huang Awaiting requested review from H-Huang

@awgu awgu Awaiting requested review from awgu

Assignees
No one assigned
Labels
cla signed Merged oncall: distributed Add this issue/PR to distributed oncall triage queue release notes: distributed (ddp) release notes category topic: docs topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wangkuiyi @facebook-github-bot @pytorchmergebot @mrshenli