Skip to content

[Shape Fns] Fix optional None for the actual shape functions #83092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

Gamrix
Copy link
Contributor

@Gamrix Gamrix commented Aug 9, 2022

I think the person who edited mean.dim edited the python and the associated Torchscript version manually in two different ways. This diff fixes that all up. It also fixes the inconsistencies in the torch.nonzero generated file

Stack from ghstack:

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 9, 2022

🔗 Helpful links

❌ 1 New Failures

As of commit 1d63f53 (more details on the Dr. CI page):

Expand to see more
  • 1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages

See GitHub Actions build pull / linux-focal-py3.7-clang10-onnx / test (default, 1, 2, linux.2xlarge) (1/1)

Step: "Test" (full log | diagnosis details)

2022-08-09T21:17:14.2783405Z TypeError: cannot unpack non-iterable torch._C.Value object
2022-08-09T21:17:14.2776097Z   File "/opt/conda/lib/python3.7/site-packages/torch/onnx/utils.py", line 1062, in _model_to_graph
2022-08-09T21:17:14.2776731Z     module=module,
2022-08-09T21:17:14.2777489Z   File "/opt/conda/lib/python3.7/site-packages/torch/onnx/utils.py", line 624, in _optimize_graph
2022-08-09T21:17:14.2778150Z     graph = _C._jit_pass_onnx(graph, operator_export_type)
2022-08-09T21:17:14.2778995Z   File "/opt/conda/lib/python3.7/site-packages/torch/onnx/utils.py", line 1744, in _run_symbolic_function
2022-08-09T21:17:14.2779525Z     return symbolic_fn(g, *inputs, **attrs)
2022-08-09T21:17:14.2780466Z   File "/opt/conda/lib/python3.7/site-packages/torch/onnx/symbolic_helper.py", line 249, in wrapper
2022-08-09T21:17:14.2780955Z     return fn(g, *args, **kwargs)
2022-08-09T21:17:14.2781772Z   File "/opt/conda/lib/python3.7/site-packages/torch/onnx/symbolic_opset9.py", line 2263, in layer_norm
2022-08-09T21:17:14.2782513Z     g, input, normalized_shape, weight, bias, eps, cudnn_enable, False
2022-08-09T21:17:14.2783405Z TypeError: cannot unpack non-iterable torch._C.Value object 
2022-08-09T21:17:14.2784059Z (Occurred when translating layer_norm).
2022-08-09T21:17:14.2784353Z 
2022-08-09T21:17:14.2784554Z 
2022-08-09T21:17:14.2785768Z 
2022-08-09T21:17:14.2785780Z 
2022-08-09T21:17:14.2787510Z [gw0] �[31mFAILED�[0m test/onnx/test_pytorch_onnx_no_runtime.py �[1A
2022-08-09T21:17:14.2947255Z  �[36mtest/onnx/test_pytorch_onnx_no_runtime.py�[0m::TestONNXExport.test_source_range_propagation�[0m �[31m⨯�[0m�[31m99% �[0m�[40m�[32m█�[0m�[40m�[32m█�[0m�[40m�[32m█�[0m�[40m�[32m█�[0m�[40m�[32m█�[0m�[40m�[32m█�[0m�[40m�[32m█�[0m�[40m�[32m█�[0m�[40m�[32m█�[0m�[40m�[31m▉�[0m�[1B
2022-08-09T21:17:14.2948211Z 
2022-08-09T21:17:14.2948379Z 
2022-08-09T21:17:14.2948385Z 

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Aug 9, 2022
I think the person who edited `mean.dim` edited the python and the associated Torchscript version manually in two different ways. This diff fixes that all up. It also fixes the inconsistencies in the `torch.nonzero` generated file




[ghstack-poisoned]
facebook-github-bot pushed a commit that referenced this pull request Aug 11, 2022
…#83092)

Summary:
I think the person who edited `mean.dim` edited the python and the associated Torchscript version manually in two different ways. This diff fixes that all up. It also fixes the inconsistencies in the `torch.nonzero` generated file

Pull Request resolved: #83092
Approved by: https://github.com/eellison

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/c8eae2de5200b95d59ab090a37eed96528c877ff

Reviewed By: seemethere

Differential Revision: D38600047

Pulled By: Gamrix

fbshipit-source-id: c7af43f6e2daa4b3776bb0c93c8d459744bd4bf5
@facebook-github-bot facebook-github-bot deleted the gh/gamrix/87/head branch August 14, 2022 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed oncall: jit Add this issue/PR to JIT oncall triage queue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants