Skip to content

lift numpy tensor, add randperm support #83191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

lift numpy tensor, add randperm support #83191

wants to merge 1 commit into from

Conversation

eellison
Copy link
Contributor

@eellison eellison commented Aug 10, 2022 •
edited
Loading

Stack from ghstack (oldest at bottom):

Couple changes needed to trace huggingface w fake tensors.

Similar to #81927, need to call liftfresh for tensors created from numpy tensors. Also adds randperm for meta.

eellison added a commit that referenced this pull request Aug 10, 2022
@eellison
lift numpy tensor, add randperm support
babf2a0 
ghstack-source-id: 8343c58
Pull Request resolved: #83191
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 10, 2022 •
edited
Loading

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit d8f75be (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@eellison eellison requested review from ezyang, Chillee and bdhirsh August 10, 2022 18:57
@eellison
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here

@github-actions
Copy link
Contributor

Hey @eellison.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request Aug 11, 2022
@eellison @facebook-github-bot
lift numpy tensor, add randperm support (#83191) (#83191)
26f27e5 
Summary:
Couple changes needed to trace huggingface w fake tensors.

Similar to #81927, need to call liftfresh for tensors created from numpy tensors. Also adds randperm for meta.

Pull Request resolved: #83191
Approved by: https://github.com/bdhirsh

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/8a6b076196f4169910b2c98d37e1faeaec316050

Reviewed By: seemethere

Differential Revision: D38600386

Pulled By: eellison

fbshipit-source-id: b9213ee0b18ab40e8bca06edd2cd0b387338cdaf
@facebook-github-bot facebook-github-bot deleted the gh/eellison/308/head branch August 14, 2022 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdhirsh bdhirsh bdhirsh approved these changes

@ezyang ezyang Awaiting requested review from ezyang

@Chillee Chillee Awaiting requested review from Chillee

Assignees
No one assigned
Labels
cla signed Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eellison @facebook-github-bot @pytorchmergebot @bdhirsh