Skip to content

Update proxy_tensor.py to support List input/output #83302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

Update proxy_tensor.py to support List input/output #83302

wants to merge 5 commits into from

Conversation

mrshenli
Copy link
Contributor

@mrshenli mrshenli commented Aug 11, 2022 •
edited
Loading

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 11, 2022 •
edited
Loading

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit 921305d (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

This was referenced Aug 11, 2022
Closed
Closed
@mrshenli mrshenli requested a review from Chillee August 25, 2022 15:32
Chillee
Chillee approved these changes Aug 25, 2022
View reviewed changes
Copy link
Collaborator

@Chillee Chillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to add a test for this?

@mrshenli
Copy link
Contributor Author

Hey @Chillee, thanks for the review! #81930 on top of this one uses allreduce to test the new code path. I will land these two together. Or does it worth it to create a custom test-only op to cover it?

@Chillee
Copy link
Collaborator

Chillee commented Aug 25, 2022

@mrshenli no that's fine.

@mrshenli mrshenli mentioned this pull request Aug 26, 2022
Closed
@mrshenli mrshenli mentioned this pull request Aug 26, 2022
Closed
@malfet malfet mentioned this pull request Aug 27, 2022
Closed
facebook-github-bot pushed a commit that referenced this pull request Aug 28, 2022
@mrshenli @facebook-github-bot
Update proxy_tensor.py to support List input/output (#83302) (#83302)
d214d44 
Summary:
Pull Request resolved: #83302
Approved by: https://github.com/Chillee

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/f93446adc2b5b90e144d1b0a3e81269ab0c3401b

Reviewed By: weiwangmeta

Differential Revision: D39084819

Pulled By: mrshenli

fbshipit-source-id: d342670d78c1797ecb197256166908e63a256ff9
@facebook-github-bot facebook-github-bot deleted the gh/mrshenli/334/head branch August 30, 2022 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chillee Chillee Chillee approved these changes

Assignees
No one assigned
Labels
cla signed fx
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mrshenli @facebook-github-bot @Chillee