-
Notifications
You must be signed in to change notification settings - Fork 25.2k
Coverage for nondeterministic_seeded, respect it in constant prop #83650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- nondeterministic_seeded was not applied to enough functions. I added some heuristics to codegen for identifying functions that are likely to be random and added a bunch of these tags to functions. Not sure I got all of them. - Don't constant propagate through nondeterministic functions in FX tracing. Signed-off-by: Edward Z. Yang <ezyang@fb.com> [ghstack-poisoned]
🔗 Helpful links
✅ No Failures (2 Pending)As of commit 240d82b (more details on the Dr. CI page): Expand to see more💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
…nt prop" - nondeterministic_seeded was not applied to enough functions. I added some heuristics to codegen for identifying functions that are likely to be random and added a bunch of these tags to functions. Not sure I got all of them. - Don't constant propagate through nondeterministic functions in FX tracing. Signed-off-by: Edward Z. Yang <ezyangfb.com> [ghstack-poisoned]
- nondeterministic_seeded was not applied to enough functions. I added some heuristics to codegen for identifying functions that are likely to be random and added a bunch of these tags to functions. Not sure I got all of them. - Don't constant propagate through nondeterministic functions in FX tracing. Signed-off-by: Edward Z. Yang <ezyangfb.com> ghstack-source-id: a4cc1cb Pull Request resolved: #83650
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM... while you're at it maybe update this https://github.com/pytorch/pytorch/blob/master/torch/fx/passes/dialect/common/cse_pass.py#L14 to use the nondeterministic_seeded
tag
@pytorchbot merge |
@pytorchbot successfully started a merge job. Check the current status here. |
Hey @ezyang. |
…3650) (#83650) Summary: - nondeterministic_seeded was not applied to enough functions. I added some heuristics to codegen for identifying functions that are likely to be random and added a bunch of these tags to functions. Not sure I got all of them. - Don't constant propagate through nondeterministic functions in FX tracing. It would be better to do some testing for the tag but this would be quite an effort. Signed-off-by: Edward Z. Yang <ezyang@fb.com> Pull Request resolved: #83650 Approved by: https://github.com/bdhirsh, https://github.com/eellison Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/91521449445077c9ee977b18e2d0f19be4dd1c5b Reviewed By: atalman Differential Revision: D38852525 Pulled By: ezyang fbshipit-source-id: f9c0b235c5e3760ac723d581c85304bf6f8c7e00
Stack from ghstack (oldest at bottom):
nondeterministic_seeded was not applied to enough functions. I added
some heuristics to codegen for identifying functions that are likely
to be random and added a bunch of these tags to functions. Not sure
I got all of them.
Don't constant propagate through nondeterministic functions in FX
tracing.
It would be better to do some testing for the tag but this would be quite an effort.
Signed-off-by: Edward Z. Yang ezyang@fb.com