Skip to content

[optim] rmsprop: handle complex params as independent real params #83860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

[optim] rmsprop: handle complex params as independent real params #83860

wants to merge 3 commits into from

Conversation

kshitij12345
Copy link
Collaborator

Ref: #65711

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 22, 2022 •
edited
Loading

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit 83ddac9 (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@kshitij12345 kshitij12345 marked this pull request as ready for review August 22, 2022 19:02
@kshitij12345 kshitij12345 requested a review from albanD as a code owner August 22, 2022 19:02
albanD
albanD approved these changes Aug 22, 2022
View reviewed changes
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@kshitij12345
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here.
The merge job was triggered without a flag. This means that your change will be merged once all checks on your PR have passed (ETA: 0-4 Hours). If this is not the intended behavior, feel free to use some of the other merge options in the wiki.
Please reach out to the PyTorch DevX Team with feedback or questions!

@github-actions
Copy link
Contributor

Hey @kshitij12345.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request Aug 24, 2022
@kshitij12345 @facebook-github-bot
[optim] rmsprop: handle complex params as independent real params (#8…
8d71b18 
…3860) (#83860)

Summary:
Ref: #65711

Pull Request resolved: #83860
Approved by: https://github.com/albanD

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/09331c947cd559211bec20fd016e48f86d48e51f

Reviewed By: weiwangmeta

Differential Revision: D38946977

fbshipit-source-id: b4ce00dc5fc878758cd4afb61039927898877a1c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albanD albanD albanD approved these changes

Assignees
No one assigned
Labels
cla signed Merged open source
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kshitij12345 @facebook-github-bot @pytorchmergebot @albanD @pytorchbot