Skip to content

Fix dumb make_fx issue #84011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Fix dumb make_fx issue #84011

wants to merge 4 commits into from

Conversation

Chillee
Copy link
Collaborator

@Chillee Chillee commented Aug 24, 2022 •
edited
Loading

@Chillee
Fix dumb make_fx issue
8bb0efa 
[ghstack-poisoned]
Chillee added a commit that referenced this pull request Aug 24, 2022
@Chillee
Fix dumb make_fx issue
662db39 
ghstack-source-id: fa66476
Pull Request resolved: #84011
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 24, 2022 •
edited
Loading

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit 365b9cc (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@Chillee Chillee requested a review from ezyang August 24, 2022 20:31
@Chillee Chillee mentioned this pull request Aug 25, 2022
Closed
@Chillee
Copy link
Collaborator Author

Chillee commented Aug 25, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here.
The merge job was triggered without a flag. This means that your change will be merged once all checks on your PR have passed (ETA: 0-4 Hours). If this is not the intended behavior, feel free to use some of the other merge options in the wiki.
Please reach out to the PyTorch DevX Team with feedback or questions!

@github-actions
Copy link
Contributor

Hey @Chillee.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request Aug 26, 2022
@Chillee @facebook-github-bot
Fix dumb make_fx issue (#84011) (#84011)
a443db3 
Summary:
Pull Request resolved: #84011
Approved by: https://github.com/ezyang

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/8b8942b11464bbe042b731bc332d65297161353a

Reviewed By: weiwangmeta

Differential Revision: D39011907

Pulled By: Chillee

fbshipit-source-id: 80b2bee24ce2c14fc44fc1af44a754143a02149d
@facebook-github-bot facebook-github-bot deleted the gh/chillee/113/head branch August 28, 2022 14:20
@Padarn Padarn mentioned this pull request Sep 3, 2022
Merged
@pbelevich pbelevich mentioned this pull request Sep 11, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezyang ezyang ezyang approved these changes

Assignees
No one assigned
Labels
cla signed fx Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Chillee @facebook-github-bot @pytorchmergebot @ezyang