Skip to content

Conversation

EikanWang
Copy link
Collaborator

@EikanWang EikanWang commented Aug 25, 2022

Stack from ghstack (oldest at bottom):

  • To support BF16 Immediate value by converting it to uint16. The behavior is as same as BF16 tensor
  • Enable BF16 test cases.

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 25, 2022

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit 6f4d40b (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Aug 25, 2022
EikanWang added a commit that referenced this pull request Aug 25, 2022
ghstack-source-id: 148a1f9
Pull Request resolved: #84041
EikanWang added a commit that referenced this pull request Aug 25, 2022
ghstack-source-id: ba82ced
Pull Request resolved: #84041
@EikanWang EikanWang added the NNC label Aug 26, 2022
@EikanWang EikanWang closed this Aug 28, 2022
@EikanWang EikanWang reopened this Aug 28, 2022
@EikanWang EikanWang requested a review from ZolotukhinM August 28, 2022 13:38
EikanWang added a commit that referenced this pull request Aug 29, 2022
ghstack-source-id: dd25955
Pull Request resolved: #84041
EikanWang added a commit that referenced this pull request Aug 30, 2022
ghstack-source-id: a26ca8b
Pull Request resolved: #84041
@pytorch-bot pytorch-bot bot added the release notes: jit release notes category label Sep 1, 2022
XiaobingSuper added a commit to XiaobingSuper/pytorch that referenced this pull request Sep 1, 2022
- To support BF16 Immediate value by converting it to uint16. The behavior is as same as BF16 tensor
- Enable BF16 test cases.

[ghstack-poisoned]
- To support BF16 Immediate value by converting it to uint16. The behavior is as same as BF16 tensor
- Enable BF16 test cases.

[ghstack-poisoned]
- To support BF16 Immediate value by converting it to uint16. The behavior is as same as BF16 tensor
- Enable BF16 test cases.

[ghstack-poisoned]
@frank-wei
Copy link
Contributor

@pytorchbot merge -l

@frank-wei
Copy link
Contributor

Could you pls check the failed tests?

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here and land check progress here.
The merge job was triggered with the land checks (-l) flag. If you did not specify this flag yourself, you are likely enrolled in the land checks rollout. This means that your change will be merged once all checks on your PR and the land checks have passed (ETA 4 Hours). If you need to coordinate lands between different changes and cannot risk a land race, please add the ciflow/trunk label to your PR and wait for signal to complete, and then land your changes in proper order. Having trunk, pull, and Lint pre-run on a PR will bypass land checks and the ETA should be immediate. If this is not the intended behavior, feel free to use some of the other merge options in the wiki.
Please reach out to the PyTorch DevX Team with feedback or questions!

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: The following mandatory check(s) failed (Rule superuser):

Dig deeper by viewing the failures on hud

If you believe this is an error, you can use the old behavior with @pytorchbot merge -g (optionally with the ciflow/trunk to get land checks) or use @pytorchbot merge -f "some reason here". For more information, see the bot wiki.

Please reach out to the PyTorch DevX Team with feedback or questions!

Details for Dev Infra team Raised by workflow job

- To support BF16 Immediate value by converting it to uint16. The behavior is as same as BF16 tensor
- Enable BF16 test cases.

[ghstack-poisoned]
@EikanWang
Copy link
Collaborator Author

Could you pls check the failed tests?

Yes. I fixed it and triggered the CI again. I will check the CI result.

- To support BF16 Immediate value by converting it to uint16. The behavior is as same as BF16 tensor
- Enable BF16 test cases.

[ghstack-poisoned]
- To support BF16 Immediate value by converting it to uint16. The behavior is as same as BF16 tensor
- Enable BF16 test cases.

[ghstack-poisoned]
pytorchmergebot pushed a commit that referenced this pull request Sep 21, 2022
- To support BF16 Immediate value by converting it to uint16. The behavior is as same as BF16 tensor
- Enable BF16 test cases.
Pull Request resolved: #84041
Approved by: https://github.com/ZolotukhinM
@EikanWang
Copy link
Collaborator Author

Could you pls check the failed tests?

Yes. I fixed it and triggered the CI again. I will check the CI result.

@frank-wei , this PR passed the CI. Could you review it?

@EikanWang
Copy link
Collaborator Author

@pytorchbot merge -l

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here and land check progress here.
The merge job was triggered with the land checks (-l) flag. If you did not specify this flag yourself, you are likely enrolled in the land checks rollout. This means that your change will be merged once all checks on your PR and the land checks have passed (ETA 4 Hours). If you need to coordinate lands between different changes and cannot risk a land race, please add the ciflow/trunk label to your PR and wait for signal to complete, and then land your changes in proper order. Having trunk, pull, and Lint pre-run on a PR will bypass land checks and the ETA should be immediate. If this is not the intended behavior, feel free to use some of the other merge options in the wiki.
Please reach out to the PyTorch DevX Team with feedback or questions!

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: Failed to merge; some land checks failed: Lint, Lint / lintrunner

If you believe this is an error, you can use the old behavior with @pytorchbot merge -g (optionally with the ciflow/trunk to get land checks) or use @pytorchbot merge -f "some reason here". For more information, see the bot wiki.

Please reach out to the PyTorch DevX Team with feedback or questions!

Details for Dev Infra team Raised by workflow job

- To support BF16 Immediate value by converting it to uint16. The behavior is as same as BF16 tensor
- Enable BF16 test cases.

[ghstack-poisoned]
- To support BF16 Immediate value by converting it to uint16. The behavior is as same as BF16 tensor
- Enable BF16 test cases.

[ghstack-poisoned]
@EikanWang
Copy link
Collaborator Author

@pytorchbot merge -l

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here and land check progress here.
The merge job was triggered with the land checks (-l) flag. If you did not specify this flag yourself, you are likely enrolled in the land checks rollout. This means that your change will be merged once all checks on your PR and the land checks have passed (ETA 4 Hours). If you need to coordinate lands between different changes and cannot risk a land race, please add the ciflow/trunk label to your PR and wait for signal to complete, and then land your changes in proper order. Having trunk, pull, and Lint pre-run on a PR will bypass land checks and the ETA should be immediate. If this is not the intended behavior, feel free to use some of the other merge options in the wiki.
Please reach out to the PyTorch DevX Team with feedback or questions!

@github-actions
Copy link
Contributor

Hey @EikanWang.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@facebook-github-bot facebook-github-bot deleted the gh/EikanWang/2/head branch September 27, 2022 14:19
mehtanirav pushed a commit that referenced this pull request Oct 4, 2022
- To support BF16 Immediate value by converting it to uint16. The behavior is as same as BF16 tensor
- Enable BF16 test cases.
Pull Request resolved: #84041
Approved by: https://github.com/ZolotukhinM
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed Merged NNC oncall: jit Add this issue/PR to JIT oncall triage queue open source release notes: jit release notes category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants