Use register_meta for everything in meta_registrations #84297

ezyang · 2022-08-30T19:29:28Z

Stack from ghstack (oldest at bottom):

-> Use register_meta for everything in meta_registrations #84297

Signed-off-by: Edward Z. Yang ezyang@fb.com

Signed-off-by: Edward Z. Yang <ezyang@fb.com> [ghstack-poisoned]

facebook-github-bot · 2022-08-30T19:29:35Z

🔗 Helpful links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/84297
✖️ Python docs build was skipped
✖️ C++ docs build was skipped
❓Need help or want to give feedback on the CI? Visit our office hours

✅ No Failures (0 Pending)

As of commit 6781448 (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

Signed-off-by: Edward Z. Yang <ezyangfb.com> [ghstack-poisoned]

ezyang · 2022-08-30T20:59:11Z

@pytorchbot merge

pytorchmergebot · 2022-08-30T21:03:14Z

@pytorchbot successfully started a merge job. Check the current status here.
The merge job was triggered without a flag. This means that your change will be merged once all checks on your PR have passed (ETA: 0-4 Hours). If this is not the intended behavior, feel free to use some of the other merge options in the wiki.
Please reach out to the PyTorch DevX Team with feedback or questions!

pytorchmergebot · 2022-08-30T21:23:23Z

Merge failed

Reason: View failures on hud. Refusing to merge as mandatory check(s) pull failed for rule superuser.

Details for Dev Infra team

Raised by workflow job

ezyang · 2022-08-30T22:28:39Z

@pytorchbot merge -f "known flaky test from master"

pytorchmergebot · 2022-08-30T22:30:41Z

@pytorchbot successfully started a merge job. Check the current status here.
The merge job was triggered with the force (-f) flag. This means your change will be merged immediately, bypassing any CI checks (ETA: 1-5 minutes). If this is not the intended behavior, feel free to use some of the other merge options in the wiki.
Please reach out to the PyTorch DevX Team with feedback or questions!

pytorchmergebot · 2022-08-30T22:30:45Z

Merge failed

Reason: Command git -C /home/runner/work/pytorch/pytorch cherry-pick -x b54786150632898e4a73b9cd97131fce04252afc returned non-zero exit code 1

Auto-merging test/test_proxy_tensor.py
CONFLICT (content): Merge conflict in test/test_proxy_tensor.py
error: could not apply b547861506... Use register_meta for everything in meta_registrations
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

Details for Dev Infra team

Raised by workflow job

Signed-off-by: Edward Z. Yang <ezyangfb.com> [ghstack-poisoned]

Signed-off-by: Edward Z. Yang <ezyangfb.com> ghstack-source-id: eba5a20 Pull Request resolved: #84297

ezyang · 2022-08-31T02:11:45Z

@pytorchbot merge

pytorchmergebot · 2022-08-31T02:13:19Z

@pytorchbot successfully started a merge job. Check the current status here.
The merge job was triggered without a flag. This means that your change will be merged once all checks on your PR have passed (ETA: 0-4 Hours). If this is not the intended behavior, feel free to use some of the other merge options in the wiki.
Please reach out to the PyTorch DevX Team with feedback or questions!

github-actions · 2022-08-31T02:14:09Z

Hey @ezyang.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

suo · 2022-08-31T16:31:00Z

@pytorchbot revert -m "broke test_proxy_tensor on master" -c nosignal

pytorchmergebot · 2022-08-31T16:32:21Z

@pytorchbot successfully started a revert job. Check the current status here.
Please reach out to the PyTorch DevX Team with feedback or questions!

pytorchmergebot · 2022-08-31T16:32:27Z

@ezyang your PR has been successfully reverted.

This reverts commit 8cd296f. Reverted #84297 on behalf of https://github.com/suo due to broke test_proxy_tensor on master

Signed-off-by: Edward Z. Yang <ezyangfb.com> [ghstack-poisoned]

ezyang · 2022-08-31T17:49:05Z

@pytorchbot merge

pytorchmergebot · 2022-08-31T17:50:27Z

@pytorchbot successfully started a merge job. Check the current status here.
The merge job was triggered without a flag. This means that your change will be merged once all checks on your PR have passed (ETA: 0-4 Hours). If this is not the intended behavior, feel free to use some of the other merge options in the wiki.
Please reach out to the PyTorch DevX Team with feedback or questions!

Signed-off-by: Edward Z. Yang <ezyangfb.com> [ghstack-poisoned]

Signed-off-by: Edward Z. Yang <ezyangfb.com> ghstack-source-id: 0cf333a Pull Request resolved: #84297

pytorchmergebot · 2022-08-31T18:45:39Z

Merge failed

Reason: New commits were pushed while merging. Please rerun the merge command.

Details for Dev Infra team

Raised by workflow job

ezyang · 2022-08-31T19:22:20Z

@pytorchbot merge

pytorchmergebot · 2022-08-31T19:23:55Z

@pytorchbot successfully started a merge job. Check the current status here.
The merge job was triggered without a flag. This means that your change will be merged once all checks on your PR have passed (ETA: 0-4 Hours). If this is not the intended behavior, feel free to use some of the other merge options in the wiki.
Please reach out to the PyTorch DevX Team with feedback or questions!

pytorchmergebot · 2022-08-31T19:28:59Z

Merge failed

Reason: View failures on hud. Refusing to merge as mandatory check(s) pull failed for rule superuser.

Details for Dev Infra team

Raised by workflow job

Signed-off-by: Edward Z. Yang <ezyangfb.com> [ghstack-poisoned]

Signed-off-by: Edward Z. Yang <ezyangfb.com> ghstack-source-id: 908e0e1 Pull Request resolved: #84297

ezyang · 2022-08-31T21:15:22Z

@pytorchbot merge

pytorchmergebot · 2022-08-31T21:17:42Z

@pytorchbot successfully started a merge job. Check the current status here.
The merge job was triggered without a flag. This means that your change will be merged once all checks on your PR have passed (ETA: 0-4 Hours). If this is not the intended behavior, feel free to use some of the other merge options in the wiki.
Please reach out to the PyTorch DevX Team with feedback or questions!

github-actions · 2022-08-31T23:59:16Z

Hey @ezyang.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

Summary: Signed-off-by: Edward Z. Yang <ezyang@fb.com> Pull Request resolved: #84297 Approved by: https://github.com/Chillee Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/cd96f3f6769af7b01a3b50e0d19d9fc0ea015346 Reviewed By: mehtanirav Differential Revision: D39213612 Pulled By: ezyang fbshipit-source-id: f8ee0cbf959fc0edc76225de5af89dd10c4679b6

Use register_meta for everything in meta_registrations

81be07a

Signed-off-by: Edward Z. Yang <ezyang@fb.com> [ghstack-poisoned]

facebook-github-bot added the cla signed label Aug 30, 2022

ezyang requested a review from Chillee August 30, 2022 20:14

Update on "Use register_meta for everything in meta_registrations"

0196914

Signed-off-by: Edward Z. Yang <ezyangfb.com> [ghstack-poisoned]

Chillee approved these changes Aug 30, 2022

View reviewed changes

Update on "Use register_meta for everything in meta_registrations"

2c84cdc

Signed-off-by: Edward Z. Yang <ezyangfb.com> [ghstack-poisoned]

ezyang added a commit that referenced this pull request Aug 30, 2022

Use register_meta for everything in meta_registrations

f6e0b42

Signed-off-by: Edward Z. Yang <ezyangfb.com> ghstack-source-id: eba5a20 Pull Request resolved: #84297

pytorchmergebot added the Merged label Aug 31, 2022

pytorchmergebot closed this in 8cd296f Aug 31, 2022

pytorchmergebot added the Reverted label Aug 31, 2022

pytorchmergebot added a commit that referenced this pull request Aug 31, 2022

Revert "Use register_meta for everything in meta_registrations (#84297)"

14093b5

This reverts commit 8cd296f. Reverted #84297 on behalf of https://github.com/suo due to broke test_proxy_tensor on master

ezyang reopened this Aug 31, 2022

Update on "Use register_meta for everything in meta_registrations"

baf2369

Signed-off-by: Edward Z. Yang <ezyangfb.com> [ghstack-poisoned]

Update on "Use register_meta for everything in meta_registrations"

3d80fc9

Signed-off-by: Edward Z. Yang <ezyangfb.com> [ghstack-poisoned]

ezyang added a commit that referenced this pull request Aug 31, 2022

Use register_meta for everything in meta_registrations

3a1c5ae

Signed-off-by: Edward Z. Yang <ezyangfb.com> ghstack-source-id: 0cf333a Pull Request resolved: #84297

Update on "Use register_meta for everything in meta_registrations"

6781448

Signed-off-by: Edward Z. Yang <ezyangfb.com> [ghstack-poisoned]

ezyang added a commit that referenced this pull request Aug 31, 2022

Use register_meta for everything in meta_registrations

e4c3330

Signed-off-by: Edward Z. Yang <ezyangfb.com> ghstack-source-id: 908e0e1 Pull Request resolved: #84297

pytorchmergebot closed this in cd96f3f Aug 31, 2022

facebook-github-bot deleted the gh/ezyang/1358/head branch September 4, 2022 14:19

Use register_meta for everything in meta_registrations #84297

Use register_meta for everything in meta_registrations #84297

Uh oh!

Conversation

ezyang commented Aug 30, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

facebook-github-bot commented Aug 30, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful links

✅ No Failures (0 Pending)

Uh oh!

ezyang commented Aug 30, 2022

Uh oh!

pytorchmergebot commented Aug 30, 2022

Uh oh!

pytorchmergebot commented Aug 30, 2022

Merge failed

Uh oh!

ezyang commented Aug 30, 2022

Uh oh!

pytorchmergebot commented Aug 30, 2022

Uh oh!

pytorchmergebot commented Aug 30, 2022

Merge failed

Uh oh!

ezyang commented Aug 31, 2022

Uh oh!

pytorchmergebot commented Aug 31, 2022

Uh oh!

github-actions bot commented Aug 31, 2022

Uh oh!

suo commented Aug 31, 2022

Uh oh!

pytorchmergebot commented Aug 31, 2022

Uh oh!

pytorchmergebot commented Aug 31, 2022

Uh oh!

ezyang commented Aug 31, 2022

Uh oh!

pytorchmergebot commented Aug 31, 2022

Uh oh!

pytorchmergebot commented Aug 31, 2022

Merge failed

Uh oh!

ezyang commented Aug 31, 2022

Uh oh!

pytorchmergebot commented Aug 31, 2022

Uh oh!

pytorchmergebot commented Aug 31, 2022

Merge failed

Uh oh!

ezyang commented Aug 31, 2022

Uh oh!

pytorchmergebot commented Aug 31, 2022

Uh oh!

github-actions bot commented Aug 31, 2022

Uh oh!

Uh oh!

ezyang commented Aug 30, 2022 •

edited

Loading

facebook-github-bot commented Aug 30, 2022 •

edited

Loading