Skip to content

[fx] Add metadata to fx.GraphModule #84378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[fx] Add metadata to fx.GraphModule #84378

wants to merge 2 commits into from

Conversation

angelayi
Copy link
Contributor

@angelayi angelayi commented Aug 31, 2022 •
edited
Loading

Stack from ghstack (oldest at bottom):

@pytorch-bot pytorch-bot bot added the release notes: fx release notes category label Aug 31, 2022
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 31, 2022 •
edited
Loading

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit 046d801 (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@angelayi angelayi requested a review from SherlockNoMad August 31, 2022 23:02
angelayi added a commit that referenced this pull request Aug 31, 2022
@angelayi
[fx] Add metadata to fx.GraphModule
b00be82 
ghstack-source-id: 137d79d
Pull Request resolved: #84378
@angelayi
Copy link
Contributor Author

angelayi commented Sep 1, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here.
The merge job was triggered without a flag. This means that your change will be merged once all checks on your PR have passed (ETA: 0-4 Hours). If this is not the intended behavior, feel free to use some of the other merge options in the wiki.
Please reach out to the PyTorch DevX Team with feedback or questions!

@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2022

Hey @angelayi.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@facebook-github-bot facebook-github-bot deleted the gh/angelayi/43/head branch September 5, 2022 14:19
facebook-github-bot pushed a commit that referenced this pull request Sep 6, 2022
@angelayi @facebook-github-bot
[fx] Add metadata to fx.GraphModule (#84378) (#84378)
3a21ad9 
Summary:
Pull Request resolved: #84378
Approved by: https://github.com/SherlockNoMad

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/dd82b31e552d4da255bb36266681a0400367314a

Reviewed By: mehtanirav

Differential Revision: D39277162

Pulled By: angelayi

fbshipit-source-id: 7962e94b31d49f8c5b730c4987610869abd5b5cd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SherlockNoMad SherlockNoMad SherlockNoMad approved these changes

Assignees
No one assigned
Labels
cla signed fx Merged release notes: fx release notes category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@angelayi @facebook-github-bot @pytorchmergebot @SherlockNoMad