Skip to content

Conversation

H-Huang
Copy link
Member

@H-Huang H-Huang commented Sep 7, 2022

Stack from ghstack:

host and port are already exposed in the TCPStore pybind definition, this is a small change adding it in the pyi stub

Differential Revision: D39311153

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Sep 7, 2022

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit 3c7897e (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

H-Huang added a commit that referenced this pull request Sep 7, 2022
ghstack-source-id: 6b553eb
Pull Request resolved: #84636
@H-Huang H-Huang added the oncall: distributed Add this issue/PR to distributed oncall triage queue label Sep 7, 2022
@H-Huang
Copy link
Member Author

H-Huang commented Sep 7, 2022

@H-Huang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Copy link
Contributor

@wz337 wz337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@H-Huang
Copy link
Member Author

H-Huang commented Sep 7, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here and land check progress here.
The merge job was triggered with the land checks (-l) flag. If you did not specify this flag yourself, you are likely enrolled in the land checks rollout. This means that your change will be merged once all checks on your PR and the land checks have passed (ETA 4 Hours). If you need to coordinate lands between different changes and cannot risk a land race, please add the ciflow/trunk label to your PR and wait for signal to complete, and then land your changes in proper order. Having trunk, pull, and Lint pre-run on a PR will bypass land checks and the ETA should be immediate. If this is not the intended behavior, feel free to use some of the other merge options in the wiki.
Please reach out to the PyTorch DevX Team with feedback or questions!

pytorchmergebot pushed a commit that referenced this pull request Sep 7, 2022
`host` and `port` are already exposed in the `TCPStore` pybind definition, this is a small change adding it in the pyi stub

Differential Revision: [D39311153](https://our.internmc.facebook.com/intern/diff/D39311153)
Pull Request resolved: #84636
Approved by: https://github.com/wz337
@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2022

Hey @H-Huang.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request Sep 9, 2022
Summary:
`host` and `port` are already exposed in the `TCPStore` pybind definition, this is a small change adding it in the pyi stub

Pull Request resolved: #84636
Approved by: https://github.com/wz337

Test Plan:
contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/e14f46f9ddf143dbe894ee40e3a698fb401523ae

Original Phabricator Test Plan:
Imported from OSS

Reviewed By: izaitsevfb

Differential Revision: D39311153

Pulled By: H-Huang

fbshipit-source-id: af72d43e6017e3c2e31c1660fa1fabc7566a431e
@facebook-github-bot facebook-github-bot deleted the gh/H-Huang/81/head branch September 11, 2022 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed Merged oncall: distributed Add this issue/PR to distributed oncall triage queue release notes: distributed (c10d) release notes category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants