-
Notifications
You must be signed in to change notification settings - Fork 25.2k
Add host and port to TCPStore pyi definition #84636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[ghstack-poisoned]
🔗 Helpful links
✅ No Failures (0 Pending)As of commit 3c7897e (more details on the Dr. CI page): Expand to see more💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
@H-Huang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@pytorchbot merge |
@pytorchbot successfully started a merge job. Check the current status here and land check progress here. |
`host` and `port` are already exposed in the `TCPStore` pybind definition, this is a small change adding it in the pyi stub Differential Revision: [D39311153](https://our.internmc.facebook.com/intern/diff/D39311153) Pull Request resolved: #84636 Approved by: https://github.com/wz337
Hey @H-Huang. |
Summary: `host` and `port` are already exposed in the `TCPStore` pybind definition, this is a small change adding it in the pyi stub Pull Request resolved: #84636 Approved by: https://github.com/wz337 Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/e14f46f9ddf143dbe894ee40e3a698fb401523ae Original Phabricator Test Plan: Imported from OSS Reviewed By: izaitsevfb Differential Revision: D39311153 Pulled By: H-Huang fbshipit-source-id: af72d43e6017e3c2e31c1660fa1fabc7566a431e
Stack from ghstack:
host
andport
are already exposed in theTCPStore
pybind definition, this is a small change adding it in the pyi stubDifferential Revision: D39311153