[Mobile] Fix The Build For Model Tracer #84755

dhruvbird · 2022-09-09T15:51:12Z

Stack from ghstack (oldest at bottom):

-> [Mobile] Fix The Build For Model Tracer #84755

Summary: Currently, the model tracer build is broken because of 2 reasons:

A few source files are missing, resulting in missing link time symbols
The TRACING_BASED flag isn't passed correctly from the command line (specified as an evnironment variable) as a CMake flag

Both these issues were fixed.

Test Plan: Ran this command: USE_CUDA=0 TRACING_BASED=1 python setup.py develop --cmake

and saw that the tracer binary was built at build/bin/model_tracer - also ran it to ensure that it can generate a YAML file.

Differential Revision: D39391270

Summary: Currently, the model tracer build is broken because of 2 reasons: 1. A few source files are missing, resulting in missing link time symbols 2. The `TRACING_BASED` flag isn't passed correctly from the command line (specified as an evnironment variable) as a CMake flag Both these issues were fixed. Test Plan: Ran this command: `USE_CUDA=0 TRACING_BASED=1 python setup.py develop --cmake` and saw that the tracer binary was built at `build/bin/model_tracer` - also ran it to ensure that it can generate a YAML file. [ghstack-poisoned]

pytorch-bot · 2022-09-09T15:51:14Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/84755

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 8b3a01c:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Summary: Currently, the model tracer build is broken because of 2 reasons: 1. A few source files are missing, resulting in missing link time symbols 2. The `TRACING_BASED` flag isn't passed correctly from the command line (specified as an evnironment variable) as a CMake flag Both these issues were fixed. Test Plan: Ran this command: `USE_CUDA=0 TRACING_BASED=1 python setup.py develop --cmake` and saw that the tracer binary was built at `build/bin/model_tracer` - also ran it to ensure that it can generate a YAML file. ghstack-source-id: c7481f8 Pull Request resolved: #84755

cccclai · 2022-09-09T16:27:53Z

caffe2/CMakeLists.txt

+message(STATUS "Tracing Based Flag: ${TRACING_BASED}")
+message(STATUS "Build Lite Interpreter Flag: ${BUILD_LITE_INTERPRETER}")
+message(STATUS "Intern Build Mobile Flag: ${INTERN_BUILD_MOBILE}")


Delete debugging code

I saw a bunch of places in existing that print the relevant flags where they are used as STATUS, so I wanted to keep there here - do you think that's okay?

cccclai · 2022-09-09T16:28:04Z

tools/setup_helpers/cmake.py

@@ -230,6 +230,7 @@ def generate(
                    "OPENSSL_ROOT_DIR",
                    "STATIC_DISPATCH_BACKEND",
                    "SELECTED_OP_LIST",
+                    "TRACING_BASED",


Nice finding!

dhruvbird · 2022-09-09T17:29:49Z

@dhruvbird has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

dhruvbird · 2022-09-09T18:00:54Z

@pytorchbot merge

pytorchmergebot · 2022-09-09T18:02:15Z

@pytorchbot successfully started a merge job. Check the current status here.
The merge job was triggered without a flag. This means that your change will be merged once all checks on your PR have passed (ETA: 0-4 Hours). If this is not the intended behavior, feel free to use some of the other merge options in the wiki.
Please reach out to the PyTorch DevX Team with feedback or questions!

github-actions · 2022-09-09T18:23:07Z

Hey @dhruvbird.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@cccclai

…ake/Summary.cmake Summary: In [PR 84755](#84755), @cccclai noticed and mentioned the presence of `message(STATUS...)` logging in caffe2/CMakeLists.txt and suggested moving it to the file cmake/Summary.cmake. This PR addresses that comment/suggestion. Test Plan: Ran the build as `USE_NUMPY=0 USE_DISTRIBUTED=0 USE_CUDA=0 TRACING_BASED=1 python setup.py develop` and saw the follwing being printed: ``` -- BUILD_MOBILE_AUTOGRAD : OFF -- BUILD_LITE_INTERPRETER: OFF -- INTERN_BUILD_MOBILE : -- TRACING_BASED : 1 ``` [ghstack-poisoned]

…ists.txt with message in cmake/Summary.cmake" Summary: In [PR 84755](#84755), cccclai noticed and mentioned the presence of `message(STATUS...)` logging in caffe2/CMakeLists.txt and suggested moving it to the file cmake/Summary.cmake. This PR addresses that comment/suggestion. Test Plan: Ran the build as `USE_NUMPY=0 USE_DISTRIBUTED=0 USE_CUDA=0 TRACING_BASED=1 python setup.py develop` and saw the follwing being printed: ``` -- BUILD_MOBILE_AUTOGRAD : OFF -- BUILD_LITE_INTERPRETER: OFF -- INTERN_BUILD_MOBILE : -- TRACING_BASED : 1 ``` [ghstack-poisoned]

…ake/Summary.cmake Summary: In [PR 84755](#84755), cccclai noticed and mentioned the presence of `message(STATUS...)` logging in caffe2/CMakeLists.txt and suggested moving it to the file cmake/Summary.cmake. This PR addresses that comment/suggestion. Test Plan: Ran the build as `USE_NUMPY=0 USE_DISTRIBUTED=0 USE_CUDA=0 TRACING_BASED=1 python setup.py develop` and saw the follwing being printed: ``` -- BUILD_MOBILE_AUTOGRAD : OFF -- BUILD_LITE_INTERPRETER: OFF -- INTERN_BUILD_MOBILE : -- TRACING_BASED : 1 ``` ghstack-source-id: 006743b Pull Request resolved: #84814

…ssage in cmake/Summary.cmake" Summary: In [PR 84755](#84755), cccclai noticed and mentioned the presence of `message(STATUS...)` logging in caffe2/CMakeLists.txt and suggested moving it to the file cmake/Summary.cmake. This PR addresses that comment/suggestion. Test Plan: Ran the build as `USE_NUMPY=0 USE_DISTRIBUTED=0 USE_CUDA=0 TRACING_BASED=1 python setup.py develop` and saw the follwing being printed: ``` -- BUILD_MOBILE_AUTOGRAD : OFF -- BUILD_LITE_INTERPRETER: OFF -- INTERN_BUILD_MOBILE : -- TRACING_BASED : 1 ``` [ghstack-poisoned]

…ists.txt with message in cmake/Summary.cmake" Summary: In [PR 84755](#84755), cccclai noticed and mentioned the presence of `message(STATUS...)` logging in caffe2/CMakeLists.txt and suggested moving it to the file cmake/Summary.cmake. This PR addresses that comment/suggestion. Test Plan: Ran the build as `USE_NUMPY=0 USE_DISTRIBUTED=0 USE_CUDA=0 TRACING_BASED=1 python setup.py develop` and saw the follwing being printed: ``` -- BUILD_MOBILE_AUTOGRAD : OFF -- BUILD_LITE_INTERPRETER: OFF -- INTERN_BUILD_MOBILE : -- TRACING_BASED : 1 ``` [ghstack-poisoned]

…ssage in cmake/Summary.cmake" Summary: In [PR 84755](#84755), cccclai noticed and mentioned the presence of `message(STATUS...)` logging in caffe2/CMakeLists.txt and suggested moving it to the file cmake/Summary.cmake. This PR addresses that comment/suggestion. Test Plan: Ran the build as `USE_NUMPY=0 USE_DISTRIBUTED=0 USE_CUDA=0 TRACING_BASED=1 python setup.py develop` and saw the follwing being printed: ``` -- BUILD_MOBILE_AUTOGRAD : OFF -- BUILD_LITE_INTERPRETER: OFF -- INTERN_BUILD_MOBILE : -- TRACING_BASED : 1 ``` [ghstack-poisoned]

Summary: Currently, the model tracer build is broken because of 2 reasons: 1. A few source files are missing, resulting in missing link time symbols 2. The `TRACING_BASED` flag isn't passed correctly from the command line (specified as an evnironment variable) as a CMake flag Both these issues were fixed. Pull Request resolved: #84755 Approved by: https://github.com/cccclai Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/18a31cc0448f226f4c2dd9926d24aaef86409f1c Test plan from GitHub: Ran this command: `USE_CUDA=0 TRACING_BASED=1 python setup.py develop --cmake` and saw that the tracer binary was built at `build/bin/model_tracer` - also ran it to ensure that it can generate a YAML file. Original Phabricator Test Plan: Ran this command: `USE_CUDA=0 TRACING_BASED=1 python setup.py develop --cmake` and saw that the tracer binary was built at `build/bin/model_tracer` - also ran it to ensure that it can generate a YAML file. Reviewed By: izaitsevfb, cccclai Differential Revision: D39391270 Pulled By: dhruvbird fbshipit-source-id: ff33f78b314a6fce96f4b9a99248815c251e0453

@cccclai

…ake/Summary.cmake (#84814) Summary: In [PR 84755](#84755), @cccclai noticed and mentioned the presence of `message(STATUS...)` logging in caffe2/CMakeLists.txt and suggested moving it to the file cmake/Summary.cmake. This PR addresses that comment/suggestion. Test Plan: Ran the build as `USE_NUMPY=0 USE_DISTRIBUTED=0 USE_CUDA=0 TRACING_BASED=1 python setup.py develop` and saw the follwing being printed: ``` -- BUILD_MOBILE_AUTOGRAD : OFF -- BUILD_LITE_INTERPRETER: OFF -- INTERN_BUILD_MOBILE : -- TRACING_BASED : 1 ``` Pull Request resolved: #84814 Approved by: https://github.com/cccclai

…ake/Summary.cmake Summary: In [PR 84755](pytorch/pytorch#84755), cccclai noticed and mentioned the presence of `message(STATUS...)` logging in caffe2/CMakeLists.txt and suggested moving it to the file cmake/Summary.cmake. This PR addresses that comment/suggestion. Test Plan: Ran the build as `USE_NUMPY=0 USE_DISTRIBUTED=0 USE_CUDA=0 TRACING_BASED=1 python setup.py develop` and saw the follwing being printed: ``` -- BUILD_MOBILE_AUTOGRAD : OFF -- BUILD_LITE_INTERPRETER: OFF -- INTERN_BUILD_MOBILE : -- TRACING_BASED : 1 ``` ghstack-source-id: 2d49f53 Pull Request resolved: pytorch/pytorch#84814

Pull Request resolved: pytorch/pytorch#84755 Currently, the model tracer build is broken because of 2 reasons: 1. A few source files are missing, resulting in missing link time symbols 2. The `TRACING_BASED` flag isn't passed correctly from the command line (specified as an evnironment variable) as a CMake flag Both these issues were fixed. Differential Revision: [D39391270](https://our.internmc.facebook.com/intern/diff/D39391270/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D39391270/)! ghstack-source-id: 166946891

facebook-github-bot added the cla signed label Sep 9, 2022

dhruvbird requested review from cccclai and JacobSzwejbka September 9, 2022 15:51

cccclai reviewed Sep 9, 2022

View reviewed changes

cccclai approved these changes Sep 9, 2022

View reviewed changes

pytorchmergebot added the Merged label Sep 9, 2022

pytorchmergebot closed this in 18a31cc Sep 9, 2022

dhruvbird added release notes: mobile release notes category topic: bug fixes topic category topic: build labels Sep 9, 2022

This was referenced Sep 9, 2022

[Mobile Tracer] Use unified source file list for BUCK build #84770

Closed

[Build] Replace message() in caffe2/CMakeLists.txt with message in cmake/Summary.cmake #84814

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Mobile] Fix The Build For Model Tracer #84755

[Mobile] Fix The Build For Model Tracer #84755

Uh oh!

dhruvbird commented Sep 9, 2022 •

edited

Loading

Uh oh!

pytorch-bot bot commented Sep 9, 2022 •

edited

Loading

Uh oh!

cccclai Sep 9, 2022

Uh oh!

dhruvbird Sep 9, 2022

Uh oh!

cccclai Sep 9, 2022

Uh oh!

dhruvbird commented Sep 9, 2022

Uh oh!

dhruvbird commented Sep 9, 2022

Uh oh!

pytorchmergebot commented Sep 9, 2022

Uh oh!

github-actions bot commented Sep 9, 2022

Uh oh!

Uh oh!

[Mobile] Fix The Build For Model Tracer #84755

[Mobile] Fix The Build For Model Tracer #84755

Uh oh!

Conversation

dhruvbird commented Sep 9, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Sep 9, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/84755

✅ No Failures

Uh oh!

cccclai Sep 9, 2022

Choose a reason for hiding this comment

Uh oh!

dhruvbird Sep 9, 2022

Choose a reason for hiding this comment

Uh oh!

cccclai Sep 9, 2022

Choose a reason for hiding this comment

Uh oh!

dhruvbird commented Sep 9, 2022

Uh oh!

dhruvbird commented Sep 9, 2022

Uh oh!

pytorchmergebot commented Sep 9, 2022

Uh oh!

github-actions bot commented Sep 9, 2022

Uh oh!

Uh oh!

dhruvbird commented Sep 9, 2022 •

edited

Loading

pytorch-bot bot commented Sep 9, 2022 •

edited

Loading