Delete SymIntArrayRef wrapper struct #84837

ezyang · 2022-09-11T14:03:54Z

Stack from ghstack (oldest at bottom):

-> Delete SymIntArrayRef wrapper struct #84837

Since we separated at::foo and at::foo_symint there is no benefit
to trying to make initializer lists work in both cases. So we can
get rid of the special different struct.

Signed-off-by: Edward Z. Yang ezyang@fb.com

Since we separated at::foo and at::foo_symint there is no benefit to trying to make initializer lists work in both cases. So we can get rid of the special different struct. Signed-off-by: Edward Z. Yang <ezyang@fb.com> [ghstack-poisoned]

pytorch-bot · 2022-09-11T14:03:56Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/84837

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit our office hours

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Failures

As of commit fd5a882:

The following jobs have failed:

linux-bionic-cuda11.6-py3.10-gcc7 / test (distributed, 1, 3, linux.8xlarge.nvidia.gpu)

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Since we separated at::foo and at::foo_symint there is no benefit to trying to make initializer lists work in both cases. So we can get rid of the special different struct. Signed-off-by: Edward Z. Yang <ezyangfb.com> [ghstack-poisoned]

Signed-off-by: Edward Z. Yang <ezyang@fb.com>

Since we separated at::foo and at::foo_symint there is no benefit to trying to make initializer lists work in both cases. So we can get rid of the special different struct. Signed-off-by: Edward Z. Yang <ezyangfb.com> [ghstack-poisoned]

Since we separated at::foo and at::foo_symint there is no benefit to trying to make initializer lists work in both cases. So we can get rid of the special different struct. Signed-off-by: Edward Z. Yang <ezyangfb.com> ghstack-source-id: dfde3a0 Pull Request resolved: #84837

ezyang · 2022-09-12T15:32:35Z

@pytorchbot merge

pytorchmergebot · 2022-09-12T15:35:25Z

@pytorchbot successfully started a merge job. Check the current status here.
The merge job was triggered without a flag. This means that your change will be merged once all checks on your PR have passed (ETA: 0-4 Hours). If this is not the intended behavior, feel free to use some of the other merge options in the wiki.
Please reach out to the PyTorch DevX Team with feedback or questions!

pytorchmergebot · 2022-09-12T15:35:27Z

Merge failed

Reason: Command git -C /home/runner/work/pytorch/pytorch cherry-pick -x 57f1706695bb360f9811149df3b95ddb9a11bd8d returned non-zero exit code 1

Auto-merging .github/ci_commit_pins/xla.txt
CONFLICT (content): Merge conflict in .github/ci_commit_pins/xla.txt
error: could not apply 57f1706695... Delete SymIntArrayRef wrapper struct
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

Details for Dev Infra team

Raised by workflow job

Since we separated at::foo and at::foo_symint there is no benefit to trying to make initializer lists work in both cases. So we can get rid of the special different struct. Signed-off-by: Edward Z. Yang <ezyangfb.com> [ghstack-poisoned]

Since we separated at::foo and at::foo_symint there is no benefit to trying to make initializer lists work in both cases. So we can get rid of the special different struct. Signed-off-by: Edward Z. Yang <ezyangfb.com> ghstack-source-id: f2abd0e Pull Request resolved: #84837

ezyang · 2022-09-12T16:25:32Z

@pytorchbot merge -f "fake merge conflict from xla pin"

pytorchmergebot · 2022-09-12T16:28:16Z

@pytorchbot successfully started a merge job. Check the current status here.
The merge job was triggered with the force (-f) flag. This means your change will be merged immediately, bypassing any CI checks (ETA: 1-5 minutes). If this is not the intended behavior, feel free to use some of the other merge options in the wiki.
Please reach out to the PyTorch DevX Team with feedback or questions!

github-actions · 2022-09-12T16:29:36Z

Hey @ezyang.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

* Companion PR for pytorch/pytorch#84837 Signed-off-by: Edward Z. Yang <ezyang@fb.com> * pin Signed-off-by: Edward Z. Yang <ezyang@fb.com> * lint Signed-off-by: Edward Z. Yang <ezyang@fb.com> * Delete .torch_pin Signed-off-by: Edward Z. Yang <ezyang@fb.com>

ZainRizvi · 2022-09-12T19:02:43Z

@pytorchmergebot revert -c ignoredsignal -m "The test test_post_localSGD_optimizer_step_reload in the X linux-bionic-cuda11.6-py3.10-gcc7 workflow has started consistently failing since this PR was submitted"

pytorchmergebot · 2022-09-12T19:04:04Z

@pytorchbot successfully started a revert job. Check the current status here.
Please reach out to the PyTorch DevX Team with feedback or questions!

pytorchmergebot · 2022-09-12T19:04:11Z

@ezyang your PR has been successfully reverted.

This reverts commit 9c78f59. Reverted #84837 on behalf of https://github.com/ZainRizvi due to The test test_post_localSGD_optimizer_step_reload in the X linux-bionic-cuda11.6-py3.10-gcc7 workflow has started consistently failing since this PR was submitted

ZainRizvi · 2022-09-12T19:34:40Z

@ezyang a heads up that I had to revert this PR

ZainRizvi · 2022-09-12T19:44:24Z

My bad,. turns out this test was flaky even before the PR was submitted. Digging deeper

ZainRizvi · 2022-09-12T19:58:46Z

@pytorchmergebot merge -f "This shouldn't have been reverted"

pytorchmergebot · 2022-09-12T20:00:18Z

Can't merge closed PR #84837

ZainRizvi · 2022-09-12T20:00:39Z

@pytorchmergebot merge -f "This shouldn't have been reverted"

pytorchmergebot · 2022-09-12T20:03:57Z

@pytorchbot successfully started a merge job. Check the current status here.
The merge job was triggered with the force (-f) flag. This means your change will be merged immediately, bypassing any CI checks (ETA: 1-5 minutes). If this is not the intended behavior, feel free to use some of the other merge options in the wiki.
Please reach out to the PyTorch DevX Team with feedback or questions!

github-actions · 2022-09-12T20:04:58Z

Hey @ezyang.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

Since we separated at::foo and at::foo_symint there is no benefit to trying to make initializer lists work in both cases. So we can get rid of the special different struct. Signed-off-by: Edward Z. Yang <ezyang@fb.com> Pull Request resolved: #84837 Approved by: https://github.com/kit1980

Delete SymIntArrayRef wrapper struct

cc61f63

Since we separated at::foo and at::foo_symint there is no benefit to trying to make initializer lists work in both cases. So we can get rid of the special different struct. Signed-off-by: Edward Z. Yang <ezyang@fb.com> [ghstack-poisoned]

pytorch-bot bot added the release notes: mobile release notes category label Sep 11, 2022

facebook-github-bot added the cla signed label Sep 11, 2022

ezyang requested review from Krovatkin, wconstab and Chillee September 11, 2022 14:17

Update on "Delete SymIntArrayRef wrapper struct"

ea29509

Since we separated at::foo and at::foo_symint there is no benefit to trying to make initializer lists work in both cases. So we can get rid of the special different struct. Signed-off-by: Edward Z. Yang <ezyangfb.com> [ghstack-poisoned]

Update on "Delete SymIntArrayRef wrapper struct"

70157a4

Since we separated at::foo and at::foo_symint there is no benefit to trying to make initializer lists work in both cases. So we can get rid of the special different struct. Signed-off-by: Edward Z. Yang <ezyangfb.com> [ghstack-poisoned]

ezyang mentioned this pull request Sep 11, 2022

Companion PR for https://github.com/pytorch/pytorch/pull/84837 pytorch/xla#3987

Merged

ezyang added a commit to pytorch/xla that referenced this pull request Sep 11, 2022

Companion PR for pytorch/pytorch#84837

09be987

Signed-off-by: Edward Z. Yang <ezyang@fb.com>

Update on "Delete SymIntArrayRef wrapper struct"

095d4d5

Since we separated at::foo and at::foo_symint there is no benefit to trying to make initializer lists work in both cases. So we can get rid of the special different struct. Signed-off-by: Edward Z. Yang <ezyangfb.com> [ghstack-poisoned]

ezyang requested a review from a team as a code owner September 11, 2022 17:50

kit1980 approved these changes Sep 11, 2022

View reviewed changes

Update on "Delete SymIntArrayRef wrapper struct"

fd5a882

Since we separated at::foo and at::foo_symint there is no benefit to trying to make initializer lists work in both cases. So we can get rid of the special different struct. Signed-off-by: Edward Z. Yang <ezyangfb.com> [ghstack-poisoned]

pytorchmergebot added the Merged label Sep 12, 2022

pytorchmergebot closed this in 9c78f59 Sep 12, 2022

pytorchmergebot added the Reverted label Sep 12, 2022

ZainRizvi reopened this Sep 12, 2022

pytorchmergebot closed this in 9e5563d Sep 12, 2022

facebook-github-bot deleted the gh/ezyang/1374/head branch September 16, 2022 14:20

Delete SymIntArrayRef wrapper struct #84837

Delete SymIntArrayRef wrapper struct #84837

Uh oh!

Conversation

ezyang commented Sep 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Sep 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/84837

❌ 1 Failures

Uh oh!

ezyang commented Sep 12, 2022

Uh oh!

pytorchmergebot commented Sep 12, 2022

Uh oh!

pytorchmergebot commented Sep 12, 2022

Merge failed

Uh oh!

ezyang commented Sep 12, 2022

Uh oh!

pytorchmergebot commented Sep 12, 2022

Uh oh!

github-actions bot commented Sep 12, 2022

Uh oh!

ZainRizvi commented Sep 12, 2022

Uh oh!

pytorchmergebot commented Sep 12, 2022

Uh oh!

pytorchmergebot commented Sep 12, 2022

Uh oh!

ZainRizvi commented Sep 12, 2022

Uh oh!

ZainRizvi commented Sep 12, 2022

Uh oh!

ZainRizvi commented Sep 12, 2022

Uh oh!

pytorchmergebot commented Sep 12, 2022

Uh oh!

ZainRizvi commented Sep 12, 2022

Uh oh!

pytorchmergebot commented Sep 12, 2022

Uh oh!

github-actions bot commented Sep 12, 2022

Uh oh!

Uh oh!

ezyang commented Sep 11, 2022 •

edited

Loading

pytorch-bot bot commented Sep 11, 2022 •

edited

Loading