Skip to content

Conversation

lezcano
Copy link
Collaborator

@lezcano lezcano commented Sep 14, 2022

Stack from ghstack:

I left the case reduction="prod" for future work as it's a bit of a pain.

I left the case `reduction="prod"` for future work as it's a bit of a pain.

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 14, 2022

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/85000

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 648a4a0:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

I left the case `reduction="prod"` for future work as it's a bit of a pain.

[ghstack-poisoned]
lezcano added a commit that referenced this pull request Sep 14, 2022
I left the case `reduction="prod"` for future work as it's a bit of a pain.

ghstack-source-id: e69a46f
Pull Request resolved: #85000
Copy link
Contributor

@soulitzer soulitzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

I left the case `reduction="prod"` for future work as it's a bit of a pain.

[ghstack-poisoned]
lezcano added a commit that referenced this pull request Sep 16, 2022
I left the case `reduction="prod"` for future work as it's a bit of a pain.

ghstack-source-id: b29befc
Pull Request resolved: #85000
@soulitzer
Copy link
Contributor

@pytorchbot merge -g

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here.
The merge job was triggered with the green (-g) flag. This means that your change will be merged once all checks on your PR have passed (ETA: 0-4 Hours). If this is not the intended behavior, feel free to use some of the other merge options in the wiki.
Please reach out to the PyTorch DevX Team with feedback or questions!

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: Command git -C /home/runner/work/pytorch/pytorch cherry-pick -x 58c4f8e0c6cb679d086cf778573a2ab1d3fbeb4e returned non-zero exit code 1

Auto-merging functorch/test/test_ops.py
CONFLICT (content): Merge conflict in functorch/test/test_ops.py
error: could not apply 58c4f8e0c6... Implement forward AD for scatter_reduce
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
Details for Dev Infra team Raised by workflow job

@soulitzer
Copy link
Contributor

Hmm it looks like we may need to manually rebase @lezcano

I left the case `reduction="prod"` for future work as it's a bit of a pain.

[ghstack-poisoned]
lezcano added a commit that referenced this pull request Sep 16, 2022
I left the case `reduction="prod"` for future work as it's a bit of a pain.

ghstack-source-id: 3222606
Pull Request resolved: #85000
@lezcano
Copy link
Collaborator Author

lezcano commented Sep 16, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here.
The merge job was triggered without a flag. This means that your change will be merged once all checks on your PR have passed (ETA: 0-4 Hours). If this is not the intended behavior, feel free to use some of the other merge options in the wiki.
Please reach out to the PyTorch DevX Team with feedback or questions!

@github-actions
Copy link
Contributor

Hey @lezcano.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@soulitzer soulitzer added release notes: autograd release notes category topic: improvements topic category labels Sep 16, 2022
@facebook-github-bot facebook-github-bot deleted the gh/Lezcano/121/head branch September 20, 2022 14:20
mehtanirav pushed a commit that referenced this pull request Oct 4, 2022
I left the case `reduction="prod"` for future work as it's a bit of a pain.
Pull Request resolved: #85000
Approved by: https://github.com/soulitzer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants