Skip to content

[torch.futures] Fix nullptr deref #85304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

[torch.futures] Fix nullptr deref #85304

wants to merge 3 commits into from

Conversation

malfet
Copy link
Contributor

@malfet malfet commented Sep 19, 2022 •
edited
Loading

torch.jit.wait(None) and torch.futures.collect_all((None,)) should not crash.

Fixes #85237

@malfet
[torch.futures] Fix nullptr deref
e00b59e 
`torch.jit.wait(None)` and `torch.futures.collect_all((None,))` should not crash.

Fixes #85237
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 19, 2022 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/85304

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures, 3 Pending

As of commit 03d1e35:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: jit release notes category label Sep 19, 2022
@facebook-github-bot facebook-github-bot added cla signed oncall: jit Add this issue/PR to JIT oncall triage queue labels Sep 19, 2022
@malfet malfet requested review from albanD and a team September 19, 2022 21:22
kit1980
kit1980 reviewed Sep 19, 2022
View reviewed changes
@malfet
Copy link
Contributor Author

malfet commented Sep 20, 2022

@pytorchbot merge -g

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here.
The merge job was triggered with the green (-g) flag. This means that your change will be merged once all checks on your PR have passed (ETA: 0-4 Hours). If this is not the intended behavior, feel free to use some of the other merge options in the wiki.
Please reach out to the PyTorch DevX Team with feedback or questions!

@github-actions
Copy link
Contributor

Hey @malfet.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

mehtanirav pushed a commit that referenced this pull request Oct 4, 2022
@malfet @mehtanirav
[torch.futures] Fix nullptr deref (#85304)
2b7ace2 
`torch.jit.wait(None)` and `torch.futures.collect_all((None,))` should not crash.

Fixes #85237

Pull Request resolved: #85304
Approved by: https://github.com/kit1980
@malfet malfet deleted the malfet/future-nullptr-deref branch November 4, 2022 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albanD albanD Awaiting requested review from albanD

1 more reviewer

@kit1980 kit1980 kit1980 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla signed Merged oncall: jit Add this issue/PR to JIT oncall triage queue release notes: jit release notes category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Segmentation fault in torch.futures.wait_all
4 participants
@malfet @pytorchmergebot @kit1980 @facebook-github-bot