-
Notifications
You must be signed in to change notification settings - Fork 25.2k
Update torch.ops.aten.all ref to be symbolic-trace friendly #85352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- previous impl compared the summed bool values of the tensor to its nelem, which in a symbolic world is a symint and can't be coerced back into a bool for the purpose of shoving into a result tensor - new impl adds one extra negation op but avoids the need to compare to the symbolic nelem
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool; this is an interesting case and we should think how best to express this limitation to users
@pytorchbot merge -a |
❌ 🤖 pytorchbot command failed:
Try |
@pytorchbot merge |
@pytorchbot successfully started a merge job. Check the current status here. |
Hey @wconstab. |
- previous impl compared the summed bool values of the tensor to its nelem, which in a symbolic world is a symint and can't be coerced back into a bool for the purpose of shoving into a result tensor - new impl adds one extra negation op but avoids the need to compare to the symbolic nelem Pull Request resolved: #85352 Approved by: https://github.com/ezyang, https://github.com/mruberry
previous impl compared the summed bool values of the tensor to its nelem, which in a symbolic world is a symint and can't be coerced back into a bool for the purpose of shoving into a result tensor
new impl adds one extra negation op but avoids the need to compare to the symbolic nelem