Skip to content

Conversation

wconstab
Copy link
Contributor

  • previous impl compared the summed bool values of the tensor to its nelem, which in a symbolic world is a symint and can't be coerced back into a bool for the purpose of shoving into a result tensor

  • new impl adds one extra negation op but avoids the need to compare to the symbolic nelem

- previous impl compared the summed bool values of the tensor to
  its nelem, which in a symbolic world is a symint and can't be
  coerced back into a bool for the purpose of shoving into a result
  tensor

- new impl adds one extra negation op but avoids the need to compare
  to the symbolic nelem
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 20, 2022

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/85352

Note: Links to docs will display an error until the docs builds have been completed.

❌ 8 Failures, 1 Pending

As of commit 0b697fd:

The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@wconstab wconstab requested a review from ngimel September 20, 2022 17:39
@wconstab wconstab requested review from eellison, ngimel, ezyang and mruberry and removed request for ngimel September 20, 2022 17:39
Copy link
Collaborator

@mruberry mruberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool; this is an interesting case and we should think how best to express this limitation to users

@wconstab
Copy link
Contributor Author

@pytorchbot merge -a

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 20, 2022

❌ 🤖 pytorchbot command failed:

@pytorchbot: error: unrecognized arguments: -a

usage: @pytorchbot [-h] {merge,revert,rebase,label} ...

Try @pytorchbot --help for more info.

@wconstab
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here.
The merge job was triggered without a flag. This means that your change will be merged once all checks on your PR have passed (ETA: 0-4 Hours). If this is not the intended behavior, feel free to use some of the other merge options in the wiki.
Please reach out to the PyTorch DevX Team with feedback or questions!

@github-actions
Copy link
Contributor

Hey @wconstab.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

mehtanirav pushed a commit that referenced this pull request Oct 4, 2022
- previous impl compared the summed bool values of the tensor to its nelem, which in a symbolic world is a symint and can't be coerced back into a bool for the purpose of shoving into a result tensor

- new impl adds one extra negation op but avoids the need to compare to the symbolic nelem

Pull Request resolved: #85352
Approved by: https://github.com/ezyang, https://github.com/mruberry
@github-actions github-actions bot deleted the wconstab/all_ref branch March 22, 2024 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants