Skip to content

Conversation

zou3519
Copy link
Contributor

@zou3519 zou3519 commented Sep 21, 2022

This PR moves functorch C++ code that does not depend on python into aten/src/ATen/functorch. The C++ code that does depend on python (the python bindings as well as torchdim) will go into torch/csrc/functorch, to come later (see #85263 for initial attempt).

@zou3519 zou3519 added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 21, 2022
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 21, 2022

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/85381

Note: Links to docs will display an error until the docs builds have been completed.

❌ 5 Failures

As of commit afbe866:

The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

This PR moves functorch C++ code that does not depend on python into
aten/src/ATen/functorch. The C++ code that does depend on python (the
python bindings as well as torchdim) will go into torch/csrc/functorch,
to come later (see #85263 for
initial attempt).
@zou3519 zou3519 force-pushed the functorch_merge_cpp_actual branch from dcc1070 to afbe866 Compare September 21, 2022 15:38
@zou3519
Copy link
Contributor Author

zou3519 commented Sep 21, 2022

@pytorchbot merge -f "A previous version of this passed CI (#85282), before all the queueing and CI issues. In addition, the version of this PR before a rebase passed CI, minus the windows queueing issues and some flaky tests. Merging this now to avoid merge conflicts."

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here.
The merge job was triggered with the force (-f) flag. This means your change will be merged immediately, bypassing any CI checks (ETA: 1-5 minutes). If this is not the intended behavior, feel free to use some of the other merge options in the wiki.
Please reach out to the PyTorch DevX Team with feedback or questions!

@github-actions
Copy link
Contributor

Hey @zou3519.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@zou3519
Copy link
Contributor Author

zou3519 commented Sep 21, 2022

Note to Diff Train Operator: if this PR hasn't been reverted yet, and we have discovered issues with it while importing the diff train, and there is not an emergency: please let me try to take a look and fix it first because it is difficult to land this PR. I tested this PR internally in D39663712 and it appears to pass everything (modulo flakiness), but it's possible it will need fixing up to pass the internal build.

mehtanirav pushed a commit that referenced this pull request Oct 4, 2022
This PR moves functorch C++ code that does not depend on python into aten/src/ATen/functorch. The C++ code that does depend on python (the python bindings as well as torchdim) will go into torch/csrc/functorch, to come later (see #85263 for initial attempt).

Pull Request resolved: #85381
Approved by: https://github.com/ezyang
@github-actions github-actions bot deleted the functorch_merge_cpp_actual branch March 23, 2024 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk Trigger trunk jobs on your pull request cla signed Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants