-
Notifications
You must be signed in to change notification settings - Fork 25.5k
Move functorch C++ into aten/src/ATen/functorch #85381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/85381
Note: Links to docs will display an error until the docs builds have been completed. ❌ 5 FailuresAs of commit afbe866: The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR moves functorch C++ code that does not depend on python into aten/src/ATen/functorch. The C++ code that does depend on python (the python bindings as well as torchdim) will go into torch/csrc/functorch, to come later (see #85263 for initial attempt).
dcc1070
to
afbe866
Compare
@pytorchbot merge -f "A previous version of this passed CI (#85282), before all the queueing and CI issues. In addition, the version of this PR before a rebase passed CI, minus the windows queueing issues and some flaky tests. Merging this now to avoid merge conflicts." |
@pytorchbot successfully started a merge job. Check the current status here. |
Hey @zou3519. |
Note to Diff Train Operator: if this PR hasn't been reverted yet, and we have discovered issues with it while importing the diff train, and there is not an emergency: please let me try to take a look and fix it first because it is difficult to land this PR. I tested this PR internally in D39663712 and it appears to pass everything (modulo flakiness), but it's possible it will need fixing up to pass the internal build. |
This PR moves functorch C++ code that does not depend on python into aten/src/ATen/functorch. The C++ code that does depend on python (the python bindings as well as torchdim) will go into torch/csrc/functorch, to come later (see #85263 for initial attempt). Pull Request resolved: #85381 Approved by: https://github.com/ezyang
This PR moves functorch C++ code that does not depend on python into aten/src/ATen/functorch. The C++ code that does depend on python (the python bindings as well as torchdim) will go into torch/csrc/functorch, to come later (see #85263 for initial attempt).