Skip to content

Add FakeCrossRef tests for backwards, Fix Layer Norm Backward Decomp #85417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 8 commits into from
Closed

Add FakeCrossRef tests for backwards, Fix Layer Norm Backward Decomp #85417

wants to merge 8 commits into from

Conversation

eellison
Copy link
Contributor

@eellison eellison commented Sep 21, 2022 •
edited
Loading

@eellison eellison mentioned this pull request Sep 21, 2022
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 21, 2022 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/85417

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 471ddbc:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@eellison eellison requested a review from ezyang September 21, 2022 17:01
@eellison eellison mentioned this pull request Sep 21, 2022
Closed
@eellison eellison changed the title Add FakeCrossRef tests for backwards Add FakeCrossRef tests for backwards, Fix Layer Norm Backward Sep 21, 2022
@eellison eellison changed the title Add FakeCrossRef tests for backwards, Fix Layer Norm Backward Add FakeCrossRef tests for backwards, Fix Layer Norm Backward Decomp Sep 21, 2022
@eellison eellison mentioned this pull request Sep 21, 2022
Closed
mruberry
mruberry reviewed Sep 21, 2022
View reviewed changes
mruberry
mruberry reviewed Sep 21, 2022
View reviewed changes
@eellison eellison mentioned this pull request Sep 21, 2022
Closed
ezyang
ezyang reviewed Sep 21, 2022
View reviewed changes
@eellison eellison mentioned this pull request Sep 21, 2022
Closed
@eellison eellison mentioned this pull request Sep 21, 2022
Closed
@eellison eellison requested review from ezyang and mruberry September 21, 2022 20:25
ezyang
ezyang reviewed Sep 21, 2022
View reviewed changes
test/test_ops.py Outdated
aten.is_same_size.default,

)
# TODO: enable check_aliasing, too many failures :/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ALL of the primtorch metas alias incorrectly, they all need to be fixed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, they're not registered to fake tensor right now..

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure? I thought we hit them for dynamic shapes preferentially

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do, you're right, but they're disabled for static fake. + 1 motivation for regularizing the path symbolic/fake (not to mention #84308). I have a pr that i had been working on to do this that i havent quite been able to push through finish line.

The aliasing tests are on for the non backward. I'll work on getting them on for backward as a follow up.

ezyang
ezyang reviewed Sep 21, 2022
View reviewed changes
ezyang
ezyang reviewed Sep 21, 2022
View reviewed changes
ezyang
ezyang reviewed Sep 21, 2022
View reviewed changes
ezyang
ezyang reviewed Sep 21, 2022
View reviewed changes
ezyang
ezyang reviewed Sep 21, 2022
View reviewed changes
ezyang
ezyang reviewed Sep 21, 2022
View reviewed changes
@eellison eellison mentioned this pull request Sep 21, 2022
Open
pytorchmergebot referenced this pull request Sep 23, 2022
@eellison @pytorchmergebot
Turn on aliasing tests for fake backwards, Fix Batch norm running mea…
1e92eb8 
…n/var decomp aliasing (#85471)

Pull Request resolved: #85471
Approved by: https://github.com/ezyang
@clee2000
Copy link
Contributor

@pytorchbot revert -m "broke tests on trunk https://hud.pytorch.org/pytorch/pytorch/commit/78afa0cf0ca04ce437ca4b519f07c04e73fe0d4c" -c nosignal

pytorchmergebot added a commit that referenced this pull request Sep 23, 2022
@pytorchmergebot
Revert "Turn on aliasing tests for fake backwards, Fix Batch norm run…
3b195fd 
…ning mean/var decomp aliasing (#85471)"

This reverts commit 1e92eb8.

Reverted #85471 on behalf of https://github.com/clee2000 due to stacked prs #85417 and #85434 broke trunk, reverting this so i can revert the others
@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a revert job. Check the current status here.
Please reach out to the PyTorch DevX Team with feedback or questions!

@pytorchmergebot
Copy link
Collaborator

Reverting PR 85417 failed

Reason: Command git -C /home/runner/work/pytorch/pytorch revert --no-edit 78afa0cf0ca04ce437ca4b519f07c04e73fe0d4c returned non-zero exit code 1

Auto-merging test/test_ops.py
CONFLICT (content): Merge conflict in test/test_ops.py
error: could not revert 78afa0cf0c... Add FakeCrossRef tests for backwards, Fix Layer Norm Backward Decomp (#85417)
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git revert --continue".
hint: You can instead skip this commit with "git revert --skip".
hint: To abort and get back to the state before "git revert",
hint: run "git revert --abort".
Details for Dev Infra team Raised by workflow job

@clee2000
Copy link
Contributor

@pytorchbot revert -m "broke tests on trunk https://hud.pytorch.org/pytorch/pytorch/commit/78afa0cf0ca04ce437ca4b519f07c04e73fe0d4c" -c nosignal

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a revert job. Check the current status here.
Please reach out to the PyTorch DevX Team with feedback or questions!

@pytorchmergebot
Copy link
Collaborator

@eellison your PR has been successfully reverted.

pytorchmergebot added a commit that referenced this pull request Sep 23, 2022
@pytorchmergebot
Revert "Add FakeCrossRef tests for backwards, Fix Layer Norm Backward…
d10de31 
… Decomp (#85417)"

This reverts commit 78afa0c.

Reverted #85417 on behalf of https://github.com/clee2000 due to broke tests on trunk https://hud.pytorch.org/pytorch/pytorch/commit/78afa0cf0ca04ce437ca4b519f07c04e73fe0d4c
@eellison
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here.
The merge job was triggered without a flag. This means that your change will be merged once all checks on your PR have passed (ETA: 0-4 Hours). If this is not the intended behavior, feel free to use some of the other merge options in the wiki.
Please reach out to the PyTorch DevX Team with feedback or questions!

@github-actions
Copy link
Contributor

Hey @eellison.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@facebook-github-bot facebook-github-bot deleted the gh/eellison/321/head branch September 30, 2022 14:19
mehtanirav pushed a commit that referenced this pull request Oct 4, 2022
@eellison @mehtanirav
Add FakeCrossRef tests for backwards, Fix Layer Norm Backward Decomp (#…
b670036 
…85417)

Pull Request resolved: #85417
Approved by: https://github.com/ezyang
mehtanirav pushed a commit that referenced this pull request Oct 4, 2022
@pytorchmergebot @mehtanirav
Revert "Add FakeCrossRef tests for backwards, Fix Layer Norm Backward…
80355bc 
… Decomp (#85417)"

This reverts commit 9c77083.

Reverted #85417 on behalf of https://github.com/clee2000 due to broke tests on trunk (and pull somehow) https://hud.pytorch.org/pytorch/pytorch/commit/9c77083965e1283763a83f72a3adf299281761e3
mehtanirav pushed a commit that referenced this pull request Oct 4, 2022
@eellison @mehtanirav
Add FakeCrossRef tests for backwards, Fix Layer Norm Backward Decomp (#…
8df44d7 
…85417)

Pull Request resolved: #85417
Approved by: https://github.com/ezyang
mehtanirav pushed a commit that referenced this pull request Oct 4, 2022
@pytorchmergebot @mehtanirav
Revert "Turn on aliasing tests for fake backwards, Fix Batch norm run…
5bb6ba0 
…ning mean/var decomp aliasing (#85471)"

This reverts commit 1e92eb8.

Reverted #85471 on behalf of https://github.com/clee2000 due to stacked prs #85417 and #85434 broke trunk, reverting this so i can revert the others
mehtanirav pushed a commit that referenced this pull request Oct 4, 2022
@pytorchmergebot @mehtanirav
Revert "Add FakeCrossRef tests for backwards, Fix Layer Norm Backward…
7b9314f 
… Decomp (#85417)"

This reverts commit 78afa0c.

Reverted #85417 on behalf of https://github.com/clee2000 due to broke tests on trunk https://hud.pytorch.org/pytorch/pytorch/commit/78afa0cf0ca04ce437ca4b519f07c04e73fe0d4c
mehtanirav pushed a commit that referenced this pull request Oct 4, 2022
@eellison @mehtanirav
Add FakeCrossRef tests for backwards, Fix Layer Norm Backward Decomp (#…
c149eee 
…85417)

Pull Request resolved: #85417
Approved by: https://github.com/ezyang
Rick0317 pushed a commit to Rick0317/pytorch that referenced this pull request Oct 19, 2022
@eellison
Add FakeCrossRef tests for backwards
17a1b07 
ghstack-source-id: 1cc1b30
Pull Request resolved: pytorch/pytorch#85417
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezyang ezyang ezyang approved these changes

@ngimel ngimel Awaiting requested review from ngimel

@mruberry mruberry Awaiting requested review from mruberry

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request cla signed Merged Reverted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@eellison @pytorchmergebot @clee2000 @ezyang @mruberry @facebook-github-bot