Skip to content

[Static Runtime] Block linalg_svdvals codegen & run codegen script #85983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[Static Runtime] Block linalg_svdvals codegen & run codegen script #85983

wants to merge 1 commit into from

Conversation

mikeiovine
Copy link

Summary:
The test is causing issues:

terminate called after throwing an instance of 'std::runtime_error'
  what():  The following operation failed in the TorchScript interpreter.
Traceback of TorchScript (most recent call last):
    graph(%A: Tensor, %driver: str?):
        %bias: None = prim::Constant()
        %ret = aten::linalg_svdvals(%A, %driver)
               ~~~~ <--- HERE
        %cloned = aten::clone(%ret, %bias)
        return (%cloned)
RuntimeError: torch.linalg.svd: keyword argument `driver=` is only supported on CUDA inputs with cuSOLVER backend.

Just block the op and re-run the codegen script to remove everything and update the generated ops.

Test Plan: Existing tests

Differential Revision: D39973860

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 30, 2022 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/85983

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 8b6ee13:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: jit release notes category label Sep 30, 2022
@facebook-github-bot facebook-github-bot added cla signed oncall: jit Add this issue/PR to JIT oncall triage queue fb-exported labels Sep 30, 2022
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D39973860

@xuzhao9 xuzhao9 self-requested a review September 30, 2022 16:54
xuzhao9
xuzhao9 approved these changes Sep 30, 2022
View reviewed changes
Copy link
Contributor

@xuzhao9 xuzhao9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 30, 2022
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D39973860

mikeiovine pushed a commit to mikeiovine/pytorch that referenced this pull request Sep 30, 2022
@facebook-github-bot
[Static Runtime] Block linalg_svdvals codegen & run codegen script (p…
15632dc 
…ytorch#85983)

Summary:
Pull Request resolved: pytorch#85983

The test is causing issues:
```
terminate called after throwing an instance of 'std::runtime_error'
  what():  The following operation failed in the TorchScript interpreter.
Traceback of TorchScript (most recent call last):
    graph(%A: Tensor, %driver: str?):
        %bias: None = prim::Constant()
        %ret = aten::linalg_svdvals(%A, %driver)
               ~~~~ <--- HERE
        %cloned = aten::clone(%ret, %bias)
        return (%cloned)
RuntimeError: torch.linalg.svd: keyword argument `driver=` is only supported on CUDA inputs with cuSOLVER backend.
```

Just block the op and re-run the codegen script to remove everything and update the generated ops.

Test Plan: Existing tests

Reviewed By: xuzhao9, tenpercent

Differential Revision: D39973860

fbshipit-source-id: 3a50b13fbe7aee598c69dc6f32359a643a2fca1d
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D39973860

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D39973860

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D39973860

mikeiovine pushed a commit to mikeiovine/pytorch that referenced this pull request Oct 3, 2022
@facebook-github-bot
[Static Runtime] Block linalg_svdvals codegen & run codegen script (p…
8521976 
…ytorch#85983)

Summary:
Pull Request resolved: pytorch#85983

The test is causing issues:
```
terminate called after throwing an instance of 'std::runtime_error'
  what():  The following operation failed in the TorchScript interpreter.
Traceback of TorchScript (most recent call last):
    graph(%A: Tensor, %driver: str?):
        %bias: None = prim::Constant()
        %ret = aten::linalg_svdvals(%A, %driver)
               ~~~~ <--- HERE
        %cloned = aten::clone(%ret, %bias)
        return (%cloned)
RuntimeError: torch.linalg.svd: keyword argument `driver=` is only supported on CUDA inputs with cuSOLVER backend.
```

Just block the op and re-run the codegen script to remove everything and update the generated ops.

Test Plan: Existing tests

Reviewed By: xuzhao9, tenpercent

Differential Revision: D39973860

fbshipit-source-id: 1c3ae0d5e73d54c5e0c90c2745041991ad112ec6
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D39973860

@facebook-github-bot
Copy link
Contributor

/easycla

As part of the transition to the PyTorch Foundation, this project now requires contributions be covered under the new CLA. See #85559 for additional details.

This comment will trigger a new check of this PR. If you are already covered, you will simply see a new "EasyCLA" check that passes. If you are not covered, a bot will leave a new comment with a link to sign.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 4, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: mikeiovine / name: Mike Iovine (0af5f794743e3bcfbae4299e015efa5831059bd1)

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D39973860

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D39973860

@facebook-github-bot
[Static Runtime] Block linalg_svdvals codegen & run codegen script (p…
8b6ee13 
…ytorch#85983)

Summary:
Pull Request resolved: pytorch#85983

The test is causing issues:
```
terminate called after throwing an instance of 'std::runtime_error'
  what():  The following operation failed in the TorchScript interpreter.
Traceback of TorchScript (most recent call last):
    graph(%A: Tensor, %driver: str?):
        %bias: None = prim::Constant()
        %ret = aten::linalg_svdvals(%A, %driver)
               ~~~~ <--- HERE
        %cloned = aten::clone(%ret, %bias)
        return (%cloned)
RuntimeError: torch.linalg.svd: keyword argument `driver=` is only supported on CUDA inputs with cuSOLVER backend.
```

Just block the op and re-run the codegen script to remove everything and update the generated ops.

Test Plan: Existing tests

Reviewed By: xuzhao9, tenpercent

Differential Revision: D39973860

fbshipit-source-id: 65e636832b75b409f97a527bc5425e7fc15ba294
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D39973860

@mikeiovine
Copy link
Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here.
The merge job was triggered without a flag. This means that your change will be merged once all checks on your PR have passed (ETA: 0-4 Hours). If this is not the intended behavior, feel free to use some of the other merge options in the wiki.
Please reach out to the PyTorch DevX Team with feedback or questions!

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2022

Hey @mikeiovine.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request Oct 6, 2022
@facebook-github-bot
[Static Runtime] Block linalg_svdvals codegen & run codegen script (#…
d180f7e 
…85983)

Summary:
Pull Request resolved: #85983

The test is causing issues:
```
terminate called after throwing an instance of 'std::runtime_error'
  what():  The following operation failed in the TorchScript interpreter.
Traceback of TorchScript (most recent call last):
    graph(%A: Tensor, %driver: str?):
        %bias: None = prim::Constant()
        %ret = aten::linalg_svdvals(%A, %driver)
               ~~~~ <--- HERE
        %cloned = aten::clone(%ret, %bias)
        return (%cloned)
RuntimeError: torch.linalg.svd: keyword argument `driver=` is only supported on CUDA inputs with cuSOLVER backend.
```

Just block the op and re-run the codegen script to remove everything and update the generated ops.

Test Plan: Existing tests

Reviewed By: xuzhao9, tenpercent

Differential Revision: D39973860

fbshipit-source-id: 4f9b518fe22fb802eb12ccf74a8c3aca64d7fb43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xuzhao9 xuzhao9 xuzhao9 approved these changes

@tenpercent tenpercent tenpercent approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request cla signed fb-exported Merged oncall: jit Add this issue/PR to JIT oncall triage queue release notes: jit release notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mikeiovine @facebook-github-bot @pytorchmergebot @xuzhao9 @tenpercent