Skip to content

Remove dead ts_native_functions.yaml entries #86045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Remove dead ts_native_functions.yaml entries #86045

wants to merge 2 commits into from

Conversation

ezyang
Copy link
Contributor

@ezyang ezyang commented Oct 1, 2022 •
edited
Loading

@ezyang
Remove dead ts_native_functions.yaml entries
87bc13a 
Signed-off-by: Edward Z. Yang <ezyang@fb.com>

[ghstack-poisoned]
@ezyang ezyang mentioned this pull request Oct 1, 2022
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 1, 2022 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/86045

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures, 1 Pending

As of commit 71b8a2f:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

This was referenced Oct 1, 2022
Closed
Closed
@ezyang ezyang added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 1, 2022
@ezyang ezyang mentioned this pull request Oct 1, 2022
Closed
Chillee
Chillee approved these changes Oct 1, 2022
View reviewed changes
Copy link
Collaborator

@Chillee Chillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are these needed for again?

@ezyang
Update on "Remove dead ts_native_functions.yaml entries"
71b8a2f 
Signed-off-by: Edward Z. Yang <ezyangfb.com>

[ghstack-poisoned]
@ezyang
Copy link
Contributor Author

ezyang commented Oct 1, 2022

@pytorchbot merge -f "just a reordering of commits, no need to get signal again"

@ezyang
Copy link
Contributor Author

ezyang commented Oct 1, 2022

@Chillee not needed for anything, but these entries do nothing because LTC doesn't actually bind them

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here.
The merge job was triggered with the force (-f) flag. This means your change will be merged immediately, bypassing any CI checks (ETA: 1-5 minutes). If this is not the intended behavior, feel free to use some of the other merge options in the wiki.
Please reach out to the PyTorch DevX Team with feedback or questions!

@github-actions
Copy link
Contributor

github-actions bot commented Oct 1, 2022

Hey @ezyang.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@ezyang ezyang mentioned this pull request Oct 1, 2022
Closed
@facebook-github-bot facebook-github-bot deleted the gh/ezyang/1429/head branch October 4, 2022 14:20
mehtanirav pushed a commit that referenced this pull request Oct 4, 2022
@ezyang @mehtanirav
Remove dead ts_native_functions.yaml entries (#86045)
e3e8dae 
Signed-off-by: Edward Z. Yang <ezyang@fb.com>
Pull Request resolved: #86045
Approved by: https://github.com/Chillee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chillee Chillee Chillee approved these changes

@albanD albanD Awaiting requested review from albanD

@anjali411 anjali411 Awaiting requested review from anjali411

@antoniojkim antoniojkim Awaiting requested review from antoniojkim

@Krovatkin Krovatkin Awaiting requested review from Krovatkin

@miladm miladm Awaiting requested review from miladm

@wconstab wconstab Awaiting requested review from wconstab

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request cla signed Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ezyang @pytorchmergebot @Chillee @facebook-github-bot