Skip to content

[Profiler] Apply TensorMetadata for Optimizer and nnModule #86047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[Profiler] Apply TensorMetadata for Optimizer and nnModule #86047

wants to merge 1 commit into from

Conversation

slgong-fb
Copy link
Contributor

Summary: - Use TensorMetadat struct in saving tensor info from Optimizer and nnModule.

Test Plan: buck run mode/opt //caffe2/test:profiler

Reviewed By: chaekit

Differential Revision: D39682205

@slgong-fb slgong-fb requested a review from robieta as a code owner October 1, 2022 05:04
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 1, 2022 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/86047

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit fdeb3df:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D39682205

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D39682205

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D39682205

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 3, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: slgong-fb / name: Seonglyong Gong (39263afb6fca6efc4995739a8d3368ffcffc210a)

@facebook-github-bot
Copy link
Contributor

/easycla

As part of the transition to the PyTorch Foundation, this project now requires contributions be covered under the new CLA. See #85559 for additional details.

This comment will trigger a new check of this PR. If you are already covered, you will simply see a new "EasyCLA" check that passes. If you are not covered, a bot will leave a new comment with a link to sign.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D39682205

@slgong-fb slgong-fb force-pushed the export-D39682205 branch 2 times, most recently from 1cd5d32 to 145bdea Compare October 4, 2022 23:23
slgong-fb added a commit to slgong-fb/pytorch that referenced this pull request Oct 4, 2022
@slgong-fb @facebook-github-bot
[Profiler] Apply TensorMetadata for Optimizer and nnModule (pytorch#8…
145bdea 
…6047)

Summary:
Pull Request resolved: pytorch#86047

- Use `TensorMetadat` struct in saving tensor info from Optimizer and nnModule.

Test Plan: buck run mode/opt //caffe2/test:profiler

Reviewed By: chaekit

Differential Revision: D39682205

fbshipit-source-id: 8bc77cd62bace149044b561ffa332c14ee54a152
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D39682205

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 5, 2022
@slgong-fb @facebook-github-bot
[Profiler] Apply TensorMetadata for Optimizer and nnModule (pytorch#8…
fdeb3df 
…6047)

Summary:
Pull Request resolved: pytorch#86047

- Use `TensorMetadat` struct in saving tensor info from Optimizer and nnModule.

Test Plan: buck run mode/opt //caffe2/test:profiler

Reviewed By: chaekit, robieta

Differential Revision: D39682205

fbshipit-source-id: cb1d2f8871808eebf5a91d9c4af057e13de1266b
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D39682205

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here.
The merge job was triggered without a flag. This means that your change will be merged once all checks on your PR have passed (ETA: 0-4 Hours). If this is not the intended behavior, feel free to use some of the other merge options in the wiki.
Please reach out to the PyTorch DevX Team with feedback or questions!

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2022

Hey @slgong-fb.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request Oct 6, 2022
@slgong-fb @facebook-github-bot
[Profiler] Apply TensorMetadata for Optimizer and nnModule (#86047)
27c8866 
Summary:
Pull Request resolved: #86047

- Use `TensorMetadat` struct in saving tensor info from Optimizer and nnModule.

Test Plan: buck run mode/opt //caffe2/test:profiler

Reviewed By: chaekit, robieta

Differential Revision: D39682205

fbshipit-source-id: 6e1b9638e332bda77d6226e8c4ee282092583caa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chaekit chaekit chaekit approved these changes

@aaronenyeshi aaronenyeshi Awaiting requested review from aaronenyeshi

+1 more reviewer

@robieta robieta robieta approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request cla signed fb-exported Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@slgong-fb @facebook-github-bot @pytorchmergebot @chaekit @robieta