Skip to content

Conversation

ezyang
Copy link
Contributor

@ezyang ezyang commented Oct 2, 2022

Stack from ghstack (oldest at bottom):

This reverts commit 195184e.

@ezyang ezyang requested a review from a team as a code owner October 2, 2022 20:08
@pytorch-bot pytorch-bot bot added the release notes: releng release notes category label Oct 2, 2022
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 2, 2022

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/86073

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 Failures

As of commit b4e2f50:

The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

ezyang added a commit that referenced this pull request Oct 2, 2022
This reverts commit 195184e.

ghstack-source-id: df9cdb4
Pull Request resolved: #86073
@ezyang ezyang requested a review from malfet October 2, 2022 20:08
@ezyang ezyang added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 2, 2022
@ezyang
Copy link
Contributor Author

ezyang commented Oct 3, 2022

@pytorchbot merge -f "ci failures are irrelevant"

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here.
The merge job was triggered with the force (-f) flag. This means your change will be merged immediately, bypassing any CI checks (ETA: 1-5 minutes). If this is not the intended behavior, feel free to use some of the other merge options in the wiki.
Please reach out to the PyTorch DevX Team with feedback or questions!

@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2022

Hey @ezyang.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@seemethere
Copy link
Member

@pytorchbot revert -c ghfirst -m "fails internal tests, see https://www.internalfb.com/intern/testinfra/diagnostics/8444249415466911.844424997970305.1664864319/"

@seemethere
Copy link
Member

Failure is fairly benign but don't know why we didn't catch this in OSS:

stderr: **redacted**/aten/src/ATen/native/metal/mpscnn/MPSImageWrapper.mm:26:10: error: ARC forbids explicit message send of 'dealloc'
  [super dealloc];
   ~~~~~ ^

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a revert job. Check the current status here.
Please reach out to the PyTorch DevX Team with feedback or questions!

@pytorchmergebot
Copy link
Collaborator

Reverting PR 86073 failed

Reason: The following mandatory check(s) are pending/not yet run (Rule superuser):

  • EasyCLA

Dig deeper by viewing the pending checks on hud

Details for Dev Infra team Raised by workflow job

@seemethere
Copy link
Member

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 4, 2022

❌ 🤖 pytorchbot command failed:

@pytorchbot: error: unrecognized arguments: -f

usage: @pytorchbot [-h] {merge,revert,rebase,label} ...

Try @pytorchbot --help for more info.

@seemethere
Copy link
Member

/easycla

@facebook-github-bot facebook-github-bot deleted the gh/ezyang/1435/head branch October 6, 2022 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk Trigger trunk jobs on your pull request cla signed Merged release notes: releng release notes category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants