Correct ownership of OptionalSymIntArrayRef in backwards #86087
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add some cheap but cheerful sanity checks to help detect similar situations in the future. Signed-off-by: Edward Z. Yang <ezyang@fb.com> [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/86087
Note: Links to docs will display an error until the docs builds have been completed. ❌ 4 FailuresAs of commit a9c1b12: The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Oct 3, 2022
github-actions
bot
requested review from
anjali411,
antoniojkim,
Chillee,
Krovatkin,
miladm and
wconstab
|
@Krovatkin this includes a crappy version of the thing you asked about in chat. Maybe you can make it more robust as follow up work. |
This was referenced Oct 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Also add some cheap but cheerful sanity checks to help detect
similar situations in the future.
Signed-off-by: Edward Z. Yang ezyang@fb.com