-
Notifications
You must be signed in to change notification settings - Fork 25k
[quant][ao_migration] nn.intrinsic.qat migration to ao #86171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
All quantization-related modules are being migrated to `torch.ao`. This migrates the `nn.intrinsic.qat`. Please, see the [tracker](#81667) for the timeline. ``` python test/test_quantization.py TestAOMigrationNNIntrinsic ``` Differential Revision: [D39419993](https://our.internmc.facebook.com/intern/diff/D39419993/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D39419993/)! [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/86171
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 FailuresAs of commit d165fb7: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
~~~~~~~~~~~~~~~~~~~~~~ | ||
.. automodule:: torch.nn.intrinsic.qat | ||
.. automodule:: torch.nn.intrinsic.qat.modules | ||
torch.ao.nn.intrinsic.qat |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel ideally maybe we should change the docs in one PR to avoid inconsistent docs, but looks like we already have a partially up to date doc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The docs will have to be readdressed a lot -- there are a lot of inconsistencies in the documentation. This change is here because it is needed to pass the tests though
All quantization-related modules are being migrated to `torch.ao`. This migrates the `nn.intrinsic.qat`. Please, see the [tracker](#81667) for the timeline. ``` python test/test_quantization.py TestAOMigrationNNIntrinsic ``` Differential Revision: [D39419993](https://our.internmc.facebook.com/intern/diff/D39419993/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D39419993/)! [ghstack-poisoned]
All quantization-related modules are being migrated to `torch.ao`. This migrates the `nn.intrinsic.qat`. Please, see the [tracker](#81667) for the timeline. ``` python test/test_quantization.py TestAOMigrationNNIntrinsic ``` Differential Revision: [D39419993](https://our.internmc.facebook.com/intern/diff/D39419993/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D39419993/)! [ghstack-poisoned]
@pytorchbot merge -f "The PR Sanity Lint error is due to large code migration. Splitting it would cause a lot of dependency issues." |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Hey @z-a-f. |
Summary: All quantization-related modules are being migrated to `torch.ao`. This migrates the `nn.intrinsic.qat`. Please, see the [tracker](#81667) for the timeline. ``` python test/test_quantization.py TestAOMigrationNNIntrinsic ``` Pull Request resolved: #86171 Approved by: https://github.com/jerryzh168 Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/efccb6401c6451389c9005a43c29fd055fb89452 Original Phabricator Test Plan: Reviewed By: seemethere, jerryzh168 Differential Revision: D39419993 fbshipit-source-id: 1c010413475d22a30bb85ae8a79a6a606da56030
Stack from ghstack (oldest at bottom):
All quantization-related modules are being migrated to
torch.ao
. This migrates thenn.intrinsic.qat
. Please, see the tracker for the timeline.Differential Revision: D39419993
NOTE FOR REVIEWERS: This PR has internal Meta-specific changes or comments, please review them on Phabricator!