Skip to content

[quant][ao_migration] nn.intrinsic.qat migration to ao #86171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

z-a-f
Copy link

@z-a-f z-a-f commented Oct 4, 2022

Stack from ghstack (oldest at bottom):

All quantization-related modules are being migrated to torch.ao. This migrates the nn.intrinsic.qat. Please, see the tracker for the timeline.

python test/test_quantization.py TestAOMigrationNNIntrinsic

Differential Revision: D39419993

NOTE FOR REVIEWERS: This PR has internal Meta-specific changes or comments, please review them on Phabricator!

All quantization-related modules are being migrated to `torch.ao`. This migrates the `nn.intrinsic.qat`. Please, see the [tracker](#81667) for the timeline.

```
python test/test_quantization.py TestAOMigrationNNIntrinsic
```

Differential Revision: [D39419993](https://our.internmc.facebook.com/intern/diff/D39419993/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D39419993/)!

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 4, 2022

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/86171

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Failures

As of commit d165fb7:

The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

~~~~~~~~~~~~~~~~~~~~~~
.. automodule:: torch.nn.intrinsic.qat
.. automodule:: torch.nn.intrinsic.qat.modules
torch.ao.nn.intrinsic.qat
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel ideally maybe we should change the docs in one PR to avoid inconsistent docs, but looks like we already have a partially up to date doc

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docs will have to be readdressed a lot -- there are a lot of inconsistencies in the documentation. This change is here because it is needed to pass the tests though

zaf added 2 commits October 5, 2022 16:53
All quantization-related modules are being migrated to `torch.ao`. This migrates the `nn.intrinsic.qat`. Please, see the [tracker](#81667) for the timeline.

```
python test/test_quantization.py TestAOMigrationNNIntrinsic
```

Differential Revision: [D39419993](https://our.internmc.facebook.com/intern/diff/D39419993/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D39419993/)!

[ghstack-poisoned]
All quantization-related modules are being migrated to `torch.ao`. This migrates the `nn.intrinsic.qat`. Please, see the [tracker](#81667) for the timeline.

```
python test/test_quantization.py TestAOMigrationNNIntrinsic
```

Differential Revision: [D39419993](https://our.internmc.facebook.com/intern/diff/D39419993/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D39419993/)!

[ghstack-poisoned]
@z-a-f z-a-f requested a review from HDCharles as a code owner October 6, 2022 20:33
@z-a-f
Copy link
Author

z-a-f commented Oct 7, 2022

@pytorchbot merge -f "The PR Sanity Lint error is due to large code migration. Splitting it would cause a lot of dependency issues."

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2022

Hey @z-a-f.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@z-a-f z-a-f added release notes: quantization release notes category and removed release notes: AO frontend labels Oct 7, 2022
facebook-github-bot pushed a commit that referenced this pull request Oct 10, 2022
Summary:
All quantization-related modules are being migrated to `torch.ao`. This migrates the `nn.intrinsic.qat`. Please, see the [tracker](#81667) for the timeline.

```
python test/test_quantization.py TestAOMigrationNNIntrinsic
```

Pull Request resolved: #86171
Approved by: https://github.com/jerryzh168

Test Plan:
contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/efccb6401c6451389c9005a43c29fd055fb89452

Original Phabricator Test Plan:

Reviewed By: seemethere, jerryzh168

Differential Revision: D39419993

fbshipit-source-id: 1c010413475d22a30bb85ae8a79a6a606da56030
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk Trigger trunk jobs on your pull request cla signed Merged release notes: quantization release notes category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants