Skip to content

Fix doc of DDP (#86244) #86256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix doc of DDP (#86244) #86256

wants to merge 1 commit into from

Conversation

yhcharles
Copy link
Contributor

[ghstack-poisoned]

Fixes #ISSUE_NUMBER

@yhcharles
Fix doc of DDP (#86244)
adb3339 
[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 5, 2022 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/86256

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures, 2 Pending

As of commit adb3339:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added cla signed oncall: distributed Add this issue/PR to distributed oncall triage queue labels Oct 5, 2022
rohan-varma
rohan-varma approved these changes Oct 5, 2022
View reviewed changes
Copy link
Contributor

@rohan-varma rohan-varma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the catch!

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 5, 2022
@yhcharles
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here.
The merge job was triggered without a flag. This means that your change will be merged once all checks on your PR have passed (ETA: 0-4 Hours). If this is not the intended behavior, feel free to use some of the other merge options in the wiki.
Please reach out to the PyTorch DevX Team with feedback or questions!

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2022

Hey @yhcharles.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@yhcharles yhcharles added release notes: distributed (ddp) release notes category topic: docs topic category labels Oct 6, 2022
@yhcharles yhcharles deleted the gh/yhcharles/1/base branch October 6, 2022 00:58
facebook-github-bot pushed a commit that referenced this pull request Oct 7, 2022
@yhcharles @facebook-github-bot
Fix doc of DDP (#86244) (#86256) (#86256)
a35d9d3 
Summary:
[ghstack-poisoned]

Fixes #ISSUE_NUMBER

Pull Request resolved: #86256
Approved by: https://github.com/rohan-varma

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/bebd1622490becd09de97003bd22761e973d3edd

Reviewed By: seemethere

Differential Revision: D40167015

Pulled By: seemethere

fbshipit-source-id: 00f0e787e8c486cbcfedd735ecde6cc94250409a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrshenli mrshenli Awaiting requested review from mrshenli

@zhaojuanmao zhaojuanmao Awaiting requested review from zhaojuanmao

@pritamdamania87 pritamdamania87 Awaiting requested review from pritamdamania87

@mingzhe09088 mingzhe09088 Awaiting requested review from mingzhe09088

@H-Huang H-Huang Awaiting requested review from H-Huang

@awgu awgu Awaiting requested review from awgu

@kwen2501 kwen2501 Awaiting requested review from kwen2501

1 more reviewer

@rohan-varma rohan-varma rohan-varma approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request cla signed Merged oncall: distributed Add this issue/PR to distributed oncall triage queue release notes: distributed (ddp) release notes category topic: docs topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yhcharles @pytorchmergebot @rohan-varma @facebook-github-bot