Skip to content

Remove custom Ceil in favor of sympy.ceiling #87294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

Remove custom Ceil in favor of sympy.ceiling #87294

wants to merge 5 commits into from

Conversation

anjali411
Copy link
Contributor

@anjali411 anjali411 commented Oct 19, 2022 •
edited by albanD
Loading

Stack from ghstack (oldest at bottom):

[Alban]: the other changes that used to be in this PR (neg and fix for true div) are moved to other places where they already exist. Namely neg is already in master and true div will be in the next PR on the stack where all other functions are fixed at the same time.

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 19, 2022 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/87294

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit d47771c:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added release notes: jit release notes category labels Oct 19, 2022
anjali411 added a commit that referenced this pull request Oct 19, 2022
@anjali411
Add unary op neg, fix bugs in truediv and remove custom Ceil in favor…
9ae1ff3 
… of sympy.ceiling

ghstack-source-id: 7deb755
Pull Request resolved: #87294
@anjali411 anjali411 removed the release notes: jit release notes category label Oct 19, 2022
@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 19, 2022
@ezyang
Copy link
Contributor

ezyang commented Oct 19, 2022

test?

ezyang pushed a commit that referenced this pull request Oct 19, 2022
@anjali411 @ezyang
Add unary op neg, fix bugs in truediv and remove custom Ceil in favor…
a960f4c 
… of sympy.ceiling

ghstack-source-id: 7deb755
Pull Request resolved: #87294
@albanD albanD mentioned this pull request Oct 24, 2022
Closed
@albanD
Update on "Add unary op neg, fix bugs in truediv and remove custom Ce…
2e1abe3 
…il in favor of sympy.ceiling"

[ghstack-poisoned]
This was referenced Oct 24, 2022
Closed
Closed
Closed
@pytorch-bot pytorch-bot bot added the release notes: jit release notes category label Oct 24, 2022
@albanD albanD changed the title Add unary op neg, fix bugs in truediv and remove custom Ceil in favor of sympy.ceiling Fix bugs in truediv and remove custom Ceil in favor of sympy.ceiling Oct 24, 2022
@albanD albanD changed the title Fix bugs in truediv and remove custom Ceil in favor of sympy.ceiling Remove custom Ceil in favor of sympy.ceiling Oct 24, 2022
albanD added a commit that referenced this pull request Oct 24, 2022
@albanD
Add unary op neg, fix bugs in truediv and remove custom Ceil in favor…
565f68a 
… of sympy.ceiling

ghstack-source-id: 83cedad
Pull Request resolved: #87294
@albanD albanD mentioned this pull request Oct 25, 2022
Closed
@albanD
Update on "Remove custom Ceil in favor of sympy.ceiling"
0d61b86 
[Alban]: the other changes that used to be in this PR (neg and fix for true div) are moved to other places where they already exist. Namely neg is already in master and true div will be in the next PR on the stack where all other functions are fixed at the same time.


[ghstack-poisoned]
@albanD
Copy link
Collaborator

albanD commented Oct 26, 2022

@pytorchbot merge -f "flaky dynamo test"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: Command git -C /home/runner/work/pytorch/pytorch cherry-pick -x 424ddbfae1c32fdd5c1983ebbf353e5d0318b946 returned non-zero exit code 1

Auto-merging test/functorch/test_aotdispatch.py
Auto-merging test/test_proxy_tensor.py
CONFLICT (content): Merge conflict in test/test_proxy_tensor.py
error: could not apply 424ddbfae1... Many symintifications
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
Details for Dev Infra team Raised by workflow job

@albanD
Update on "Remove custom Ceil in favor of sympy.ceiling"
d47771c 
[Alban]: the other changes that used to be in this PR (neg and fix for true div) are moved to other places where they already exist. Namely neg is already in master and true div will be in the next PR on the stack where all other functions are fixed at the same time.


[ghstack-poisoned]
@albanD
Copy link
Collaborator

albanD commented Oct 26, 2022

@pytorchbot merge -g

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks on your PR pass since you used the green (-g) flag (ETA: 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions
Copy link
Contributor

Hey @anjali411.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Nov 5, 2022
@albanD @kulinseth
Remove custom Ceil in favor of sympy.ceiling (pytorch#87294)
1fc9d9e 
[Alban]: the other changes that used to be in this PR (neg and fix for true div) are moved to other places where they already exist. Namely neg is already in master and true div will be in the next PR on the stack where all other functions are fixed at the same time.

Pull Request resolved: pytorch#87294
Approved by: https://github.com/ezyang
kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Dec 10, 2022
@albanD @kulinseth
Remove custom Ceil in favor of sympy.ceiling (pytorch#87294)
84b2111 
[Alban]: the other changes that used to be in this PR (neg and fix for true div) are moved to other places where they already exist. Namely neg is already in master and true div will be in the next PR on the stack where all other functions are fixed at the same time.

Pull Request resolved: pytorch#87294
Approved by: https://github.com/ezyang
@facebook-github-bot facebook-github-bot deleted the gh/anjali411/215/head branch June 8, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezyang ezyang ezyang approved these changes

@albanD albanD Awaiting requested review from albanD

@antoniojkim antoniojkim Awaiting requested review from antoniojkim

@bdhirsh bdhirsh Awaiting requested review from bdhirsh

@Chillee Chillee Awaiting requested review from Chillee

@Krovatkin Krovatkin Awaiting requested review from Krovatkin

@miladm miladm Awaiting requested review from miladm

@wconstab wconstab Awaiting requested review from wconstab

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: jit release notes category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anjali411 @ezyang @albanD @pytorchmergebot