Skip to content

[torch] Add torch cpp cpu target for torch/csrc/api/src files #87327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[torch] Add torch cpp cpu target for torch/csrc/api/src files #87327

wants to merge 1 commit into from

Conversation

larryliu0820
Copy link
Contributor

Summary: Duplicating fbcode target fbcode//caffe2:torch-cpp-cpu target in xplat. In D40460749 our user wants to use torch::kNearest enum which is defined in torch/csrc/api/src/enum.cpp. Adding this target to support it.

Test Plan: Rely on CI

Differential Revision: D40532087

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 19, 2022 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/87327

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit af55630:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D40532087

@larryliu0820 larryliu0820 requested a review from linbinyu October 19, 2022 22:44
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D40532087

@larryliu0820 larryliu0820 requested a review from ezyang October 25, 2022 20:47
@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 25, 2022
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D40532087

larryliu0820 added a commit to larryliu0820/pytorch that referenced this pull request Oct 25, 2022
@larryliu0820 @facebook-github-bot
[torch] Add torch cpp cpu target for torch/csrc/api/src files (pytorc…
21bb9a6 
…h#87327)

Summary:
Pull Request resolved: pytorch#87327

Duplicating fbcode target `fbcode//caffe2:torch-cpp-cpu` target in xplat. In D40460749 our user wants to use `torch::kNearest` enum which is defined in `torch/csrc/api/src/enum.cpp`. Adding this target to support it.

Test Plan: Rely on CI

Reviewed By: mcr229

Differential Revision: D40532087

fbshipit-source-id: 15b8526b47ea0e5dee41a592877c1cd3d6ba8d7a
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D40532087

@larryliu0820 @facebook-github-bot
[torch] Add torch cpp cpu target for torch/csrc/api/src files (pytorc…
af55630 
…h#87327)

Summary:
Pull Request resolved: pytorch#87327

Duplicating fbcode target `fbcode//caffe2:torch-cpp-cpu` target in xplat. In D40460749 our user wants to use `torch::kNearest` enum which is defined in `torch/csrc/api/src/enum.cpp`. Adding this target to support it.

Test Plan: Rely on CI

Reviewed By: mcr229

Differential Revision: D40532087

fbshipit-source-id: 9da4bf5e7535a371d913026a9b91108dfd950c79
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D40532087

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions
Copy link
Contributor

Hey @larryliu0820.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Nov 5, 2022
@larryliu0820 @kulinseth
[torch] Add torch cpp cpu target for torch/csrc/api/src files (pytorc…
3db822d 
…h#87327)

Summary: Duplicating fbcode target `fbcode//caffe2:torch-cpp-cpu` target in xplat. In D40460749 our user wants to use `torch::kNearest` enum which is defined in `torch/csrc/api/src/enum.cpp`. Adding this target to support it.

Test Plan: Rely on CI

Differential Revision: D40532087

Pull Request resolved: pytorch#87327
Approved by: https://github.com/ezyang
kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Dec 10, 2022
@larryliu0820 @kulinseth
[torch] Add torch cpp cpu target for torch/csrc/api/src files (pytorc…
85816bb 
…h#87327)

Summary: Duplicating fbcode target `fbcode//caffe2:torch-cpp-cpu` target in xplat. In D40460749 our user wants to use `torch::kNearest` enum which is defined in `torch/csrc/api/src/enum.cpp`. Adding this target to support it.

Test Plan: Rely on CI

Differential Revision: D40532087

Pull Request resolved: pytorch#87327
Approved by: https://github.com/ezyang
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezyang ezyang ezyang approved these changes

@linbinyu linbinyu Awaiting requested review from linbinyu

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@larryliu0820 @facebook-github-bot @pytorchmergebot @ezyang