Skip to content

as_strided_scatter storage offset defaults to None not 0 #87481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

as_strided_scatter storage offset defaults to None not 0 #87481

wants to merge 1 commit into from

Conversation

ezyang
Copy link
Contributor

@ezyang ezyang commented Oct 21, 2022 •
edited
Loading

Stack from ghstack (oldest at bottom):

Signed-off-by: Edward Z. Yang ezyang@fb.com

@ezyang
as_strided_scatter storage offset defaults to None not 0
bb09536 
Signed-off-by: Edward Z. Yang <ezyang@fb.com>

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 21, 2022 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/87481

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 8 Failures, 6 Pending

As of commit bb09536:

The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

ezyang added a commit that referenced this pull request Oct 21, 2022
@ezyang
as_strided_scatter storage offset defaults to None not 0
df4bc85 
Signed-off-by: Edward Z. Yang <ezyangfb.com>

ghstack-source-id: 0ac0c1c
Pull Request resolved: #87481
bdhirsh
bdhirsh approved these changes Oct 21, 2022
View reviewed changes
Copy link
Contributor

@bdhirsh bdhirsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 21, 2022
@ezyang
Copy link
Contributor Author

ezyang commented Oct 21, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@albanD
Copy link
Collaborator

albanD commented Oct 21, 2022

This is true for as_strided as well btw: #87365

@ezyang
Copy link
Contributor Author

ezyang commented Oct 21, 2022

I checked as_strided but it seems to be None

@albanD
Copy link
Collaborator

albanD commented Oct 21, 2022

Ho nice, I guess it was updated recently!

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: The following mandatory check(s) failed (Rule superuser):

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

@ezyang
Copy link
Contributor Author

ezyang commented Oct 21, 2022

@pytorchbot merge -f "ci sev problem"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions
Copy link
Contributor

Hey @ezyang.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@ezyang ezyang mentioned this pull request Oct 24, 2022
Closed
kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Nov 5, 2022
@ezyang @kulinseth
as_strided_scatter storage offset defaults to None not 0 (pytorch#87481)
2e8b141 
Signed-off-by: Edward Z. Yang <ezyang@fb.com>
Pull Request resolved: pytorch#87481
Approved by: https://github.com/bdhirsh
kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Dec 10, 2022
@ezyang @kulinseth
as_strided_scatter storage offset defaults to None not 0 (pytorch#87481)
a000125 
Signed-off-by: Edward Z. Yang <ezyang@fb.com>
Pull Request resolved: pytorch#87481
Approved by: https://github.com/bdhirsh
@facebook-github-bot facebook-github-bot deleted the gh/ezyang/1464/head branch June 8, 2023 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdhirsh bdhirsh bdhirsh approved these changes

@albanD albanD Awaiting requested review from albanD

@anjali411 anjali411 Awaiting requested review from anjali411

@antoniojkim antoniojkim Awaiting requested review from antoniojkim

@Chillee Chillee Awaiting requested review from Chillee

@Krovatkin Krovatkin Awaiting requested review from Krovatkin

@miladm miladm Awaiting requested review from miladm

@wconstab wconstab Awaiting requested review from wconstab

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ezyang @pytorchmergebot @albanD @bdhirsh