[ao] qconfig.py fix public v private #87515

HDCharles · 2022-10-21T22:06:38Z

Stack from ghstack (oldest at bottom):

Summary: made is_reuse_input_qconfig, _activation_is_memoryless,
_partial_wrapper_equals, _obs_or_fq_ctr_equals,
_add_module_to_qconfig_obs_ctr, _assert_valid_qconfig private

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: D40709280

cc @jerryzh168 @jianyuh @raghuramank100 @jamesr66a @vkuzo @jgong5 @Xia-Weiwen @leslie-fang-intel

Summary: made is_reuse_input_qconfig, _activation_is_memoryless, _partial_wrapper_equals, _obs_or_fq_ctr_equals, _add_module_to_qconfig_obs_ctr, _assert_valid_qconfig private Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]

pytorch-bot · 2022-10-21T22:06:44Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/87515

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit our office hours

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Failures, 10 Pending

As of commit e8a50e0:

The following jobs have failed:

cuda11.6-py3.10-gcc7-sm86 / test (functorch, 1, 1, linux.g5.4xlarge.nvidia.gpu)

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Summary: made is_reuse_input_qconfig, _activation_is_memoryless, _partial_wrapper_equals, _obs_or_fq_ctr_equals, _add_module_to_qconfig_obs_ctr, _assert_valid_qconfig private Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]

HDCharles · 2022-10-26T05:16:15Z

@HDCharles has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

jerryzh168 · 2022-10-26T17:32:05Z

test/allowlist_for_publicAPI.json

@@ -622,7 +622,7 @@
    "OrderedDict"
  ],
  "torch.nn.qat.dynamic.modules.linear": [
-    "activation_is_memoryless"
+    "_activation_is_memoryless"


I think we can remove these after we made them private

i remove them at the end of the stack since there's a lot that can get removed

Summary: made is_reuse_input_qconfig, _activation_is_memoryless, _partial_wrapper_equals, _obs_or_fq_ctr_equals, _add_module_to_qconfig_obs_ctr, _assert_valid_qconfig private Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D40709280](https://our.internmc.facebook.com/intern/diff/D40709280) [ghstack-poisoned]

HDCharles · 2022-10-28T20:05:30Z

@HDCharles has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Summary: made is_reuse_input_qconfig, _activation_is_memoryless, _partial_wrapper_equals, _obs_or_fq_ctr_equals, _add_module_to_qconfig_obs_ctr, _assert_valid_qconfig private Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D40709280](https://our.internmc.facebook.com/intern/diff/D40709280) [ghstack-poisoned]

Summary: made is_reuse_input_qconfig, _activation_is_memoryless, _partial_wrapper_equals, _obs_or_fq_ctr_equals, _add_module_to_qconfig_obs_ctr, _assert_valid_qconfig private Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D40709280](https://our.internmc.facebook.com/intern/diff/D40709280) cc jerryzh168 jianyuh raghuramank100 jamesr66a vkuzo jgong5 Xia-Weiwen [ghstack-poisoned]

HDCharles · 2022-11-04T03:57:11Z

@HDCharles has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Summary: made is_reuse_input_qconfig, _activation_is_memoryless, _partial_wrapper_equals, _obs_or_fq_ctr_equals, _add_module_to_qconfig_obs_ctr, _assert_valid_qconfig private Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D40709280](https://our.internmc.facebook.com/intern/diff/D40709280) cc jerryzh168 jianyuh raghuramank100 jamesr66a vkuzo jgong5 Xia-Weiwen [ghstack-poisoned]

HDCharles · 2022-11-04T16:38:26Z

@HDCharles has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Summary: made is_reuse_input_qconfig, _activation_is_memoryless, _partial_wrapper_equals, _obs_or_fq_ctr_equals, _add_module_to_qconfig_obs_ctr, _assert_valid_qconfig private Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D40709280](https://our.internmc.facebook.com/intern/diff/D40709280) cc jerryzh168 jianyuh raghuramank100 jamesr66a vkuzo jgong5 Xia-Weiwen [ghstack-poisoned]

HDCharles · 2022-11-07T21:54:09Z

@HDCharles has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Summary: made is_reuse_input_qconfig, _activation_is_memoryless, _partial_wrapper_equals, _obs_or_fq_ctr_equals, _add_module_to_qconfig_obs_ctr, _assert_valid_qconfig private Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D40709280](https://our.internmc.facebook.com/intern/diff/D40709280) [ghstack-poisoned]

HDCharles · 2022-11-08T16:06:42Z

@HDCharles has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

jcaip

lgtm

facebook-github-bot · 2022-11-09T22:28:10Z

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

facebook-github-bot · 2022-11-09T22:28:10Z

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

pytorchmergebot · 2022-11-09T22:29:58Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

Summary: made is_reuse_input_qconfig, _activation_is_memoryless, _partial_wrapper_equals, _obs_or_fq_ctr_equals, _add_module_to_qconfig_obs_ctr, _assert_valid_qconfig private Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D40709280](https://our.internmc.facebook.com/intern/diff/D40709280) Pull Request resolved: pytorch#87515 Approved by: https://github.com/jcaip

HDCharles requested review from jerryzh168, z-a-f, albanD and anjali411 as code owners October 21, 2022 22:06

pytorch-bot bot added the release notes: quantization release notes category label Oct 21, 2022

albanD removed their request for review October 23, 2022 20:02

jerryzh168 reviewed Oct 26, 2022

View reviewed changes

This was referenced Oct 27, 2022

[ao] fixing public v private for torch.ao.nn.X #87883

Closed

[ao] fixing public v private for nn util functions #87884

Closed

[ao] public v private stubs and utils #87885

Closed

This was referenced Nov 3, 2022

[ao][fx] fixing public v private prepare.py #88398

Closed

[ao][fx] fixing public v private qconfig_mapping_utils.py #88399

Closed

[ao][fx] fixing public v private utils.py #88400

Closed

github-actions bot added the oncall: quantization Quantization support in PyTorch label Nov 3, 2022

This was referenced Nov 3, 2022

[ao] removing private from allowlist #88404

Closed

[ao] fixing private in quantization-support.rst #88405

Closed

HDCharles added 2 commits November 4, 2022 21:56

jcaip self-requested a review November 8, 2022 19:12

jcaip approved these changes Nov 8, 2022

View reviewed changes

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 9, 2022

pytorchmergebot added the Merged label Nov 9, 2022

pytorchmergebot closed this in 6fe4ccc Nov 9, 2022

facebook-github-bot deleted the gh/HDCharles/121/head branch June 8, 2023 14:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ao] qconfig.py fix public v private #87515

[ao] qconfig.py fix public v private #87515

HDCharles commented Oct 21, 2022 •

edited by pytorch-bot bot

pytorch-bot bot commented Oct 21, 2022 •

edited

HDCharles commented Oct 26, 2022

jerryzh168 Oct 26, 2022

anjali411 Oct 27, 2022

HDCharles Nov 3, 2022

HDCharles commented Oct 28, 2022

HDCharles commented Nov 4, 2022

HDCharles commented Nov 4, 2022

HDCharles commented Nov 7, 2022

HDCharles commented Nov 8, 2022

jcaip left a comment

facebook-github-bot commented Nov 9, 2022

facebook-github-bot commented Nov 9, 2022

pytorchmergebot commented Nov 9, 2022

[ao] qconfig.py fix public v private #87515

[ao] qconfig.py fix public v private #87515

Conversation

HDCharles commented Oct 21, 2022 • edited by pytorch-bot bot

pytorch-bot bot commented Oct 21, 2022 • edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/87515

❌ 1 Failures, 10 Pending

HDCharles commented Oct 26, 2022

jerryzh168 Oct 26, 2022

Choose a reason for hiding this comment

anjali411 Oct 27, 2022

Choose a reason for hiding this comment

HDCharles Nov 3, 2022

Choose a reason for hiding this comment

HDCharles commented Oct 28, 2022

HDCharles commented Nov 4, 2022

HDCharles commented Nov 4, 2022

HDCharles commented Nov 7, 2022

HDCharles commented Nov 8, 2022

jcaip left a comment

Choose a reason for hiding this comment

facebook-github-bot commented Nov 9, 2022

facebook-github-bot commented Nov 9, 2022

pytorchmergebot commented Nov 9, 2022

Merge started

HDCharles commented Oct 21, 2022 •

edited by pytorch-bot bot

pytorch-bot bot commented Oct 21, 2022 •

edited