[ao] making _is_activation_post_process private #87520

HDCharles · 2022-10-21T22:07:11Z

Stack from ghstack (oldest at bottom):

Summary: same function in observer and quantize, consolidated to a
single function. Note the definitions were slightly different, I've
changed the definition to be maximally inclusive so that the name of the
function is more accurate

Test Plan: python test/test_public_bindings.py
python test/test_quantization.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: D40709276

cc @jerryzh168 @jianyuh @raghuramank100 @jamesr66a @vkuzo @jgong5 @Xia-Weiwen @leslie-fang-intel

[ao] making _is_activation_post_process private Summary: same function in observer and quantize, consolidated to a single function Test Plan: python test/test_public_bindings.py python test/test_quantization.py Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]

pytorch-bot · 2022-10-21T22:07:13Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/87520

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 9c87c82:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[ao] making _is_activation_post_process private Summary: same function in observer and quantize, consolidated to a single function Test Plan: python test/test_public_bindings.py python test/test_quantization.py Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]

HDCharles · 2022-10-26T05:16:39Z

@HDCharles has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[ao] making _is_activation_post_process private Summary: same function in observer and quantize, consolidated to a single function Test Plan: python test/test_public_bindings.py python test/test_quantization.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D40709276](https://our.internmc.facebook.com/intern/diff/D40709276) [ghstack-poisoned]

HDCharles · 2022-10-28T20:05:54Z

@HDCharles has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[ao] making _is_activation_post_process private Summary: same function in observer and quantize, consolidated to a single function Test Plan: python test/test_public_bindings.py python test/test_quantization.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D40709276](https://our.internmc.facebook.com/intern/diff/D40709276) [ghstack-poisoned]

HDCharles · 2022-11-08T16:07:02Z

@HDCharles has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

jcaip · 2022-11-09T19:51:36Z

torch/ao/quantization/quantize.py

@@ -62,11 +62,6 @@ def get_default_custom_config_dict():
    """
    return _DEFAULT_CUSTOM_CONFIG_DICT

-def is_activation_post_process(module):


I saw that the observer function and this different, just wanted to double check

yeah, it added a few definitions that weren't captured so it will be more accurate unless people were using this as a negative test.

Summary: same function in observer and quantize, consolidated to a single function Test Plan: python test/test_public_bindings.py python test/test_quantization.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D40709276](https://our.internmc.facebook.com/intern/diff/D40709276) [ghstack-poisoned]

HDCharles · 2022-11-11T03:33:40Z

@HDCharles has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Summary: same function in observer and quantize, consolidated to a single function Test Plan: python test/test_public_bindings.py python test/test_quantization.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D40709276](https://our.internmc.facebook.com/intern/diff/D40709276) [ghstack-poisoned]

HDCharles · 2022-11-11T17:26:18Z

@HDCharles has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Summary: same function in observer and quantize, consolidated to a single function. Note the definitions were slightly different, I've changed the definition to be maximally inclusive so that the name of the function is more accurate Test Plan: python test/test_public_bindings.py python test/test_quantization.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D40709276](https://our.internmc.facebook.com/intern/diff/D40709276) [ghstack-poisoned]

facebook-github-bot · 2022-11-16T21:26:33Z

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

pytorchmergebot · 2022-11-16T21:31:53Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

bigfootjon · 2022-11-21T16:08:17Z

@pytorchbot revert -m="Diff reverted internally" -c="ghfirst"

pytorchmergebot · 2022-11-21T16:09:47Z

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

pytorchmergebot · 2022-11-21T16:09:52Z

Reverting PR 87520 failed

Reason: Command git -C /home/runner/work/pytorch/pytorch revert --no-edit 45c62a337756ff9db97cd64d2d42d9e65dda0a85 returned non-zero exit code 1

Auto-merging test/quantization/fx/test_quantize_fx.py
Auto-merging torch/ao/quantization/fx/convert.py
Auto-merging torch/ao/quantization/observer.py
Auto-merging torch/ao/quantization/quantize.py
CONFLICT (content): Merge conflict in torch/ao/quantization/quantize.py
error: could not revert 45c62a3377... [ao] making _is_activation_post_process private (#87520)
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git revert --continue".
hint: You can instead skip this commit with "git revert --skip".
hint: To abort and get back to the state before "git revert",
hint: run "git revert --abort".

Details for Dev Infra team

Raised by workflow job

bigfootjon · 2022-11-21T16:46:45Z

@pytorchbot revert -m="Diff reverted internally" -c="ghfirst"

pytorchmergebot · 2022-11-21T16:48:20Z

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

pytorchmergebot · 2022-11-21T16:48:30Z

@HDCharles your PR has been successfully reverted.

This reverts commit 45c62a3. Reverted #87520 on behalf of https://github.com/bigfootjon due to Diff reverted internally

Summary: same function in observer and quantize, consolidated to a single function. Note the definitions were slightly different, I've changed the definition to be maximally inclusive so that the name of the function is more accurate Test Plan: python test/test_public_bindings.py python test/test_quantization.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D40709276](https://our.internmc.facebook.com/intern/diff/D40709276) Pull Request resolved: pytorch#87520 Approved by: https://github.com/jcaip

This reverts commit 45c62a3. Reverted pytorch#87520 on behalf of https://github.com/bigfootjon due to Diff reverted internally

HDCharles requested review from jerryzh168, z-a-f, albanD and anjali411 as code owners October 21, 2022 22:07

pytorch-bot bot added the release notes: quantization release notes category label Oct 21, 2022

albanD removed their request for review October 23, 2022 20:01

This was referenced Oct 27, 2022

[ao] fixing public v private for torch.ao.nn.X #87883

Closed

[ao] fixing public v private for nn util functions #87884

Closed

[ao] public v private stubs and utils #87885

Closed

jcaip reviewed Nov 9, 2022

View reviewed changes

HDCharles added 3 commits November 11, 2022 08:34

jcaip approved these changes Nov 11, 2022

View reviewed changes

HDCharles added 4 commits November 15, 2022 09:19

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 16, 2022

pytorchmergebot added the Merged label Nov 16, 2022

pytorchmergebot closed this in 45c62a3 Nov 16, 2022

pytorchmergebot added the Reverted label Nov 21, 2022

pytorchmergebot added a commit that referenced this pull request Nov 21, 2022

Revert "[ao] making _is_activation_post_process private (#87520)"

9d209e7

This reverts commit 45c62a3. Reverted #87520 on behalf of https://github.com/bigfootjon due to Diff reverted internally

facebook-github-bot deleted the gh/HDCharles/126/head branch June 8, 2023 14:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ao] making _is_activation_post_process private #87520

[ao] making _is_activation_post_process private #87520

HDCharles commented Oct 21, 2022 •

edited by pytorch-bot bot

pytorch-bot bot commented Oct 21, 2022 •

edited

HDCharles commented Oct 26, 2022

HDCharles commented Oct 28, 2022

HDCharles commented Nov 8, 2022

jcaip Nov 9, 2022

HDCharles Nov 15, 2022

HDCharles commented Nov 11, 2022

HDCharles commented Nov 11, 2022

facebook-github-bot commented Nov 16, 2022

pytorchmergebot commented Nov 16, 2022

bigfootjon commented Nov 21, 2022

pytorchmergebot commented Nov 21, 2022

pytorchmergebot commented Nov 21, 2022

bigfootjon commented Nov 21, 2022

pytorchmergebot commented Nov 21, 2022

pytorchmergebot commented Nov 21, 2022

[ao] making _is_activation_post_process private #87520

[ao] making _is_activation_post_process private #87520

Conversation

HDCharles commented Oct 21, 2022 • edited by pytorch-bot bot

pytorch-bot bot commented Oct 21, 2022 • edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/87520

✅ No Failures

HDCharles commented Oct 26, 2022

HDCharles commented Oct 28, 2022

HDCharles commented Nov 8, 2022

jcaip Nov 9, 2022

Choose a reason for hiding this comment

HDCharles Nov 15, 2022

Choose a reason for hiding this comment

HDCharles commented Nov 11, 2022

HDCharles commented Nov 11, 2022

facebook-github-bot commented Nov 16, 2022

pytorchmergebot commented Nov 16, 2022

Merge started

bigfootjon commented Nov 21, 2022

pytorchmergebot commented Nov 21, 2022

pytorchmergebot commented Nov 21, 2022

Reverting PR 87520 failed

bigfootjon commented Nov 21, 2022

pytorchmergebot commented Nov 21, 2022

pytorchmergebot commented Nov 21, 2022

HDCharles commented Oct 21, 2022 •

edited by pytorch-bot bot

pytorch-bot bot commented Oct 21, 2022 •

edited