Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ao] public vs private for ao.quantization._X #88392

Closed
wants to merge 21 commits into from
Closed

[ao] public vs private for ao.quantization._X #88392

wants to merge 21 commits into from

Conversation

HDCharles
Copy link
Contributor

@HDCharles HDCharles commented Nov 3, 2022 •
edited

Stack from ghstack (oldest at bottom):

Summary: added all for these modules without altering names since they
tend to be experimental

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: D41015543

cc @jerryzh168 @jianyuh @raghuramank100 @jamesr66a @vkuzo @jgong5 @Xia-Weiwen @leslie-fang-intel

@HDCharles
[ao] public vs private for ao.quantization._X
1afa628 
Summary: added all for these modules without altering names since they
tend to be experimental

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 3, 2022 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/88392

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit b6896d3:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@github-actions github-actions bot added the oncall: quantization Quantization support in PyTorch label Nov 3, 2022
This was referenced Nov 3, 2022
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@HDCharles
Update on "[ao] public vs private for ao.quantization._X"
75d91b8 
Summary: added all for these modules without altering names since they
tend to be experimental

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
@HDCharles
Copy link
Contributor Author

@HDCharles has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@HDCharles
Update on "[ao] public vs private for ao.quantization._X"
409c772 
Summary: added all for these modules without altering names since they
tend to be experimental

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D41015543](https://our.internmc.facebook.com/intern/diff/D41015543)

[ghstack-poisoned]
@HDCharles
Copy link
Contributor Author

@HDCharles has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@HDCharles
Update on "[ao] public vs private for ao.quantization._X"
80cd35c 
Summary: added all for these modules without altering names since they
tend to be experimental

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D41015543](https://our.internmc.facebook.com/intern/diff/D41015543)

[ghstack-poisoned]
@HDCharles
Update on "[ao] public vs private for ao.quantization._X"
91651eb 
Summary: added all for these modules without altering names since they
tend to be experimental

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D41015543](https://our.internmc.facebook.com/intern/diff/D41015543)

[ghstack-poisoned]
@HDCharles
Copy link
Contributor Author

@HDCharles has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@HDCharles
Update on "[ao] public vs private for ao.quantization._X"
f06e7e2 
Summary: added all for these modules without altering names since they
tend to be experimental

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D41015543](https://our.internmc.facebook.com/intern/diff/D41015543)

[ghstack-poisoned]
@HDCharles
Update on "[ao] public vs private for ao.quantization._X"
122cdc8 
Summary: added all for these modules without altering names since they
tend to be experimental

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D41015543](https://our.internmc.facebook.com/intern/diff/D41015543)

[ghstack-poisoned]
@HDCharles
Update on "[ao] public vs private for ao.quantization._X"
58871a0 
Summary: added all for these modules without altering names since they
tend to be experimental

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D41015543](https://our.internmc.facebook.com/intern/diff/D41015543)

[ghstack-poisoned]
@HDCharles
Copy link
Contributor Author

@HDCharles has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@HDCharles
Update on "[ao] public vs private for ao.quantization._X"
7bff5c5 
Summary: added all for these modules without altering names since they
tend to be experimental

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D41015543](https://our.internmc.facebook.com/intern/diff/D41015543)

[ghstack-poisoned]
@HDCharles
Update on "[ao] public vs private for ao.quantization._X"
5db13fc 
Summary: added all for these modules without altering names since they
tend to be experimental

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D41015543](https://our.internmc.facebook.com/intern/diff/D41015543)

[ghstack-poisoned]
@HDCharles
Update on "[ao] public vs private for ao.quantization._X"
929ab6a 
Summary: added all for these modules without altering names since they
tend to be experimental

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D41015543](https://our.internmc.facebook.com/intern/diff/D41015543)

[ghstack-poisoned]
@HDCharles
Update on "[ao] public vs private for ao.quantization._X"
89f4e0a 
Summary: added all for these modules without altering names since they
tend to be experimental

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D41015543](https://our.internmc.facebook.com/intern/diff/D41015543)

[ghstack-poisoned]
@HDCharles
Update on "[ao] public vs private for ao.quantization._X"
172d903 
Summary: added all for these modules without altering names since they
tend to be experimental

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D41015543](https://our.internmc.facebook.com/intern/diff/D41015543)

[ghstack-poisoned]
@HDCharles
Update on "[ao] public vs private for ao.quantization._X"
91916ba 
Summary: added all for these modules without altering names since they
tend to be experimental

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D41015543](https://our.internmc.facebook.com/intern/diff/D41015543)

[ghstack-poisoned]
@HDCharles HDCharles mentioned this pull request Dec 7, 2022
Closed
@github-actions github-actions bot added the release notes: quantization release notes category label Dec 7, 2022
@HDCharles
Update on "[ao] public vs private for ao.quantization._X"
c749654 
Summary: added all for these modules without altering names since they
tend to be experimental

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D41015543](https://our.internmc.facebook.com/intern/diff/D41015543)

cc jerryzh168 jianyuh raghuramank100 jamesr66a vkuzo jgong5 Xia-Weiwen leslie-fang-intel

[ghstack-poisoned]
@HDCharles
Update on "[ao] public vs private for ao.quantization._X"
f6c6a80 
Summary: added all for these modules without altering names since they
tend to be experimental

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D41015543](https://our.internmc.facebook.com/intern/diff/D41015543)

cc jerryzh168 jianyuh raghuramank100 jamesr66a vkuzo jgong5 Xia-Weiwen leslie-fang-intel

[ghstack-poisoned]
@HDCharles
Update on "[ao] public vs private for ao.quantization._X"
c2a24f9 
Summary: added all for these modules without altering names since they
tend to be experimental

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D41015543](https://our.internmc.facebook.com/intern/diff/D41015543)

cc jerryzh168 jianyuh raghuramank100 jamesr66a vkuzo jgong5 Xia-Weiwen leslie-fang-intel

[ghstack-poisoned]
@HDCharles
Update on "[ao] public vs private for ao.quantization._X"
b12d573 
Summary: added all for these modules without altering names since they
tend to be experimental

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D41015543](https://our.internmc.facebook.com/intern/diff/D41015543)

cc jerryzh168 jianyuh raghuramank100 jamesr66a vkuzo jgong5 Xia-Weiwen leslie-fang-intel

[ghstack-poisoned]
@HDCharles
Update on "[ao] public vs private for ao.quantization._X"
b6896d3 
Summary: added all for these modules without altering names since they
tend to be experimental

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D41015543](https://our.internmc.facebook.com/intern/diff/D41015543)

cc jerryzh168 jianyuh raghuramank100 jamesr66a vkuzo jgong5 Xia-Weiwen leslie-fang-intel

[ghstack-poisoned]
HDCharles added a commit that referenced this pull request Dec 8, 2022
@HDCharles
[ao] public vs private for ao.quantization._X
85d298b 
Pull Request resolved: #88392


added all for these modules without altering names since they
tend to be experimental
ghstack-source-id: 175594291

Differential Revision: [D41015543](https://our.internmc.facebook.com/intern/diff/D41015543/)
@HDCharles
Copy link
Contributor Author

@pytorchmergebot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Dec 9, 2022
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Dec 10, 2022
@HDCharles @kulinseth
[ao] public vs private for ao.quantization._X (pytorch#88392)
1916d2d 
Summary: added all for these modules without altering names since they
tend to be experimental

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D41015543](https://our.internmc.facebook.com/intern/diff/D41015543)

Pull Request resolved: pytorch#88392
Approved by: https://github.com/jcaip
hasanyeganeh pushed a commit to hasanyeganeh/pytorch-pytorch that referenced this pull request Dec 21, 2022
@HDCharles
[ao] public vs private for ao.quantization._X
70686dd 
Pull Request resolved: pytorch/pytorch#88392


added all for these modules without altering names since they
tend to be experimental
ghstack-source-id: 175555673

Differential Revision: [D41015543](https://our.internmc.facebook.com/intern/diff/D41015543/)
hasanyeganeh pushed a commit to hasanyeganeh/pytorch-pytorch that referenced this pull request Dec 21, 2022
@HDCharles
[ao] public vs private for ao.quantization._X
b77a1b8 
Pull Request resolved: pytorch/pytorch#88392


added all for these modules without altering names since they
tend to be experimental
ghstack-source-id: 175660901

Differential Revision: [D41015543](https://our.internmc.facebook.com/intern/diff/D41015543/)
hasanyeganeh pushed a commit to hasanyeganeh/pytorch-pytorch that referenced this pull request Dec 21, 2022
@HDCharles
[ao] public vs private for ao.quantization._X
06d815a 
Summary: added all for these modules without altering names since they
tend to be experimental

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: c8cfe6bb0f72e14e45cb8ac3dc2840f288887362
Pull Request resolved: pytorch/pytorch#88392
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcaip jcaip jcaip approved these changes

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged oncall: quantization Quantization support in PyTorch release notes: AO frontend release notes: quantization release notes category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@HDCharles @pytorchmergebot @jcaip