[ao] backend_config moving all to top #88391
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: moved __all__ to top of functions, removed private funcitons from all Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/88391
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 7cd2fa8: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Nov 3, 2022
Summary: moved __all__ to top of functions, removed private funcitons from all Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
|
@HDCharles has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: moved __all__ to top of functions, removed private funcitons from all Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D41015538](https://our.internmc.facebook.com/intern/diff/D41015538) [ghstack-poisoned]
|
@HDCharles has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: moved __all__ to top of functions, removed private funcitons from all Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D41015538](https://our.internmc.facebook.com/intern/diff/D41015538) [ghstack-poisoned]
Summary: moved __all__ to top of functions, removed private funcitons from all Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D41015538](https://our.internmc.facebook.com/intern/diff/D41015538) [ghstack-poisoned]
|
@HDCharles has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
jcaip
approved these changes
Nov 11, 2022
Summary: moved __all__ to top of functions, removed private funcitons from all Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D41015538](https://our.internmc.facebook.com/intern/diff/D41015538) [ghstack-poisoned]
Summary: moved __all__ to top of functions, removed private funcitons from all Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D41015538](https://our.internmc.facebook.com/intern/diff/D41015538) [ghstack-poisoned]
Summary: moved __all__ to top of functions, removed private funcitons from all Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D41015538](https://our.internmc.facebook.com/intern/diff/D41015538) [ghstack-poisoned]
|
@HDCharles has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: moved __all__ to top of functions, removed private funcitons from all Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D41015538](https://our.internmc.facebook.com/intern/diff/D41015538) [ghstack-poisoned]
Summary: moved __all__ to top of functions, removed private funcitons from all Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D41015538](https://our.internmc.facebook.com/intern/diff/D41015538) [ghstack-poisoned]
Summary: moved __all__ to top of functions, removed private funcitons from all Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D41015538](https://our.internmc.facebook.com/intern/diff/D41015538) [ghstack-poisoned]
Summary: moved __all__ to top of functions, removed private funcitons from all Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D41015538](https://our.internmc.facebook.com/intern/diff/D41015538) [ghstack-poisoned]
Summary: moved __all__ to top of functions, removed private funcitons from all Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D41015538](https://our.internmc.facebook.com/intern/diff/D41015538) [ghstack-poisoned]
Summary: moved __all__ to top of functions, removed private funcitons from all Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D41015538](https://our.internmc.facebook.com/intern/diff/D41015538) [ghstack-poisoned]
Summary: moved __all__ to top of functions, removed private funcitons from all Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D41015538](https://our.internmc.facebook.com/intern/diff/D41015538) cc jerryzh168 jianyuh raghuramank100 jamesr66a vkuzo jgong5 Xia-Weiwen leslie-fang-intel [ghstack-poisoned]
Summary: moved __all__ to top of functions, removed private funcitons from all Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D41015538](https://our.internmc.facebook.com/intern/diff/D41015538) cc jerryzh168 jianyuh raghuramank100 jamesr66a vkuzo jgong5 Xia-Weiwen leslie-fang-intel [ghstack-poisoned]
Summary: moved __all__ to top of functions, removed private funcitons from all Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D41015538](https://our.internmc.facebook.com/intern/diff/D41015538) cc jerryzh168 jianyuh raghuramank100 jamesr66a vkuzo jgong5 Xia-Weiwen leslie-fang-intel [ghstack-poisoned]
Summary: moved __all__ to top of functions, removed private funcitons from all Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D41015538](https://our.internmc.facebook.com/intern/diff/D41015538) cc jerryzh168 jianyuh raghuramank100 jamesr66a vkuzo jgong5 Xia-Weiwen leslie-fang-intel [ghstack-poisoned]
Summary: moved __all__ to top of functions, removed private funcitons from all Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D41015538](https://our.internmc.facebook.com/intern/diff/D41015538) cc jerryzh168 jianyuh raghuramank100 jamesr66a vkuzo jgong5 Xia-Weiwen leslie-fang-intel [ghstack-poisoned]
HDCharles
added a commit
that referenced
this pull request
Dec 8, 2022
Pull Request resolved: #88391 moved __all__ to top of functions, removed private funcitons from all ghstack-source-id: 175577196 Differential Revision: [D41015538](https://our.internmc.facebook.com/intern/diff/D41015538/)
|
@pytorchmergebot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
This pull request has been merged in 6050a7a. |
kulinseth
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Dec 10, 2022
Summary: moved __all__ to top of functions, removed private funcitons from all Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D41015538](https://our.internmc.facebook.com/intern/diff/D41015538) Pull Request resolved: pytorch#88391 Approved by: https://github.com/jcaip
hasanyeganeh
pushed a commit
to hasanyeganeh/pytorch-pytorch
that referenced
this pull request
Dec 21, 2022
Pull Request resolved: pytorch/pytorch#88391 moved __all__ to top of functions, removed private funcitons from all ghstack-source-id: 175555676 Differential Revision: [D41015538](https://our.internmc.facebook.com/intern/diff/D41015538/)
hasanyeganeh
pushed a commit
to hasanyeganeh/pytorch-pytorch
that referenced
this pull request
Dec 21, 2022
Summary: moved __all__ to top of functions, removed private funcitons from all Test Plan: python test/test_public_bindings.py Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 9c47e78221cf2ec6f1b572c6cf2266ca0d23c101 Pull Request resolved: pytorch/pytorch#88391
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary: moved all to top of functions, removed private funcitons
from all
Test Plan: python test/test_public_bindings.py
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D41015538
cc @jerryzh168 @jianyuh @raghuramank100 @jamesr66a @vkuzo @jgong5 @Xia-Weiwen @leslie-fang-intel