New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ao] qconfig_mapping.py fixing public v private #87518

Closed

HDCharles wants to merge 9 commits into gh/HDCharles/124/base from gh/HDCharles/124/head

Contributor

HDCharles commented Oct 21, 2022 •

edited by pytorch-bot bot

Stack from ghstack (oldest at bottom):

Summary: made _GLOBAL_DICT_KEY, _OBJECT_TYPE_DICT_KEY,
_MODULE_NAME_REGEX_DICT_KEY, _MODULE_NAME_DICT_KEY,
_MODULE_NAME_OBJECT_TYPE_ORDER_DICT_KEY private

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: D40709278

cc @jerryzh168 @jianyuh @raghuramank100 @jamesr66a @vkuzo @jgong5 @Xia-Weiwen @leslie-fang-intel


          [ao] qconfig_mapping.py fixing public v private

Summary: made _GLOBAL_DICT_KEY, _OBJECT_TYPE_DICT_KEY,
_MODULE_NAME_REGEX_DICT_KEY, _MODULE_NAME_DICT_KEY,
_MODULE_NAME_OBJECT_TYPE_ORDER_DICT_KEY private

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]

HDCharles requested review from jerryzh168 and z-a-f as code owners

October 21, 2022 22:06

pytorch-bot bot commented Oct 21, 2022 •

edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/87518

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 9f2954e:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pytorch-bot bot added the release notes: quantization label

This was referenced Oct 21, 2022

[ao] qconfig.py fix public v private #87515

Closed

[ao] fuser_method_mappings.py fixing public v private #87516

Closed

[ao] qconfig_mapping_utils.py fixing public v private #87517

Closed

[ao] quant_type.py fixing public v private #87519

Closed

[ao] making _is_activation_post_process private #87520

Closed

[ao] quantize.py fixing public v private #87521

Closed


          Update on "[ao] qconfig_mapping.py fixing public v private"

b2c58d7

Summary: made _GLOBAL_DICT_KEY, _OBJECT_TYPE_DICT_KEY,
_MODULE_NAME_REGEX_DICT_KEY, _MODULE_NAME_DICT_KEY,
_MODULE_NAME_OBJECT_TYPE_ORDER_DICT_KEY private

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]

Contributor Author

HDCharles commented Oct 26, 2022

@HDCharles has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.


          Update on "[ao] qconfig_mapping.py fixing public v private"

2bcac02

Summary: made _GLOBAL_DICT_KEY, _OBJECT_TYPE_DICT_KEY,
_MODULE_NAME_REGEX_DICT_KEY, _MODULE_NAME_DICT_KEY,
_MODULE_NAME_OBJECT_TYPE_ORDER_DICT_KEY private

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D40709278](https://our.internmc.facebook.com/intern/diff/D40709278)

[ghstack-poisoned]

This was referenced Oct 27, 2022

[ao] fixing public v private for torch.ao.nn.X #87883

Closed

[ao] fixing public v private for nn util functions #87884

Closed

[ao] public v private stubs and utils #87885

Closed

Contributor Author

HDCharles commented Oct 28, 2022

@HDCharles has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.


          Update on "[ao] qconfig_mapping.py fixing public v private"

dcf5b20

Summary: made _GLOBAL_DICT_KEY, _OBJECT_TYPE_DICT_KEY,
_MODULE_NAME_REGEX_DICT_KEY, _MODULE_NAME_DICT_KEY,
_MODULE_NAME_OBJECT_TYPE_ORDER_DICT_KEY private

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D40709278](https://our.internmc.facebook.com/intern/diff/D40709278)

[ghstack-poisoned]

This was referenced Nov 3, 2022

[ao] backend_config moving all to top #88391

Closed

[ao] public vs private for ao.quantization._X #88392

Closed

[ao][fx] public v private for backend_config_utils.py #88393

Closed

[ao][fx] public v private convert.py #88394

Closed

[ao][fx] fixing public v private graph_module.py #88395

Closed

[ao][fx] fixing public v private match_utils.py #88396

Closed

[ao][fx] fixing public v private for pattern_utils.py #88397

Closed

[ao][fx] fixing public v private prepare.py #88398

Closed

[ao][fx] fixing public v private qconfig_mapping_utils.py #88399

Closed

[ao][fx] fixing public v private utils.py #88400

Closed

github-actions bot added the oncall: quantization label

This was referenced Nov 3, 2022

[ao] removing private from allowlist #88404

Closed

[ao] fixing private in quantization-support.rst #88405

Closed


          Update on "[ao] qconfig_mapping.py fixing public v private"

Summary: made _GLOBAL_DICT_KEY, _OBJECT_TYPE_DICT_KEY,
_MODULE_NAME_REGEX_DICT_KEY, _MODULE_NAME_DICT_KEY,
_MODULE_NAME_OBJECT_TYPE_ORDER_DICT_KEY private

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D40709278](https://our.internmc.facebook.com/intern/diff/D40709278)

cc jerryzh168 jianyuh raghuramank100 jamesr66a vkuzo jgong5 Xia-Weiwen

[ghstack-poisoned]

Contributor Author

HDCharles commented Nov 4, 2022

@HDCharles has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.


          Update on "[ao] qconfig_mapping.py fixing public v private"

be1fe03

Summary: made _GLOBAL_DICT_KEY, _OBJECT_TYPE_DICT_KEY,
_MODULE_NAME_REGEX_DICT_KEY, _MODULE_NAME_DICT_KEY,
_MODULE_NAME_OBJECT_TYPE_ORDER_DICT_KEY private

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D40709278](https://our.internmc.facebook.com/intern/diff/D40709278)

cc jerryzh168 jianyuh raghuramank100 jamesr66a vkuzo jgong5 Xia-Weiwen

[ghstack-poisoned]

Contributor Author

HDCharles commented Nov 4, 2022

@HDCharles has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

HDCharles added 2 commits

November 4, 2022 21:56


          Update on "[ao] qconfig_mapping.py fixing public v private"

fae1665

Summary: made _GLOBAL_DICT_KEY, _OBJECT_TYPE_DICT_KEY,
_MODULE_NAME_REGEX_DICT_KEY, _MODULE_NAME_DICT_KEY,
_MODULE_NAME_OBJECT_TYPE_ORDER_DICT_KEY private

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D40709278](https://our.internmc.facebook.com/intern/diff/D40709278)

cc jerryzh168 jianyuh raghuramank100 jamesr66a vkuzo jgong5 Xia-Weiwen

[ghstack-poisoned]


          Update on "[ao] qconfig_mapping.py fixing public v private"

b542c2f

Summary: made _GLOBAL_DICT_KEY, _OBJECT_TYPE_DICT_KEY,
_MODULE_NAME_REGEX_DICT_KEY, _MODULE_NAME_DICT_KEY,
_MODULE_NAME_OBJECT_TYPE_ORDER_DICT_KEY private

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D40709278](https://our.internmc.facebook.com/intern/diff/D40709278)

cc jerryzh168 jianyuh raghuramank100 jamesr66a vkuzo jgong5 Xia-Weiwen

[ghstack-poisoned]

Contributor Author

HDCharles commented Nov 7, 2022

@HDCharles has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.


          Update on "[ao] qconfig_mapping.py fixing public v private"

9f2954e

Summary: made _GLOBAL_DICT_KEY, _OBJECT_TYPE_DICT_KEY,
_MODULE_NAME_REGEX_DICT_KEY, _MODULE_NAME_DICT_KEY,
_MODULE_NAME_OBJECT_TYPE_ORDER_DICT_KEY private

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D40709278](https://our.internmc.facebook.com/intern/diff/D40709278)

[ghstack-poisoned]

Contributor Author

HDCharles commented Nov 8, 2022

@HDCharles has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

jcaip approved these changes

View reviewed changes

Contributor

facebook-github-bot commented Nov 11, 2022

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

pytorch-bot bot added the ciflow/trunk label

Collaborator

pytorchmergebot commented Nov 11, 2022

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot added the Merged label

pytorchmergebot closed this in

072834d

kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request


          [ao] qconfig_mapping.py fixing public v private (pytorch#87518)

4e4786c

Summary: made _GLOBAL_DICT_KEY, _OBJECT_TYPE_DICT_KEY,
_MODULE_NAME_REGEX_DICT_KEY, _MODULE_NAME_DICT_KEY,
_MODULE_NAME_OBJECT_TYPE_ORDER_DICT_KEY private

Test Plan: python test/test_public_bindings.py

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D40709278](https://our.internmc.facebook.com/intern/diff/D40709278)

Pull Request resolved: pytorch#87518
Approved by: https://github.com/jcaip

facebook-github-bot deleted the gh/HDCharles/124/head branch

June 8, 2023 14:37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment