Skip to content

Conversation

ezyang
Copy link
Contributor

@ezyang ezyang commented Oct 24, 2022

Stack from ghstack (oldest at bottom):

Signed-off-by: Edward Z. Yang <ezyangfb.com>

cc @jansel @lezcano @fdrocha @mlazos @soumith @voznesenskym @yanboliang @penguinwu @anijain2305

Signed-off-by: Edward Z. Yang <ezyangfb.com>

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 24, 2022

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/87606

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Failures, 2 Pending

As of commit d2d989a:

The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@github-actions
Copy link
Contributor

This PR needs a label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

For more information, see https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just have a lint for that?

@ezyang
Copy link
Contributor Author

ezyang commented Oct 24, 2022

@albanD sure, should be simple enough

Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we enable lint on dynamo?

@ezyang
Copy link
Contributor Author

ezyang commented Oct 24, 2022

will do in follow up, enabling lint is a better way to do it than grep but I see more failures...

Signed-off-by: Edward Z. Yang <ezyangfb.com>

cc jansel lezcano fdrocha mlazos soumith voznesenskym yanboliang penguinwu

[ghstack-poisoned]
@desertfire
Copy link
Contributor

There is also direct reference to torchinductor in the same file. Can we fix those?

Signed-off-by: Edward Z. Yang <ezyangfb.com>

cc jansel lezcano fdrocha mlazos soumith voznesenskym yanboliang penguinwu

[ghstack-poisoned]
ezyang added a commit that referenced this pull request Oct 24, 2022
Signed-off-by: Edward Z. Yang <ezyangfb.com>

ghstack-source-id: df43094
Pull Request resolved: #87606
@ezyang
Copy link
Contributor Author

ezyang commented Oct 24, 2022

done.

@anijain2305 It's also not good that we don't have any testing coverage for this, we really should have it for the minifier

@ezyang
Copy link
Contributor Author

ezyang commented Oct 24, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: The following mandatory check(s) failed (Rule superuser):

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

@ezyang
Copy link
Contributor Author

ezyang commented Oct 24, 2022

@pytorchbot merge -f "spurious ci failure"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions
Copy link
Contributor

Hey @ezyang.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@ezyang ezyang added the topic: bug fixes topic category label Oct 24, 2022
@anijain2305
Copy link
Contributor

done.

@anijain2305 It's also not good that we don't have any testing coverage for this, we really should have it for the minifier

@williamwen42 is planning to look at it this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants