-
Notifications
You must be signed in to change notification settings - Fork 25.2k
Fix accuracy minifier #87606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix accuracy minifier #87606
Conversation
Signed-off-by: Edward Z. Yang <ezyangfb.com> [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/87606
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 Failures, 2 PendingAs of commit d2d989a: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a labelIf your changes are user facing and intended to be a part of release notes, please use a label starting with If not, please add the For more information, see https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we just have a lint for that?
@albanD sure, should be simple enough |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we enable lint on dynamo?
will do in follow up, enabling lint is a better way to do it than grep but I see more failures... |
Signed-off-by: Edward Z. Yang <ezyangfb.com> cc jansel lezcano fdrocha mlazos soumith voznesenskym yanboliang penguinwu [ghstack-poisoned]
There is also direct reference to |
Signed-off-by: Edward Z. Yang <ezyangfb.com> cc jansel lezcano fdrocha mlazos soumith voznesenskym yanboliang penguinwu [ghstack-poisoned]
done. @anijain2305 It's also not good that we don't have any testing coverage for this, we really should have it for the minifier |
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: The following mandatory check(s) failed (Rule Dig deeper by viewing the failures on hud Details for Dev Infra teamRaised by workflow job |
@pytorchbot merge -f "spurious ci failure" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Hey @ezyang. |
@williamwen42 is planning to look at it this week. |
Signed-off-by: Edward Z. Yang <ezyangfb.com> cc @jansel @lezcano @fdrocha @mlazos @soumith @voznesenskym @yanboliang @penguinwu Pull Request resolved: #87606 Approved by: https://github.com/anjali411, https://github.com/anijain2305, https://github.com/albanD, https://github.com/soumith, https://github.com/malfet
Signed-off-by: Edward Z. Yang <ezyangfb.com> cc @jansel @lezcano @fdrocha @mlazos @soumith @voznesenskym @yanboliang @penguinwu Pull Request resolved: pytorch#87606 Approved by: https://github.com/anjali411, https://github.com/anijain2305, https://github.com/albanD, https://github.com/soumith, https://github.com/malfet
Signed-off-by: Edward Z. Yang <ezyangfb.com> cc @jansel @lezcano @fdrocha @mlazos @soumith @voznesenskym @yanboliang @penguinwu Pull Request resolved: pytorch#87606 Approved by: https://github.com/anjali411, https://github.com/anijain2305, https://github.com/albanD, https://github.com/soumith, https://github.com/malfet
Stack from ghstack (oldest at bottom):
Signed-off-by: Edward Z. Yang <ezyangfb.com>
cc @jansel @lezcano @fdrocha @mlazos @soumith @voznesenskym @yanboliang @penguinwu @anijain2305