add nesting to TORCH_SHOW_DISPATCH_TRACE #87751
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/87751
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit b29ab2c: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
github-actions
bot
requested review from
albanD,
anjali411,
antoniojkim,
Chillee,
ezyang,
Krovatkin,
miladm and
wconstab
ezyang
approved these changes
Oct 26, 2022
zou3519
approved these changes
Oct 26, 2022
Added indents to `TORCH_SHOW_DISPATCH_TRACE` so that you more easily see the call tree from the dispatcher. Definitely slower, but it's all guarded under the `DEBUG` build. Example output:
I know we have the PyDispatcher now, but I still found this helpful for debugging
```
[call] op=[aten::ones], key=[BackendSelect]
[redispatch] op=[aten::ones], key=[CPU]
[call] op=[aten::empty.memory_format], key=[BackendSelect]
[redispatch] op=[aten::empty.memory_format], key=[CPU]
[call] op=[aten::fill_.Scalar], key=[CPU]
[call] op=[aten::clone], key=[AutogradCPU]
[redispatch] op=[aten::clone], key=[CPU]
[call] op=[aten::empty_strided], key=[BackendSelect]
[redispatch] op=[aten::empty_strided], key=[CPU]
[call] op=[aten::copy_], key=[CPU]
[call] op=[aten::view], key=[PythonTLSSnapshot]
[redispatchBoxed] op=[aten::view], key=[AutogradCPU]
[redispatch] op=[aten::view], key=[ADInplaceOrView]
[redispatch] op=[aten::view], key=[Functionalize]
[call] op=[aten::view], key=[PythonTLSSnapshot]
[redispatchBoxed] op=[aten::view], key=[Meta]
[call] op=[aten::view], key=[PythonTLSSnapshot]
[redispatchBoxed] op=[aten::view], key=[Python]
[callBoxed] op=[aten::view], key=[CPU]
[call] op=[aten::clone], key=[PythonTLSSnapshot]
[redispatchBoxed] op=[aten::clone], key=[AutogradCPU]
[redispatch] op=[aten::clone], key=[Functionalize]
[callBoxed] op=[aten::clone], key=[PythonTLSSnapshot]
[redispatchBoxed] op=[aten::clone], key=[Python]
[callBoxed] op=[aten::clone], key=[CPU]
[call] op=[aten::empty_strided], key=[BackendSelect]
[redispatch] op=[aten::empty_strided], key=[CPU]
[call] op=[aten::copy_], key=[CPU]
```
[ghstack-poisoned]
bdhirsh
added
release notes: composability
Added indents to `TORCH_SHOW_DISPATCH_TRACE` so that you more easily see the call tree from the dispatcher. Definitely slower, but it's all guarded under the `DEBUG` build. Example output:
I know we have the PyDispatcher now, but I still found this helpful for debugging
```
[call] op=[aten::ones], key=[BackendSelect]
[redispatch] op=[aten::ones], key=[CPU]
[call] op=[aten::empty.memory_format], key=[BackendSelect]
[redispatch] op=[aten::empty.memory_format], key=[CPU]
[call] op=[aten::fill_.Scalar], key=[CPU]
[call] op=[aten::clone], key=[AutogradCPU]
[redispatch] op=[aten::clone], key=[CPU]
[call] op=[aten::empty_strided], key=[BackendSelect]
[redispatch] op=[aten::empty_strided], key=[CPU]
[call] op=[aten::copy_], key=[CPU]
[call] op=[aten::view], key=[PythonTLSSnapshot]
[redispatchBoxed] op=[aten::view], key=[AutogradCPU]
[redispatch] op=[aten::view], key=[ADInplaceOrView]
[redispatch] op=[aten::view], key=[Functionalize]
[call] op=[aten::view], key=[PythonTLSSnapshot]
[redispatchBoxed] op=[aten::view], key=[Meta]
[call] op=[aten::view], key=[PythonTLSSnapshot]
[redispatchBoxed] op=[aten::view], key=[Python]
[callBoxed] op=[aten::view], key=[CPU]
[call] op=[aten::clone], key=[PythonTLSSnapshot]
[redispatchBoxed] op=[aten::clone], key=[AutogradCPU]
[redispatch] op=[aten::clone], key=[Functionalize]
[callBoxed] op=[aten::clone], key=[PythonTLSSnapshot]
[redispatchBoxed] op=[aten::clone], key=[Python]
[callBoxed] op=[aten::clone], key=[CPU]
[call] op=[aten::empty_strided], key=[BackendSelect]
[redispatch] op=[aten::empty_strided], key=[CPU]
[call] op=[aten::copy_], key=[CPU]
```
[ghstack-poisoned]
Added indents to `TORCH_SHOW_DISPATCH_TRACE` so that you more easily see the call tree from the dispatcher. Definitely slower, but it's all guarded under the `DEBUG` build. Example output:
I know we have the PyDispatcher now, but I still found this helpful for debugging
```
[call] op=[aten::ones], key=[BackendSelect]
[redispatch] op=[aten::ones], key=[CPU]
[call] op=[aten::empty.memory_format], key=[BackendSelect]
[redispatch] op=[aten::empty.memory_format], key=[CPU]
[call] op=[aten::fill_.Scalar], key=[CPU]
[call] op=[aten::clone], key=[AutogradCPU]
[redispatch] op=[aten::clone], key=[CPU]
[call] op=[aten::empty_strided], key=[BackendSelect]
[redispatch] op=[aten::empty_strided], key=[CPU]
[call] op=[aten::copy_], key=[CPU]
[call] op=[aten::view], key=[PythonTLSSnapshot]
[redispatchBoxed] op=[aten::view], key=[AutogradCPU]
[redispatch] op=[aten::view], key=[ADInplaceOrView]
[redispatch] op=[aten::view], key=[Functionalize]
[call] op=[aten::view], key=[PythonTLSSnapshot]
[redispatchBoxed] op=[aten::view], key=[Meta]
[call] op=[aten::view], key=[PythonTLSSnapshot]
[redispatchBoxed] op=[aten::view], key=[Python]
[callBoxed] op=[aten::view], key=[CPU]
[call] op=[aten::clone], key=[PythonTLSSnapshot]
[redispatchBoxed] op=[aten::clone], key=[AutogradCPU]
[redispatch] op=[aten::clone], key=[Functionalize]
[callBoxed] op=[aten::clone], key=[PythonTLSSnapshot]
[redispatchBoxed] op=[aten::clone], key=[Python]
[callBoxed] op=[aten::clone], key=[CPU]
[call] op=[aten::empty_strided], key=[BackendSelect]
[redispatch] op=[aten::empty_strided], key=[CPU]
[call] op=[aten::copy_], key=[CPU]
```
[ghstack-poisoned]
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
kulinseth
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Nov 5, 2022
Added indents to `TORCH_SHOW_DISPATCH_TRACE` so that you more easily see the call tree from the dispatcher. Definitely slower, but it's all guarded under the `DEBUG` build. Example output:
I know we have the PyDispatcher now, but I still found this helpful for debugging
```
[call] op=[aten::ones], key=[BackendSelect]
[redispatch] op=[aten::ones], key=[CPU]
[call] op=[aten::empty.memory_format], key=[BackendSelect]
[redispatch] op=[aten::empty.memory_format], key=[CPU]
[call] op=[aten::fill_.Scalar], key=[CPU]
[call] op=[aten::clone], key=[AutogradCPU]
[redispatch] op=[aten::clone], key=[CPU]
[call] op=[aten::empty_strided], key=[BackendSelect]
[redispatch] op=[aten::empty_strided], key=[CPU]
[call] op=[aten::copy_], key=[CPU]
[call] op=[aten::view], key=[PythonTLSSnapshot]
[redispatchBoxed] op=[aten::view], key=[AutogradCPU]
[redispatch] op=[aten::view], key=[ADInplaceOrView]
[redispatch] op=[aten::view], key=[Functionalize]
[call] op=[aten::view], key=[PythonTLSSnapshot]
[redispatchBoxed] op=[aten::view], key=[Meta]
[call] op=[aten::view], key=[PythonTLSSnapshot]
[redispatchBoxed] op=[aten::view], key=[Python]
[callBoxed] op=[aten::view], key=[CPU]
[call] op=[aten::clone], key=[PythonTLSSnapshot]
[redispatchBoxed] op=[aten::clone], key=[AutogradCPU]
[redispatch] op=[aten::clone], key=[Functionalize]
[callBoxed] op=[aten::clone], key=[PythonTLSSnapshot]
[redispatchBoxed] op=[aten::clone], key=[Python]
[callBoxed] op=[aten::clone], key=[CPU]
[call] op=[aten::empty_strided], key=[BackendSelect]
[redispatch] op=[aten::empty_strided], key=[CPU]
[call] op=[aten::copy_], key=[CPU]
```
Pull Request resolved: pytorch#87751
Approved by: https://github.com/ezyang, https://github.com/zou3519
kulinseth
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Dec 10, 2022
Added indents to `TORCH_SHOW_DISPATCH_TRACE` so that you more easily see the call tree from the dispatcher. Definitely slower, but it's all guarded under the `DEBUG` build. Example output:
I know we have the PyDispatcher now, but I still found this helpful for debugging
```
[call] op=[aten::ones], key=[BackendSelect]
[redispatch] op=[aten::ones], key=[CPU]
[call] op=[aten::empty.memory_format], key=[BackendSelect]
[redispatch] op=[aten::empty.memory_format], key=[CPU]
[call] op=[aten::fill_.Scalar], key=[CPU]
[call] op=[aten::clone], key=[AutogradCPU]
[redispatch] op=[aten::clone], key=[CPU]
[call] op=[aten::empty_strided], key=[BackendSelect]
[redispatch] op=[aten::empty_strided], key=[CPU]
[call] op=[aten::copy_], key=[CPU]
[call] op=[aten::view], key=[PythonTLSSnapshot]
[redispatchBoxed] op=[aten::view], key=[AutogradCPU]
[redispatch] op=[aten::view], key=[ADInplaceOrView]
[redispatch] op=[aten::view], key=[Functionalize]
[call] op=[aten::view], key=[PythonTLSSnapshot]
[redispatchBoxed] op=[aten::view], key=[Meta]
[call] op=[aten::view], key=[PythonTLSSnapshot]
[redispatchBoxed] op=[aten::view], key=[Python]
[callBoxed] op=[aten::view], key=[CPU]
[call] op=[aten::clone], key=[PythonTLSSnapshot]
[redispatchBoxed] op=[aten::clone], key=[AutogradCPU]
[redispatch] op=[aten::clone], key=[Functionalize]
[callBoxed] op=[aten::clone], key=[PythonTLSSnapshot]
[redispatchBoxed] op=[aten::clone], key=[Python]
[callBoxed] op=[aten::clone], key=[CPU]
[call] op=[aten::empty_strided], key=[BackendSelect]
[redispatch] op=[aten::empty_strided], key=[CPU]
[call] op=[aten::copy_], key=[CPU]
```
Pull Request resolved: pytorch#87751
Approved by: https://github.com/ezyang, https://github.com/zou3519
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added indents to
TORCH_SHOW_DISPATCH_TRACEso that you more easily see the call tree from the dispatcher. Definitely slower, but it's all guarded under theDEBUGbuild. Example output:I know we have the PyDispatcher now, but I still found this helpful for debugging
Stack from ghstack (oldest at bottom):