Skip to content

[edge profiler] Add support for performance events counting #87876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 11 commits into from
Closed

[edge profiler] Add support for performance events counting #87876

wants to merge 11 commits into from

Conversation

digantdesai
Copy link
Contributor

@digantdesai digantdesai commented Oct 27, 2022 •
edited
Loading

Stack from ghstack (oldest at bottom):

Differential Revision: D39837216

NOTE FOR REVIEWERS: This PR has internal Meta-specific changes or comments, please review them on Phabricator!

@digantdesai
[edge profiler] Add support for performance events counting
31d5ff2 
* Add support in lite_predictor benchmark binary to select event lists
* Uses Linux perf through Kineto profiler

Differential Revision: [D39837216](https://our.internmc.facebook.com/intern/diff/D39837216/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D39837216/)!

[ghstack-poisoned]
@pytorch-bot pytorch-bot bot added the release notes: mobile release notes category label Oct 27, 2022
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 27, 2022 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/87876

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Failures, 3 Pending

As of commit a55fdaa:

The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

This was referenced Oct 27, 2022
Closed
Closed
@digantdesai
Update on "[edge profiler] Add support for performance events counting"
218af12 
* Add support in lite_predictor benchmark binary to select event lists
* Uses Linux perf through Kineto profiler

Differential Revision: [D39837216](https://our.internmc.facebook.com/intern/diff/D39837216/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D39837216/)!

[ghstack-poisoned]
This was referenced Oct 27, 2022
Closed
Closed
Closed
@digantdesai
Update on "[edge profiler] Add support for performance events counting"
51c6353 
* Add support in lite_predictor benchmark binary to select event lists
* Uses Linux perf through Kineto profiler

Differential Revision: [D39837216](https://our.internmc.facebook.com/intern/diff/D39837216/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D39837216/)!

[ghstack-poisoned]
This was referenced Oct 27, 2022
Closed
Closed
@digantdesai
Update on "[edge profiler] Add support for performance events counting"
9563646 
* Add support in lite_predictor benchmark binary to select event lists
* Uses Linux perf through Kineto profiler

Differential Revision: [D39837216](https://our.internmc.facebook.com/intern/diff/D39837216/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D39837216/)!

[ghstack-poisoned]
@digantdesai
Update on "[edge profiler] Add support for performance events counting"
4b7347f 
* Add support in lite_predictor benchmark binary to select event lists
* Uses Linux perf through Kineto profiler

Differential Revision: [D39837216](https://our.internmc.facebook.com/intern/diff/D39837216/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D39837216/)!

[ghstack-poisoned]
@digantdesai
Update on "[edge profiler] Add support for performance events counting"
6738404 
* Add support in lite_predictor benchmark binary to select event lists
* Uses Linux perf through Kineto profiler

Differential Revision: [D39837216](https://our.internmc.facebook.com/intern/diff/D39837216/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D39837216/)!

[ghstack-poisoned]
@SS-JIA SS-JIA self-requested a review October 31, 2022 16:13
@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 31, 2022
@digantdesai
Update on "[edge profiler] Add support for performance events counting"
0e07a12 
* Add support in lite_predictor benchmark binary to select event lists
* Uses Linux perf through Kineto profiler

Differential Revision: [D39837216](https://our.internmc.facebook.com/intern/diff/D39837216/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D39837216/)!

[ghstack-poisoned]
@digantdesai
Update on "[edge profiler] Add support for performance events counting"
bcbbcd7 
* Add support in lite_predictor benchmark binary to select event lists
* Uses Linux perf through Kineto profiler

Differential Revision: [D39837216](https://our.internmc.facebook.com/intern/diff/D39837216/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D39837216/)!

[ghstack-poisoned]
@digantdesai
Update on "[edge profiler] Add support for performance events counting"
03864e7 
* Add support in lite_predictor benchmark binary to select event lists
* Uses Linux perf through Kineto profiler

Differential Revision: [D39837216](https://our.internmc.facebook.com/intern/diff/D39837216/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D39837216/)!

[ghstack-poisoned]
@digantdesai
Update on "[edge profiler] Add support for performance events counting"
2015a8f 
* Add support in lite_predictor benchmark binary to select event lists
* Uses Linux perf through Kineto profiler

Differential Revision: [D39837216](https://our.internmc.facebook.com/intern/diff/D39837216/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D39837216/)!

[ghstack-poisoned]
@digantdesai
Update on "[edge profiler] Add support for performance events counting"
a55fdaa 
* Add support in lite_predictor benchmark binary to select event lists
* Uses Linux perf through Kineto profiler

Differential Revision: [D39837216](https://our.internmc.facebook.com/intern/diff/D39837216/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D39837216/)!

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

@pytorchbot merge -f 'Landed internally'

(Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally)

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Nov 5, 2022
@digantdesai @kulinseth
[edge profiler] Add support for performance events counting (pytorch#…
4d5b272 
…87876)

* Add support in lite_predictor benchmark binary to select event lists
* Uses Linux perf through Kineto profiler

Differential Revision: [D39837216](https://our.internmc.facebook.com/intern/diff/D39837216/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D39837216/)!
Pull Request resolved: pytorch#87876
Approved by: https://github.com/SS-JIA
kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Dec 10, 2022
@digantdesai @kulinseth
[edge profiler] Add support for performance events counting (pytorch#…
3c23566 
…87876)

* Add support in lite_predictor benchmark binary to select event lists
* Uses Linux perf through Kineto profiler

Differential Revision: [D39837216](https://our.internmc.facebook.com/intern/diff/D39837216/)

**NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D39837216/)!
Pull Request resolved: pytorch#87876
Approved by: https://github.com/SS-JIA
@facebook-github-bot facebook-github-bot deleted the gh/digantdesai/7/head branch June 8, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SS-JIA SS-JIA SS-JIA approved these changes

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: mobile release notes category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@digantdesai @facebook-github-bot @pytorchmergebot @SS-JIA