-
Notifications
You must be signed in to change notification settings - Fork 25k
Add ops.broadcast for nvFuser #88080
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ops.broadcast for nvFuser #88080
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/88080
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 FailuresAs of commit 30e7ba8: The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Hopefully, we can just remove the broadcast_in_dim
fusion record in the future or replace it with an expand
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stamped!
@pytorchbot merge -f "flaky cuda11.6-py3.10-gcc7-sm86" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Having nvFuser's `broadcast` available alongside `broadcast_in_dim` would allow easier experimentation. Pull Request resolved: pytorch#88080 Approved by: https://github.com/jjsjann123, https://github.com/kevinstephano, https://github.com/mruberry
Having nvFuser's `broadcast` available alongside `broadcast_in_dim` would allow easier experimentation. Pull Request resolved: pytorch/pytorch#88080 Approved by: https://github.com/jjsjann123, https://github.com/kevinstephano, https://github.com/mruberry
Having nvFuser's `broadcast` available alongside `broadcast_in_dim` would allow easier experimentation. Pull Request resolved: pytorch#88080 Approved by: https://github.com/jjsjann123, https://github.com/kevinstephano, https://github.com/mruberry
Having nvFuser's
broadcast
available alongsidebroadcast_in_dim
would allow easier experimentation.cc @kevinstephano @jjsjann123