Skip to content

Reenable assert sanity testing with ADInplaceOrView reenable #88102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

Reenable assert sanity testing with ADInplaceOrView reenable #88102

wants to merge 5 commits into from

Conversation

ezyang
Copy link
Contributor

@ezyang ezyang commented Oct 31, 2022 •
edited
Loading

Stack from ghstack (oldest at bottom):

Signed-off-by: Edward Z. Yang ezyang@fb.com

@ezyang
Reenable assert sanity testing with ADInplaceOrView reenable
014140f 
Signed-off-by: Edward Z. Yang <ezyang@fb.com>

[ghstack-poisoned]
@ezyang ezyang mentioned this pull request Oct 31, 2022
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 31, 2022 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/88102

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 Failures

As of commit 41c831b:

The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@ezyang
Update on "Reenable assert sanity testing with ADInplaceOrView reenable"
251b6c5 
Signed-off-by: Edward Z. Yang <ezyangfb.com>

[ghstack-poisoned]
albanD
albanD reviewed Oct 31, 2022
View reviewed changes
@ezyang
Update on "Reenable assert sanity testing with ADInplaceOrView reenable"
4b82048 
Signed-off-by: Edward Z. Yang <ezyangfb.com>

[ghstack-poisoned]
ezyang added a commit that referenced this pull request Oct 31, 2022
@ezyang
Reenable assert sanity testing with ADInplaceOrView reenable
677d89c 
Signed-off-by: Edward Z. Yang <ezyangfb.com>

ghstack-source-id: 31cfc49
Pull Request resolved: #88102
albanD
albanD approved these changes Oct 31, 2022
View reviewed changes
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 31, 2022
@ezyang
Update on "Reenable assert sanity testing with ADInplaceOrView reenable"
4da0ec4 
Signed-off-by: Edward Z. Yang <ezyangfb.com>

[ghstack-poisoned]
@ezyang
Update on "Reenable assert sanity testing with ADInplaceOrView reenable"
41c831b 
Signed-off-by: Edward Z. Yang <ezyangfb.com>

[ghstack-poisoned]
ezyang added a commit that referenced this pull request Nov 1, 2022
@ezyang
Reenable assert sanity testing with ADInplaceOrView reenable
88ddd82 
Signed-off-by: Edward Z. Yang <ezyangfb.com>

ghstack-source-id: ed5b039
Pull Request resolved: #88102
@ezyang ezyang added release notes: composability release notes category topic: not user facing topic category labels Nov 1, 2022
@ezyang
Copy link
Contributor Author

ezyang commented Nov 1, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 2 additional jobs have failed, first few of them are: trunk ,trunk / cuda11.6-py3.10-gcc7-sm86 / test (default, 2, 4, linux.g5.4xlarge.nvidia.gpu)

Details for Dev Infra team Raised by workflow job

@ezyang
Copy link
Contributor Author

ezyang commented Nov 1, 2022

@pytorchbot merge -f "unrelated flakiness"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Nov 5, 2022
@ezyang @kulinseth
Reenable assert sanity testing with ADInplaceOrView reenable (pytorch…
5cdf64e 
…#88102)

Signed-off-by: Edward Z. Yang <ezyang@fb.com>
Pull Request resolved: pytorch#88102
Approved by: https://github.com/albanD
kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Dec 10, 2022
@ezyang @kulinseth
Reenable assert sanity testing with ADInplaceOrView reenable (pytorch…
715a760 
…#88102)

Signed-off-by: Edward Z. Yang <ezyang@fb.com>
Pull Request resolved: pytorch#88102
Approved by: https://github.com/albanD
@facebook-github-bot facebook-github-bot deleted the gh/ezyang/1485/head branch June 8, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albanD albanD albanD approved these changes

@anjali411 anjali411 Awaiting requested review from anjali411

@antoniojkim antoniojkim Awaiting requested review from antoniojkim

@bdhirsh bdhirsh Awaiting requested review from bdhirsh

@Chillee Chillee Awaiting requested review from Chillee

@Krovatkin Krovatkin Awaiting requested review from Krovatkin

@miladm miladm Awaiting requested review from miladm

@wconstab wconstab Awaiting requested review from wconstab

Assignees
No one assigned
Labels
ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: composability release notes category topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ezyang @pytorchmergebot @albanD