Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix links to tutorial in torch masked docs #88129

Closed
wants to merge 2 commits into from
Closed

Fix links to tutorial in torch masked docs #88129

wants to merge 2 commits into from

Conversation

cpuhrsch
Copy link
Contributor

No description provided.

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 31, 2022 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/88129

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Failures

As of commit ed579c9:

The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@cpuhrsch cpuhrsch marked this pull request as ready for review October 31, 2022 20:09
jisaacso
jisaacso approved these changes Oct 31, 2022
View reviewed changes
Copy link

@jisaacso jisaacso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for fixing the broken links.

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 31, 2022
@cpuhrsch
Copy link
Contributor Author

@pytorchbot merge -f "docs"

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 31, 2022

You need to provide a reason for using force merge, in the format @pytorchbot merge -f 'Explanation'.
The explanation needs to be clear on why this is needed. Here are some good examples:

  • Bypass checks due to unrelated upstream failures from ...
  • This is a minor fix to ..., which shouldn't break anything
  • This is pre-tested in a previous CI run
  • Bypass flaky ... check

@cpuhrsch
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: The following mandatory check(s) failed (Rule superuser):

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

@cpuhrsch
Copy link
Contributor Author

@pytorchbot merge -f "unrelated failure"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Nov 5, 2022
@cpuhrsch @kulinseth
Fix links to tutorial in torch masked docs (pytorch#88129)
b535ae4 
Pull Request resolved: pytorch#88129
Approved by: https://github.com/jisaacso
kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Dec 10, 2022
@cpuhrsch @kulinseth
Fix links to tutorial in torch masked docs (pytorch#88129)
f72a1b8 
Pull Request resolved: pytorch#88129
Approved by: https://github.com/jisaacso
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jisaacso jisaacso jisaacso approved these changes

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cpuhrsch @pytorchmergebot @jisaacso