Add definitely_not_01 set to ShapeEnv. #89871
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This set tracks symbols which we know are definitely not 0/1, and thus can be further simplified when we try to work out their static value without guards. Right now, all allocated symbols are in this set, but we will later add symbols which don't uphold this. Signed-off-by: Edward Z. Yang <ezyang@fb.com> [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/89871
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit cf28250: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
ezyang
added a commit
that referenced
this pull request
Nov 29, 2022
This set tracks symbols which we know are definitely not 0/1, and thus can be further simplified when we try to work out their static value without guards. Right now, all allocated symbols are in this set, but we will later add symbols which don't uphold this. Signed-off-by: Edward Z. Yang <ezyangfb.com> ghstack-source-id: 6db6707 Pull Request resolved: #89871
github-actions
bot
requested review from
albanD,
anjali411,
antoniojkim,
bdhirsh,
Chillee,
miladm,
SherlockNoMad,
voznesenskym and
wconstab
ezyang
added
release notes: composability
albanD
approved these changes
Nov 29, 2022
This was referenced Nov 30, 2022
This was referenced Dec 1, 2022
kulinseth
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Dec 10, 2022
This set tracks symbols which we know are definitely not 0/1, and thus can be further simplified when we try to work out their static value without guards. Right now, all allocated symbols are in this set, but we will later add symbols which don't uphold this. Signed-off-by: Edward Z. Yang <ezyang@fb.com> Pull Request resolved: pytorch#89871 Approved by: https://github.com/albanD
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This set tracks symbols which we know are definitely not 0/1, and thus
can be further simplified when we try to work out their static value
without guards. Right now, all allocated symbols are in this set,
but we will later add symbols which don't uphold this.
Signed-off-by: Edward Z. Yang ezyang@fb.com