Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Reland][FSDP] Another fix for DTensor, use_orig_params=True #90562

Closed
wants to merge 1 commit into from

Conversation

awgu
Copy link
Contributor

@awgu awgu commented Dec 9, 2022

Stack from ghstack:

This is a reland of #89845 with nothing changed. This should avoid the internal breakage now that DTensor does not import torchgen (#90106).

@pytorch-bot
Copy link

pytorch-bot bot commented Dec 9, 2022

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/90562

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 42395ae:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: distributed (fsdp) release notes category label Dec 9, 2022
awgu added a commit that referenced this pull request Dec 9, 2022
ghstack-source-id: 8563cfd02653f8e5e26f009899470f6070270c3f
Pull Request resolved: #90562
@awgu awgu added the topic: bug fixes topic category label Dec 9, 2022
@awgu
Copy link
Contributor Author

awgu commented Dec 10, 2022

@awgu has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Copy link
Contributor

@fduwjj fduwjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@awgu
Copy link
Contributor Author

awgu commented Dec 10, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: distributed (fsdp) release notes category topic: bug fixes topic category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants