-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Reland][FSDP] Another fix for DTensor
, use_orig_params=True
#90562
Conversation
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/90562
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 42395ae: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
ghstack-source-id: 8563cfd02653f8e5e26f009899470f6070270c3f Pull Request resolved: #90562
@awgu has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Stack from ghstack:
HandleConfig
for mixed precision #90631 [FSDP] SanitizeHandleConfig
for mixed precisionreduce_dtype
#90615 [FSDP] Tighten post-bwd cast toreduce_dtype
_storage()
in test file #90622 [FSDP][Easy] Move to_storage()
in test file_stream_to_name
for debugging #90611 [FSDP] Save_stream_to_name
for debuggingDTensor
,use_orig_params=True
#90562 [Reland][FSDP] Another fix forDTensor
,use_orig_params=True
This is a reland of #89845 with nothing changed. This should avoid the internal breakage now that
DTensor
does not importtorchgen
(#90106).