Add utility for binding symbols based on arguments passed to placeholders #90912
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ders Signed-off-by: Edward Z. Yang <ezyang@fb.com> [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/90912
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 1615c8f: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
github-actions
bot
requested review from
albanD,
anjali411,
antoniojkim,
bdhirsh,
Chillee,
miladm,
SherlockNoMad,
voznesenskym and
wconstab
ezyang
added
release notes: composability
…to placeholders" Signed-off-by: Edward Z. Yang <ezyangfb.com> [ghstack-poisoned]
| @@ -768,6 +771,43 @@ def evaluate_guards_for_args(self, placeholders, args): | |||
| code = self.codegen_guards(placeholders, arg_names) | |||
| return eval(code, {}, dict(zip(arg_names, args))) | |||
|
|
|||
| def bind_symbols(self, placeholders, args): | |||
There was a problem hiding this comment.
can you add a small doc explaining what this does?
voznesenskym
approved these changes
Dec 15, 2022
…to placeholders" Signed-off-by: Edward Z. Yang <ezyangfb.com> [ghstack-poisoned]
|
This pull request has been merged in 67436f6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Signed-off-by: Edward Z. Yang ezyang@fb.com