lru_cache shape expansion (20-25% speedup on local bench) #92860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/92860
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit ef976db: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
github-actions
bot
requested review from
albanD,
antoniojkim,
bdhirsh,
Chillee,
ezyang,
jbschlosser,
miladm,
SherlockNoMad and
wconstab
voznesenskym
commented
Jan 23, 2023
| @@ -26,6 +26,17 @@ | |||
| from sympy.printing.precedence import precedence # type: ignore[import] # noqa: F401 | |||
| from sympy.printing.str import StrPrinter # type: ignore[import] | |||
| HAS_SYMPY = True | |||
|
|
|||
| original_expand = sympy.expand | |||
There was a problem hiding this comment.
note - this is a micro optimization on top of a bigger one, the lru_cache. We can make this PR simpler at a cost of a little perf by only caching our safe_expand instead of applying it to all sympy expand.
voznesenskym
changed the title
ezyang
approved these changes
Jan 24, 2023
|
but you should bug @Chillee to review this PR |
Chillee
approved these changes
Jan 24, 2023
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #ISSUE_NUMBER
cc @mlazos @soumith @yanboliang @penguinwu @anijain2305 @EikanWang @jgong5 @Guobing-Chen @chunyuan-w @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @desertfire