[package] Add better debugging for torch.package #92939
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/92939
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 8096290: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D42728753 |
| if debug: | ||
| module_path = dependency_graph.first_path(module_name) | ||
| message.write(f" A path to {module_name}: {' -> '.join(module_path)}") | ||
| if not debug: |
There was a problem hiding this comment.
shouldn't this be in the for loop?
There was a problem hiding this comment.
This error message specifically isn't related to an individual module and is just advertising the debug functionality. It wouldn't make sense to stick it in the loop.
|
This pull request was exported from Phabricator. Differential Revision: D42728753 |
PaliC
force-pushed
the
export-D42728753
branch
from
ec2a5e8 to
56d9793
Compare
|
@pytorchbot merge -g |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 1 mandatory check(s) failed (Rule Dig deeper by viewing the failures on hud Details for Dev Infra teamRaised by workflow job |
PaliC
force-pushed
the
export-D42728753
branch
from
56d9793 to
ec385c7
Compare
|
This pull request was exported from Phabricator. Differential Revision: D42728753 |
Summary: Pull Request resolved: pytorch#92939 Makes torch.package debugging more transparent by 1. Pointing out not implictily externed modules in the standard library. 2. Creating a debug mode for users to find the source of broken modules. Test Plan: Run package tests Reviewed By: kurman Differential Revision: D42728753 fbshipit-source-id: 78b18d330dc71f5aef8c6995d4479e6bddcee7e1
PaliC
force-pushed
the
export-D42728753
branch
from
ec385c7 to
8096290
Compare
|
This pull request was exported from Phabricator. Differential Revision: D42728753 |
|
@pytorchbot merge -g |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 1 jobs have failed, first few of them are: trunk / macos-12-py3-arm64 / test (default, 1, 2, macos-m1-12) Details for Dev Infra teamRaised by workflow job |
|
@pytorchbot merge -g |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Summary:
Makes torch.package debugging more transparent by
Test Plan: Run package tests
Differential Revision: D42728753