Skip to content

Conversation

DenisVieriu97
Copy link
Collaborator

Fixes empty placeholder error in inverse op. Change to any op should also resolve previously seen segfaults

@DenisVieriu97 DenisVieriu97 added the ciflow/mps Run MPS tests (subset of trunk) label Feb 9, 2023
@pytorch-bot
Copy link

pytorch-bot bot commented Feb 9, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/94551

Note: Links to docs will display an error until the docs builds have been completed.

❗ 2 Active SEVs

There are 2 currently active SEVs. If your PR is affected, please view them below:

❌ 1 Failures

As of commit ae8b966:

BROKEN TRUNK - The following jobs failed but were present on the merge base d8f4026:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: mps Release notes category label Feb 9, 2023
@DenisVieriu97
Copy link
Collaborator Author

@pytorchbot merge -f "Lint+MPS is green"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Comment on lines +101 to +102
if (@available(macOS 13.3, *))
_macos_13_3_plus = YES;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would never return True, as library availability level is equal to host executable availability level, which if I'm not mistaken is setup for 11.0 for all Python builds shipped by Anaconda

Copy link
Collaborator

@kulinseth kulinseth Feb 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, we didn't see this issue locally. But we will switch it out to a ObjC selector, in next PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/mps Run MPS tests (subset of trunk) Merged open source release notes: mps Release notes category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants