Skip to content

Update parallel_apply.py for assertion error when len(modules) != len(inputs) #94671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Update parallel_apply.py for assertion error when len(modules) != len(inputs) #94671

wants to merge 1 commit into from
+1 −1

Conversation

qkaTlehdrnf
Copy link
Contributor

Print the result why it is wrong.

@pytorch-bot
Copy link

pytorch-bot bot commented Feb 11, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/94671

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit b02e99b:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Feb 11, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: qkaTlehdrnf / name: Kim,Won-Joong (e6020c797aa5bef73b41d3aa0ce874927545aa67)

@kit1980
Copy link
Contributor

kit1980 commented Mar 20, 2023

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a rebase job. Check the current status here

@qkaTlehdrnf @pytorchmergebot
Update parallel_apply.py
b02e99b 
Print the result why it is wrong.
@pytorchmergebot
Copy link
Collaborator

Successfully rebased patch-1 onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout patch-1 && git pull --rebase)

@kit1980
Copy link
Contributor

kit1980 commented Mar 20, 2023

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Mar 20, 2023
@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR needs a label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

@qkaTlehdrnf
Copy link
Contributor Author

qkaTlehdrnf commented Mar 21, 2023 •
edited
Loading

@pytorchbot label release notes: python_frontend

@pytorch-bot
Copy link

pytorch-bot bot commented Mar 21, 2023

Didn't find following labels among repository labels: release,notes:,ui

@qkaTlehdrnf
Copy link
Contributor Author

@pytorchbot label release notes: python_frontend

@pytorch-bot
Copy link

pytorch-bot bot commented Mar 21, 2023

Didn't find following labels among repository labels: release,notes:,python_frontend

@qkaTlehdrnf
Copy link
Contributor Author

@pytorchbot label python_frontend

@pytorch-bot
Copy link

pytorch-bot bot commented Mar 21, 2023

Didn't find following labels among repository labels: python_frontend

@qkaTlehdrnf
Copy link
Contributor Author

@pytorchbot label "release notes: python_frontend"

@pytorch-bot pytorch-bot bot added the release notes: python_frontend python frontend release notes category label Mar 21, 2023
@kit1980
Copy link
Contributor

kit1980 commented Mar 21, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@kit1980 kit1980 mentioned this pull request Mar 21, 2023
Closed
pytorchmergebot pushed a commit that referenced this pull request Mar 22, 2023
@kit1980 @pytorchmergebot
Mention pytorchbot command on label error (#97267)
1e4e256 
It's not clear how to add a label, especially for contributors without write permissions - they don't have a UI for that.

One recent struggle example - #94671
Pull Request resolved: #97267
Approved by: https://github.com/PaliC, https://github.com/malfet, https://github.com/seemethere
cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 23, 2023
@qkaTlehdrnf @cyyever
Update parallel_apply.py for assertion error when len(modules) != len…
adb93b6 
…(inputs) (#94671)

Print the result why it is wrong.

Pull Request resolved: pytorch/pytorch#94671
Approved by: https://github.com/ngimel, https://github.com/kit1980
cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 23, 2023
@kit1980 @cyyever
Mention pytorchbot command on label error (#97267)
dfcacbb 
It's not clear how to add a label, especially for contributors without write permissions - they don't have a UI for that.

One recent struggle example - pytorch/pytorch#94671
Pull Request resolved: pytorch/pytorch#97267
Approved by: https://github.com/PaliC, https://github.com/malfet, https://github.com/seemethere
cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 27, 2023
@qkaTlehdrnf @cyyever
Update parallel_apply.py for assertion error when len(modules) != len…
88e8ba1 
…(inputs) (#94671)

Print the result why it is wrong.

Pull Request resolved: pytorch/pytorch#94671
Approved by: https://github.com/ngimel, https://github.com/kit1980
cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 27, 2023
@kit1980 @cyyever
Mention pytorchbot command on label error (#97267)
e6fee5b 
It's not clear how to add a label, especially for contributors without write permissions - they don't have a UI for that.

One recent struggle example - pytorch/pytorch#94671
Pull Request resolved: pytorch/pytorch#97267
Approved by: https://github.com/PaliC, https://github.com/malfet, https://github.com/seemethere
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ngimel ngimel ngimel approved these changes

@mrshenli mrshenli Awaiting requested review from mrshenli

@zhaojuanmao zhaojuanmao Awaiting requested review from zhaojuanmao

@rohan-varma rohan-varma Awaiting requested review from rohan-varma

@H-Huang H-Huang Awaiting requested review from H-Huang

@awgu awgu Awaiting requested review from awgu

@kwen2501 kwen2501 Awaiting requested review from kwen2501

@wanchaol wanchaol Awaiting requested review from wanchaol

@fegin fegin Awaiting requested review from fegin

@kiukchung kiukchung Awaiting requested review from kiukchung

@d4l3k d4l3k Awaiting requested review from d4l3k

+1 more reviewer

@kit1980 kit1980 kit1980 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: python_frontend python frontend release notes category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@qkaTlehdrnf @kit1980 @pytorchmergebot @ngimel @pytorchbot