Back out "fix: make sure sorter indices are inbound in searchsorted (#94863)"

[weiwangmeta]

Summary:
Original commit changeset: 96a2200d1fd8

Original Phabricator Diff: D43342962

Test Plan: Sandcastle and land castle as well as buck2 build mode/opt //frl/et/projects/Masquerade/stable/datasets/masquerade/c6p7:post_processing

Reviewed By: seemethere, bigfootjon

Differential Revision: D43402398

@bypass-github-export-checks

[pytorch-bot]

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/95086

• 📄 Preview Python docs built from this PR
• 📄 Preview C++ docs built from this PR
• ❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

❌ 5 Failures

As of commit 2dd1d71:

NEW FAILURES - The following jobs have failed:

• linux-bionic-cuda11.7-py3.10-gcc7-sm86 / test (default, 1, 4, linux.g5.4xlarge.nvidia.gpu)
• linux-bionic-cuda11.7-py3.10-gcc7-sm86 / test (default, 3, 4, linux.g5.4xlarge.nvidia.gpu)
• linux-bionic-cuda11.7-py3.10-gcc7-sm86 / test (default, 4, 4, linux.g5.4xlarge.nvidia.gpu)
• linux-bionic-cuda11.7-py3.10-gcc7-sm86 / test (slow, 2, 2, linux.g5.4xlarge.nvidia.gpu)
• linux-focal-py3.9-clang7-asan / test (default, 2, 5, linux.4xlarge)

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[facebook-github-bot]

This pull request was exported from Phabricator. Differential Revision: D43402398

[bigfootjon]

Mirroring my fbsource review

[facebook-github-bot]

@pytorchbot merge -f 'Landed internally'

(Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally)

[pytorchmergebot]

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

[ganler]

Hi @weiwangmeta @bigfootjon Can you kindly let me know the reason for reverting? Thanks!

[ngimel]

Internal build errors

fbcode/caffe2/aten/src/ATen/native/BucketizationUtils.h(139): error: expected an identifier
fbcode/caffe2/aten/src/ATen/native/BucketizationUtils.h(139): error: identifier "vmin" is undefined
fbcode/caffe2/aten/src/ATen/native/BucketizationUtils.h(139): error: identifier "vmax" is undefined

looks like there are some builds without c++17 lol, sorry about that.

[weiwangmeta]

Internal build errors

fbcode/caffe2/aten/src/ATen/native/BucketizationUtils.h(139): error: expected an identifier
fbcode/caffe2/aten/src/ATen/native/BucketizationUtils.h(139): error: identifier "vmin" is undefined
fbcode/caffe2/aten/src/ATen/native/BucketizationUtils.h(139): error: identifier "vmax" is undefined

fbcode/caffe2 == pytorch here.

[ganler]

Oh I am sorry, I should have avoid using C++17 features. Will redo the PR with C++14 style.

[ngimel]

We all can't wait to use C++17 :-)